diff mbox series

mkfs.xfs.8: correction on mkfs.xfs manpage since reflink and dax are compatible

Message ID 20230728222017.178599-1-bodonnel@redhat.com (mailing list archive)
State Accepted, archived
Headers show
Series mkfs.xfs.8: correction on mkfs.xfs manpage since reflink and dax are compatible | expand

Commit Message

Bill O'Donnell July 28, 2023, 10:20 p.m. UTC
Merged early in 2023: Commit 480017957d638 xfs: remove restrictions for fsdax
and reflink. There needs to be a corresponding change to the mkfs.xfs manpage
to remove the incompatiblity statement.

Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>
---
 man/man8/mkfs.xfs.8.in | 7 -------
 1 file changed, 7 deletions(-)

Comments

Darrick J. Wong July 28, 2023, 10:33 p.m. UTC | #1
On Fri, Jul 28, 2023 at 05:20:17PM -0500, Bill O'Donnell wrote:
> Merged early in 2023: Commit 480017957d638 xfs: remove restrictions for fsdax
> and reflink. There needs to be a corresponding change to the mkfs.xfs manpage
> to remove the incompatiblity statement.
> 
> Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>
> ---
>  man/man8/mkfs.xfs.8.in | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in
> index ce6f1e2d..08bb92f6 100644
> --- a/man/man8/mkfs.xfs.8.in
> +++ b/man/man8/mkfs.xfs.8.in
> @@ -323,13 +323,6 @@ option set. When the option
>  .B \-m crc=0
>  is used, the reference count btree feature is not supported and reflink is
>  disabled.
> -.IP
> -Note: the filesystem DAX mount option (
> -.B \-o dax
> -) is incompatible with
> -reflink-enabled XFS filesystems.  To use filesystem DAX with XFS, specify the
> -.B \-m reflink=0
> -option to mkfs.xfs to disable the reflink feature.

D'oh, we forgot to remove that.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

>  .RE
>  .PP
>  .PD 0
> -- 
> 2.41.0
>
Carlos Maiolino Aug. 2, 2023, 8:52 a.m. UTC | #2
On Fri, Jul 28, 2023 at 05:20:17PM -0500, Bill O'Donnell wrote:
> Merged early in 2023: Commit 480017957d638 xfs: remove restrictions for fsdax
> and reflink. There needs to be a corresponding change to the mkfs.xfs manpage
> to remove the incompatiblity statement.
> 
> Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> ---
>  man/man8/mkfs.xfs.8.in | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in
> index ce6f1e2d..08bb92f6 100644
> --- a/man/man8/mkfs.xfs.8.in
> +++ b/man/man8/mkfs.xfs.8.in
> @@ -323,13 +323,6 @@ option set. When the option
>  .B \-m crc=0
>  is used, the reference count btree feature is not supported and reflink is
>  disabled.
> -.IP
> -Note: the filesystem DAX mount option (
> -.B \-o dax
> -) is incompatible with
> -reflink-enabled XFS filesystems.  To use filesystem DAX with XFS, specify the
> -.B \-m reflink=0
> -option to mkfs.xfs to disable the reflink feature.
>  .RE
>  .PP
>  .PD 0
> --
> 2.41.0
>
diff mbox series

Patch

diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in
index ce6f1e2d..08bb92f6 100644
--- a/man/man8/mkfs.xfs.8.in
+++ b/man/man8/mkfs.xfs.8.in
@@ -323,13 +323,6 @@  option set. When the option
 .B \-m crc=0
 is used, the reference count btree feature is not supported and reflink is
 disabled.
-.IP
-Note: the filesystem DAX mount option (
-.B \-o dax
-) is incompatible with
-reflink-enabled XFS filesystems.  To use filesystem DAX with XFS, specify the
-.B \-m reflink=0
-option to mkfs.xfs to disable the reflink feature.
 .RE
 .PP
 .PD 0