diff mbox series

[net-next] net: Space.h: Remove unused function declarations

Message ID 20230802130716.37308-1-yuehaibing@huawei.com (mailing list archive)
State Accepted
Commit 992725ff32f534eaa13adfa37f933d4fbf1aa040
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net: Space.h: Remove unused function declarations | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1331 this patch: 1331
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 1351 this patch: 1351
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1351 this patch: 1351
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 15 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Yue Haibing Aug. 2, 2023, 1:07 p.m. UTC
Commit 5aa83a4c0a15 ("  [PATCH] remove two obsolete net drivers") remove fmv18x_probe().
And commmit 01f4685797a5 ("eth: amd: remove NI6510 support (ni65)") leave ni65_probe().
Commit a10079c66290 ("staging: remove hp100 driver") remove hp100 driver and hp100_probe()
declaration is not used anymore.

sonic_probe() and iph5526_probe() are never implemented since the beginning of git history.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 include/net/Space.h | 7 -------
 1 file changed, 7 deletions(-)

Comments

Stephen Hemminger Aug. 2, 2023, 4:41 p.m. UTC | #1
On Wed, 2 Aug 2023 21:07:16 +0800
Yue Haibing <yuehaibing@huawei.com> wrote:

> Commit 5aa83a4c0a15 ("  [PATCH] remove two obsolete net drivers") remove fmv18x_probe().
> And commmit 01f4685797a5 ("eth: amd: remove NI6510 support (ni65)") leave ni65_probe().
> Commit a10079c66290 ("staging: remove hp100 driver") remove hp100 driver and hp100_probe()
> declaration is not used anymore.
> 
> sonic_probe() and iph5526_probe() are never implemented since the beginning of git history.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

The static setup in Space.h is a legacy from early days (pre 2.6).
Should go away, but probably has to wait until ISA bus support goes away.
patchwork-bot+netdevbpf@kernel.org Aug. 4, 2023, 1:30 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 2 Aug 2023 21:07:16 +0800 you wrote:
> Commit 5aa83a4c0a15 ("  [PATCH] remove two obsolete net drivers") remove fmv18x_probe().
> And commmit 01f4685797a5 ("eth: amd: remove NI6510 support (ni65)") leave ni65_probe().
> Commit a10079c66290 ("staging: remove hp100 driver") remove hp100 driver and hp100_probe()
> declaration is not used anymore.
> 
> sonic_probe() and iph5526_probe() are never implemented since the beginning of git history.
> 
> [...]

Here is the summary with links:
  - [net-next] net: Space.h: Remove unused function declarations
    https://git.kernel.org/netdev/net-next/c/992725ff32f5

You are awesome, thank you!
diff mbox series

Patch

diff --git a/include/net/Space.h b/include/net/Space.h
index 08ca9cef0213..c29f3d51c078 100644
--- a/include/net/Space.h
+++ b/include/net/Space.h
@@ -3,18 +3,11 @@ 
  * ethernet adaptor have the name "eth[0123...]".
  */
 
-struct net_device *hp100_probe(int unit);
 struct net_device *ultra_probe(int unit);
 struct net_device *wd_probe(int unit);
 struct net_device *ne_probe(int unit);
-struct net_device *fmv18x_probe(int unit);
-struct net_device *ni65_probe(int unit);
-struct net_device *sonic_probe(int unit);
 struct net_device *smc_init(int unit);
 struct net_device *cs89x0_probe(int unit);
 struct net_device *tc515_probe(int unit);
 struct net_device *lance_probe(int unit);
 struct net_device *cops_probe(int unit);
-
-/* Fibre Channel adapters */
-int iph5526_probe(struct net_device *dev);