| Message ID | 20230424101352.28117-2-Delphine_CC_Chiu@Wiwynn.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | LTC4286 and LTC4287 driver support | expand |
On Mon, 24 Apr 2023 18:13:49 +0800, Delphine CC Chiu wrote: > Add a device tree bindings for ltc4286 driver. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > --- > .../bindings/hwmon/lltc,ltc4286.yaml | 47 +++++++++++++++++++ > MAINTAINERS | 9 ++++ > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dts:22.17-30: Warning (reg_format): /example-0/i2c/ltc4286@40:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dts:18.13-26.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dts:18.13-26.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge' Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dts:20.24-25.15: Warning (avoid_default_addr_size): /example-0/i2c/ltc4286@40: Relying on default #address-cells value Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dts:20.24-25.15: Warning (avoid_default_addr_size): /example-0/i2c/ltc4286@40: Relying on default #size-cells value Documentation/devicetree/bindings/hwmon/lltc,ltc4286.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size' doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230424101352.28117-2-Delphine_CC_Chiu@Wiwynn.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Apr 24, 2023 at 06:13:49PM +0800, Delphine CC Chiu wrote: > Add a device tree bindings for ltc4286 driver. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > --- > .../bindings/hwmon/lltc,ltc4286.yaml | 47 +++++++++++++++++++ > MAINTAINERS | 9 ++++ > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > new file mode 100644 > index 000000000000..c1c8e310f9c4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LTC4286 power monitors > + > +maintainers: > + - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > + > +properties: > + compatible: > + enum: > + - lltc,ltc4286 > + - lltc,ltc4287 There is no LTC4287, at least according to the Analog website. > + > + reg: > + maxItems: 1 > + > + vrange_select_25p6: > + description: > + This property is a bool parameter to represent the > + voltage range is 25.6 or not for this chip. Existing attributes are adi,vrange-high-enable, ti,extended-range-enable, ti,bus-range-microvolt, adi,range-double. I would suggest to use adi,vrange-high-enable. > + > + rsense-micro-ohms: > + description: > + Resistor value in micro-Ohm I would suggest either shunt-resistor-micro-ohms or sense-resistor-micro-ohms as used by other bindings. > + > +required: > + - compatible > + - reg > + - rsense-micro-ohms > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + status = "okay"; > + ltc4286@40 { > + compatible = "lltc,ltc4286"; > + reg = <0x40>; > + vrange_select_25p6; > + rsense-micro-ohms = <300>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index c6545eb54104..930bdba0f73c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12183,6 +12183,15 @@ S: Maintained > F: Documentation/hwmon/ltc4261.rst > F: drivers/hwmon/ltc4261.c > > +LTC4286 HARDWARE MONITOR DRIVER > +M: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > +L: linux-i2c@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > +F: drivers/hwmon/pmbus/Kconfig > +F: drivers/hwmon/pmbus/Makefile > +F: drivers/hwmon/pmbus/ltc4286.c > + > LTC4306 I2C MULTIPLEXER DRIVER > M: Michael Hennerich <michael.hennerich@analog.com> > L: linux-i2c@vger.kernel.org > -- > 2.17.1 >
> -----Original Message----- > From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck > Sent: Monday, April 24, 2023 9:50 PM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com> > Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Rob Herring > <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; linux-i2c@vger.kernel.org; > linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v1 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver > bindings > > Security Reminder: Please be aware that this email is sent by an external > sender. > > On Mon, Apr 24, 2023 at 06:13:49PM +0800, Delphine CC Chiu wrote: > > Add a device tree bindings for ltc4286 driver. > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > > --- > > .../bindings/hwmon/lltc,ltc4286.yaml | 47 > +++++++++++++++++++ > > MAINTAINERS | 9 ++++ > > 2 files changed, 56 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > new file mode 100644 > > index 000000000000..c1c8e310f9c4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > @@ -0,0 +1,47 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fhwmon%2Flltc%2Cltc4286.yaml%23&data=05%7C > 01%7C > > > +Wayne_SC_Liu%40wiwynn.com%7Cac3bc6cdf556435cfa0f08db44cabd06%7C > da6e06 > > > +28fc834caf9dd273061cbab167%7C0%7C0%7C638179409777006260%7CUnk > nown%7CT > > > +WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC > JXVC > > > +I6Mn0%3D%7C3000%7C%7C%7C&sdata=8d9ycpebE%2FrhafDDmDL9sefo1xq > m%2B9r%2F > > +Wm0Cu1McEOs%3D&reserved=0 > > +$schema: > > +https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7CWayne_S > C_Liu% > > > +40wiwynn.com%7Cac3bc6cdf556435cfa0f08db44cabd06%7Cda6e0628fc834c > af9dd > > > +273061cbab167%7C0%7C0%7C638179409777006260%7CUnknown%7CTWFp > bGZsb3d8ey > > > +JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > %7C30 > > > +00%7C%7C%7C&sdata=u4yJaVeL2xSUE2%2FaNpEbQ3KJiy%2BcxtKG95gGuaGI > LFU%3D& > > +reserved=0 > > + > > +title: LTC4286 power monitors > > + > > +maintainers: > > + - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > > + > > +properties: > > + compatible: > > + enum: > > + - lltc,ltc4286 > > + - lltc,ltc4287 > > There is no LTC4287, at least according to the Analog website. It has been announced on Analog Devices website. Please refer to this link: https://www.analog.com/en/products/ltc2487.html#product-overview > > > + > > + reg: > > + maxItems: 1 > > + > > + vrange_select_25p6: > > + description: > > + This property is a bool parameter to represent the > > + voltage range is 25.6 or not for this chip. > > Existing attributes are adi,vrange-high-enable, ti,extended-range-enable, > ti,bus-range-microvolt, adi,range-double. I would suggest to use > adi,vrange-high-enable. The vrange for this chip is either 102.4 or 25.6, and default is 102.4 So, we think vrange_select_25p6 may be more appropriate > > > + > > + rsense-micro-ohms: > > + description: > > + Resistor value in micro-Ohm > > I would suggest either shunt-resistor-micro-ohms or > sense-resistor-micro-ohms as used by other bindings. We will revise to shunt-resistor-micro-ohms. > > > + > > +required: > > + - compatible > > + - reg > > + - rsense-micro-ohms > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + status = "okay"; > > + ltc4286@40 { > > + compatible = "lltc,ltc4286"; > > + reg = <0x40>; > > + vrange_select_25p6; > > + rsense-micro-ohms = <300>; > > + }; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS index > > c6545eb54104..930bdba0f73c 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -12183,6 +12183,15 @@ S: Maintained > > F: Documentation/hwmon/ltc4261.rst > > F: drivers/hwmon/ltc4261.c > > > > +LTC4286 HARDWARE MONITOR DRIVER > > +M: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> > > +L: linux-i2c@vger.kernel.org > > +S: Maintained > > +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > +F: drivers/hwmon/pmbus/Kconfig > > +F: drivers/hwmon/pmbus/Makefile > > +F: drivers/hwmon/pmbus/ltc4286.c > > + > > LTC4306 I2C MULTIPLEXER DRIVER > > M: Michael Hennerich <michael.hennerich@analog.com> > > L: linux-i2c@vger.kernel.org > > -- > > 2.17.1 > >
On 7/23/23 19:12, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: >>> +properties: >>> + compatible: >>> + enum: >>> + - lltc,ltc4286 >>> + - lltc,ltc4287 >> >> There is no LTC4287, at least according to the Analog website. > It has been announced on Analog Devices website. > Please refer to this link: https://www.analog.com/en/products/ltc2487.html#product-overview > No, that is wrong. You are pointing to ltc2487, which is something completely different. Guenter
> -----Original Message----- > From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck > Sent: Monday, July 24, 2023 11:22 AM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com> > Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Rob Herring > <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; linux-i2c@vger.kernel.org; > linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v1 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver > bindings > > Security Reminder: Please be aware that this email is sent by an external > sender. > > On 7/23/23 19:12, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: > > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - lltc,ltc4286 > >>> + - lltc,ltc4287 > >> > >> There is no LTC4287, at least according to the Analog website. > > It has been announced on Analog Devices website. > > Please refer to this link: > > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww. > > > analog.com%2Fen%2Fproducts%2Fltc2487.html%23product-overview&data=0 > 5%7 > > > C01%7CWayne_SC_Liu%40wiwynn.com%7Cd97a86a696a54f28a26408db8bf52 > 23d%7Cd > > > a6e0628fc834caf9dd273061cbab167%7C0%7C0%7C638257657193005539%7C > Unknown > > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > wiLCJ > > > XVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XrdlzCyq0pcjfv3M6QNX73Ieux0w > rfNKzNvv > > HgVSH40%3D&reserved=0 > > > > No, that is wrong. You are pointing to ltc2487, which is something completely > different. > We have sent e-mail to query about the release date for LTC4287 chip. Analog Device reply that they will release this chip in last week of Sep, 2023. Please refer to the attachment to review their reply. > Guenter Security Reminder: Please be aware that this email is sent by an external sender. Hi Wayne, To be specific, last week of Sep, 2023. Thanks. Regards, Jason Tai Senior Engineer, Field Applications Mobile (+886) (0) 922-226-527 -----Original Message----- From: Wayne SC Liu/WYHQ/Wiwynn <Wayne_SC_Liu@wiwynn.com> Sent: Tuesday, July 25, 2023 1:19 PM To: Tai, Jason <Jason.Tai@analog.com> Cc: openbmc_compute@meta.com; Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com> Subject: RE: The release date about LTC4287 [External] Loop more Wiwynn BMC member > -----Original Message----- > From: Wayne SC Liu/WYHQ/Wiwynn > Sent: Tuesday, July 25, 2023 10:40 AM > To: 'Jason.Tai@analog.com' <Jason.Tai@analog.com> > Cc: 'openbmc_compute@meta.com' <openbmc_compute@meta.com>; Delphine > Chiu/WYHQ/Wiwynn <DELPHINE_CHIU@wiwynn.com>; Bonnie Lo/WYHQ/Wiwynn > <Bonnie_Lo@wiwynn.com>; Sara SY Lin/WYHQ/Wiwynn > <Sara_SY_Lin@wiwynn.com>; Ricky CX Wu/WYHQ/Wiwynn > <Ricky_CX_Wu@wiwynn.com>; Jeff Shih/WYHQ/Wiwynn <Jeff_Shih@wiwynn.com> > Subject: The release date about LTC4287 > > Hi Jason, > > I am Wiwynn BMC Wayne. > > We have contributed the Linux driver for LTC4286 and LTC4287 chips. > > However, Linux reviewer doesn't agree with our contribution because > LTC4287 chip still not release on Aanlog Device website. > (Please refer to the attachment) > > Moreover, our customer Meta plans to use LTC4287 in next generation > product so we need driver to access this device. > > Do you have the exact release date about this chip? > > Thanks. > Wayne > WIWYNN PROPRIETARY This email (and any attachments) contains proprietary or confidential information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited. If you are not the intended recipient, please notify the sender and delete this email immediately.
On 8/1/23 22:31, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: >> -----Original Message----- >> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck >> Sent: Monday, July 24, 2023 11:22 AM >> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com> >> Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Rob Herring >> <robh+dt@kernel.org>; Krzysztof Kozlowski >> <krzysztof.kozlowski+dt@linaro.org>; linux-i2c@vger.kernel.org; >> linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org; >> linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v1 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver >> bindings >> >> Security Reminder: Please be aware that this email is sent by an external >> sender. >> >> On 7/23/23 19:12, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: >> >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - lltc,ltc4286 >>>>> + - lltc,ltc4287 >>>> >>>> There is no LTC4287, at least according to the Analog website. >>> It has been announced on Analog Devices website. >>> Please refer to this link: >>> https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww. >>> >> analog.com%2Fen%2Fproducts%2Fltc2487.html%23product-overview&data=0 >> 5%7 >>> >> C01%7CWayne_SC_Liu%40wiwynn.com%7Cd97a86a696a54f28a26408db8bf52 >> 23d%7Cd >>> >> a6e0628fc834caf9dd273061cbab167%7C0%7C0%7C638257657193005539%7C >> Unknown >>> >> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW >> wiLCJ >>> >> XVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XrdlzCyq0pcjfv3M6QNX73Ieux0w >> rfNKzNvv >>> HgVSH40%3D&reserved=0 >>> >> >> No, that is wrong. You are pointing to ltc2487, which is something completely >> different. >> > > We have sent e-mail to query about the release date for LTC4287 chip. > Analog Device reply that they will release this chip in last week of Sep, 2023. > Please refer to the attachment to review their reply. > At least according to the driver code, LTC4286 and the LTC4287 are functionally identical. I am kind of puzzled why you insist mentioning the not-yet-existing LTC4287; instantiating LTC4287 as LTC4286 should work perfectly fine. LTC4287 can always be added as devicetree reference if/when it officially exists. Care to explain ? Note: If the chips are _not_ functionally identical, and a follow-up patch will be needed to add full LTC4287 support to the driver after the chip has been published, it would be inappropriate to make partial/incomplete changes now. With that possibility in mind, I am not inclined to accept a driver that is even mentioning LTC4287 without access to its datasheet because I think it is important for me to understand the differences and similarities between the two chips. Guenter
diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml new file mode 100644 index 000000000000..c1c8e310f9c4 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LTC4286 power monitors + +maintainers: + - Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> + +properties: + compatible: + enum: + - lltc,ltc4286 + - lltc,ltc4287 + + reg: + maxItems: 1 + + vrange_select_25p6: + description: + This property is a bool parameter to represent the + voltage range is 25.6 or not for this chip. + + rsense-micro-ohms: + description: + Resistor value in micro-Ohm + +required: + - compatible + - reg + - rsense-micro-ohms + +additionalProperties: false + +examples: + - | + i2c { + status = "okay"; + ltc4286@40 { + compatible = "lltc,ltc4286"; + reg = <0x40>; + vrange_select_25p6; + rsense-micro-ohms = <300>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index c6545eb54104..930bdba0f73c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12183,6 +12183,15 @@ S: Maintained F: Documentation/hwmon/ltc4261.rst F: drivers/hwmon/ltc4261.c +LTC4286 HARDWARE MONITOR DRIVER +M: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> +L: linux-i2c@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml +F: drivers/hwmon/pmbus/Kconfig +F: drivers/hwmon/pmbus/Makefile +F: drivers/hwmon/pmbus/ltc4286.c + LTC4306 I2C MULTIPLEXER DRIVER M: Michael Hennerich <michael.hennerich@analog.com> L: linux-i2c@vger.kernel.org
Add a device tree bindings for ltc4286 driver. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com> --- .../bindings/hwmon/lltc,ltc4286.yaml | 47 +++++++++++++++++++ MAINTAINERS | 9 ++++ 2 files changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml