| Message ID | 20230804125156.1387542-1-javierm@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION | expand |
On Fri, 4 Aug 2023 at 14:52, Javier Martinez Canillas <javierm@redhat.com> wrote: > > The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev > emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' > to an effective 'select FB_CORE', so any config that previously had DRM=y > and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. > > This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > as reported by Arthur Grillo, e.g: > > WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] > Selected by [y]: > - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] > > Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the > DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could > be to enable DRM fbdev emulation but without a framebuffer console. > > Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") > Reported-by: Arthur Grillo <arthurgrillo@riseup.net> > Closes: https://lore.kernel.org/dri-devel/20230726220325.278976-1-arthurgrillo@riseup.net > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Yeah originally this was just to help people not misconfigure their kernels and end up with a black screen. But select is really not a nice way to do that, imo we could drop the FB_CORE select too :-) Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Cheers, Sima > --- > > drivers/gpu/drm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index b51c6a141dfa..2a44b9419d4d 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM > - select FRAMEBUFFER_CONSOLE if !EXPERT > select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > default y > help > -- > 2.41.0 >
On Fri, Aug 4, 2023, at 15:07, Daniel Vetter wrote: > On Fri, 4 Aug 2023 at 14:52, Javier Martinez Canillas > <javierm@redhat.com> wrote: >> >> The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev >> emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' >> to an effective 'select FB_CORE', so any config that previously had DRM=y >> and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. >> >> This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE >> as reported by Arthur Grillo, e.g: >> >> WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE >> Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] >> Selected by [y]: >> - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] >> >> Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the >> DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could >> be to enable DRM fbdev emulation but without a framebuffer console. >> >> Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") >> Reported-by: Arthur Grillo <arthurgrillo@riseup.net> >> Closes: https://lore.kernel.org/dri-devel/20230726220325.278976-1-arthurgrillo@riseup.net >> Suggested-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > > Yeah originally this was just to help people not misconfigure their > kernels and end up with a black screen. But select is really not a > nice way to do that, imo we could drop the FB_CORE select too :-) Droping the 'FB_CORE' select only works if we make FB_CORE user visible and add a 'depends on' for it instead. Not sure this is any better since this would only ever be used when either CONFIG_FB or CONFIG_DRM_FBDEV_EMULATION is enabled. Arnd
"Arnd Bergmann" <arnd@arndb.de> writes: > On Fri, Aug 4, 2023, at 15:07, Daniel Vetter wrote: >> On Fri, 4 Aug 2023 at 14:52, Javier Martinez Canillas >> <javierm@redhat.com> wrote: >>> >>> The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev >>> emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' >>> to an effective 'select FB_CORE', so any config that previously had DRM=y >>> and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. >>> >>> This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE >>> as reported by Arthur Grillo, e.g: >>> >>> WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE >>> Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] >>> Selected by [y]: >>> - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] >>> >>> Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the >>> DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could >>> be to enable DRM fbdev emulation but without a framebuffer console. >>> >>> Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") >>> Reported-by: Arthur Grillo <arthurgrillo@riseup.net> >>> Closes: https://lore.kernel.org/dri-devel/20230726220325.278976-1-arthurgrillo@riseup.net >>> Suggested-by: Arnd Bergmann <arnd@arndb.de> >>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> >> >> Yeah originally this was just to help people not misconfigure their >> kernels and end up with a black screen. But select is really not a >> nice way to do that, imo we could drop the FB_CORE select too :-) > > Droping the 'FB_CORE' select only works if we make FB_CORE user > visible and add a 'depends on' for it instead. Not sure this > is any better since this would only ever be used when either > CONFIG_FB or CONFIG_DRM_FBDEV_EMULATION is enabled. > Agreed.
On 04/08/23 09:51, Javier Martinez Canillas wrote: > The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev > emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' > to an effective 'select FB_CORE', so any config that previously had DRM=y > and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. > > This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > as reported by Arthur Grillo, e.g: > > WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] > Selected by [y]: > - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] > > Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the > DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could > be to enable DRM fbdev emulation but without a framebuffer console. > > Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") > Reported-by: Arthur Grillo <arthurgrillo@riseup.net> > Closes: https://lore.kernel.org/dri-devel/20230726220325.278976-1-arthurgrillo@riseup.net > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > --- Greate patch! I was about to send the same one XD. Reviewed-by: Arthur Grillo <arthurgrillo@riseup.net> Best Regards, ~Arthur Grillo > > drivers/gpu/drm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index b51c6a141dfa..2a44b9419d4d 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM > - select FRAMEBUFFER_CONSOLE if !EXPERT > select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > default y > help
Arthur Grillo <arthurgrillo@riseup.net> writes: > On 04/08/23 09:51, Javier Martinez Canillas wrote: >> The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev >> emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' >> to an effective 'select FB_CORE', so any config that previously had DRM=y >> and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. >> >> This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE >> as reported by Arthur Grillo, e.g: >> >> WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE >> Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] >> Selected by [y]: >> - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] >> >> Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the >> DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could >> be to enable DRM fbdev emulation but without a framebuffer console. >> >> Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") >> Reported-by: Arthur Grillo <arthurgrillo@riseup.net> >> Closes: https://lore.kernel.org/dri-devel/20230726220325.278976-1-arthurgrillo@riseup.net >> Suggested-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> >> --- > > Greate patch! I was about to send the same one XD. > > Reviewed-by: Arthur Grillo <arthurgrillo@riseup.net> > Pushed to drm-misc (drm-misc-next). Thanks!
On 8/4/23 05:51, Javier Martinez Canillas wrote: > The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev > emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' > to an effective 'select FB_CORE', so any config that previously had DRM=y > and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. > > This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > as reported by Arthur Grillo, e.g: > > WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] > Selected by [y]: > - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] > > Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the > DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could > be to enable DRM fbdev emulation but without a framebuffer console. > > Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") > Reported-by: Arthur Grillo <arthurgrillo@riseup.net> > Closes: https://lore.kernel.org/dri-devel/20230726220325.278976-1-arthurgrillo@riseup.net > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > > drivers/gpu/drm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index b51c6a141dfa..2a44b9419d4d 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM > - select FRAMEBUFFER_CONSOLE if !EXPERT > select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > default y > help
Randy Dunlap <rdunlap@infradead.org> writes: Hello Randy, > On 8/4/23 05:51, Javier Martinez Canillas wrote: >> The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev >> emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' >> to an effective 'select FB_CORE', so any config that previously had DRM=y >> and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. >> >> This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE >> as reported by Arthur Grillo, e.g: >> >> WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE >> Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] >> Selected by [y]: >> - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] >> >> Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the >> DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could >> be to enable DRM fbdev emulation but without a framebuffer console. >> >> Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") >> Reported-by: Arthur Grillo <arthurgrillo@riseup.net> >> Closes: https://lore.kernel.org/dri-devel/20230726220325.278976-1-arthurgrillo@riseup.net >> Suggested-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > > Acked-by: Randy Dunlap <rdunlap@infradead.org> > Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested > I have already pushed this patch so I won't be able to add these tags but thanks a lot for testing and confirming that the patch fixes your issue! > Thanks. > >
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index b51c6a141dfa..2a44b9419d4d 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE default y help
The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g: WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]: - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console. Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") Reported-by: Arthur Grillo <arthurgrillo@riseup.net> Closes: https://lore.kernel.org/dri-devel/20230726220325.278976-1-arthurgrillo@riseup.net Suggested-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- drivers/gpu/drm/Kconfig | 1 - 1 file changed, 1 deletion(-)