diff mbox series

[net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port()

Message ID 20230805110009.44560-1-yuehaibing@huawei.com (mailing list archive)
State Accepted
Commit cc97777c80fdfabe12997581131872a03fdcf683
Delegated to: Netdev Maintainers
Headers show
Series [net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port() | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1441 this patch: 1441
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 1357 this patch: 1357
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1524 this patch: 1524
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 15 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Yue Haibing Aug. 5, 2023, 11 a.m. UTC
Commit 6ba5a3c52da0 ("[UDP]: Make full use of proto.h.udp_hash innovation.")
removed these implementations but leave declarations.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 include/net/udp.h     | 3 ---
 include/net/udplite.h | 2 --
 2 files changed, 5 deletions(-)

Comments

Willem de Bruijn Aug. 5, 2023, 6:35 p.m. UTC | #1
Yue Haibing wrote:
> Commit 6ba5a3c52da0 ("[UDP]: Make full use of proto.h.udp_hash innovation.")
> removed these implementations but leave declarations.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>
patchwork-bot+netdevbpf@kernel.org Aug. 7, 2023, 8 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sat, 5 Aug 2023 19:00:09 +0800 you wrote:
> Commit 6ba5a3c52da0 ("[UDP]: Make full use of proto.h.udp_hash innovation.")
> removed these implementations but leave declarations.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/net/udp.h     | 3 ---
>  include/net/udplite.h | 2 --
>  2 files changed, 5 deletions(-)

Here is the summary with links:
  - [net-next] udp/udplite: Remove unused function declarations udp{,lite}_get_port()
    https://git.kernel.org/netdev/net-next/c/cc97777c80fd

You are awesome, thank you!
diff mbox series

Patch

diff --git a/include/net/udp.h b/include/net/udp.h
index 5a8421cd9083..488a6d2babcc 100644
--- a/include/net/udp.h
+++ b/include/net/udp.h
@@ -273,9 +273,6 @@  static inline struct sk_buff *skb_recv_udp(struct sock *sk, unsigned int flags,
 
 int udp_v4_early_demux(struct sk_buff *skb);
 bool udp_sk_rx_dst_set(struct sock *sk, struct dst_entry *dst);
-int udp_get_port(struct sock *sk, unsigned short snum,
-		 int (*saddr_cmp)(const struct sock *,
-				  const struct sock *));
 int udp_err(struct sk_buff *, u32);
 int udp_abort(struct sock *sk, int err);
 int udp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len);
diff --git a/include/net/udplite.h b/include/net/udplite.h
index 299c14ce2bb9..bd33ff2b8f42 100644
--- a/include/net/udplite.h
+++ b/include/net/udplite.h
@@ -81,6 +81,4 @@  static inline __wsum udplite_csum(struct sk_buff *skb)
 }
 
 void udplite4_register(void);
-int udplite_get_port(struct sock *sk, unsigned short snum,
-		     int (*scmp)(const struct sock *, const struct sock *));
 #endif	/* _UDPLITE_H */