| Message ID | 2023080436-algebra-cabana-417d@gregkh (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: no need to export mm_kobj | expand |
On Fri, Aug 04, 2023 at 08:43:37AM +0200, Greg Kroah-Hartman wrote: > There are no modules using mm_kobj, so do not export it. > > Cc: Mike Rapoport <rppt@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org> > --- > mm/mm_init.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a1963c3322af..1c9d6f428906 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel); > #endif /* CONFIG_DEBUG_MEMORY_INIT */ > > struct kobject *mm_kobj; > -EXPORT_SYMBOL_GPL(mm_kobj); > > #ifdef CONFIG_SMP > s32 vm_committed_as_batch = 32; > -- > 2.41.0 >
On 2023/8/4 14:43, Greg Kroah-Hartman wrote: > There are no modules using mm_kobj, so do not export it. Yes, there's only in-kernel user left. Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Thanks. > > Cc: Mike Rapoport <rppt@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > mm/mm_init.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a1963c3322af..1c9d6f428906 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel); > #endif /* CONFIG_DEBUG_MEMORY_INIT */ > > struct kobject *mm_kobj; > -EXPORT_SYMBOL_GPL(mm_kobj); > > #ifdef CONFIG_SMP > s32 vm_committed_as_batch = 32; >
On 04.08.23 08:43, Greg Kroah-Hartman wrote: > There are no modules using mm_kobj, so do not export it. > > Cc: Mike Rapoport <rppt@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > mm/mm_init.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a1963c3322af..1c9d6f428906 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel); > #endif /* CONFIG_DEBUG_MEMORY_INIT */ > > struct kobject *mm_kobj; > -EXPORT_SYMBOL_GPL(mm_kobj); > > #ifdef CONFIG_SMP > s32 vm_committed_as_batch = 32; Reviewed-by: David Hildenbrand <david@redhat.com>
diff --git a/mm/mm_init.c b/mm/mm_init.c index a1963c3322af..1c9d6f428906 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel); #endif /* CONFIG_DEBUG_MEMORY_INIT */ struct kobject *mm_kobj; -EXPORT_SYMBOL_GPL(mm_kobj); #ifdef CONFIG_SMP s32 vm_committed_as_batch = 32;
There are no modules using mm_kobj, so do not export it. Cc: Mike Rapoport <rppt@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- mm/mm_init.c | 1 - 1 file changed, 1 deletion(-)