mbox series

[iwl-next,v3,0/3] ice: split ice_aq_wait_for_event() func into two

Message ID 20230807155848.90907-1-przemyslaw.kitszel@intel.com (mailing list archive)
Headers show
Series ice: split ice_aq_wait_for_event() func into two | expand

Message

Przemek Kitszel Aug. 7, 2023, 3:58 p.m. UTC 
Mitigate race between registering on wait list and receiving
AQ Response from FW.

The first patch fixes bound check to be more inclusive;
the second one refactors code to make the third one smaller,
which is an actual fix for the race.

Thanks Simon Horman for pushing into split, it's easier to follow now.

v3: split into 3 commits

Przemek Kitszel (3):
  ice: ice_aq_check_events: fix off-by-one check when filling buffer
  ice: embed &ice_rq_event_info event into struct ice_aq_task
  ice: split ice_aq_wait_for_event() func into two

 drivers/net/ethernet/intel/ice/ice.h          |  21 +++-
 .../net/ethernet/intel/ice/ice_fw_update.c    |  45 ++++----
 drivers/net/ethernet/intel/ice/ice_main.c     | 100 +++++++++---------
 3 files changed, 94 insertions(+), 72 deletions(-)


base-commit: 1efaa6ca8af14114dafb99924bc922daa135f870

Comments

Jacob Keller Aug. 7, 2023, 4:45 p.m. UTC | #1 
> -----Original Message-----
> From: Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>
> Sent: Monday, August 7, 2023 8:59 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; Keller, Jacob E <jacob.e.keller@intel.com>; Nguyen,
> Anthony L <anthony.l.nguyen@intel.com>; Simon Horman <horms@kernel.org>;
> Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>
> Subject: [PATCH iwl-next v3 0/3] ice: split ice_aq_wait_for_event() func into two
> 
> Mitigate race between registering on wait list and receiving
> AQ Response from FW.
> 
> The first patch fixes bound check to be more inclusive;
> the second one refactors code to make the third one smaller,
> which is an actual fix for the race.
> 
> Thanks Simon Horman for pushing into split, it's easier to follow now.
> 
> v3: split into 3 commits
> 
> Przemek Kitszel (3):
>   ice: ice_aq_check_events: fix off-by-one check when filling buffer
>   ice: embed &ice_rq_event_info event into struct ice_aq_task
>   ice: split ice_aq_wait_for_event() func into two
> 
>  drivers/net/ethernet/intel/ice/ice.h          |  21 +++-
>  .../net/ethernet/intel/ice/ice_fw_update.c    |  45 ++++----
>  drivers/net/ethernet/intel/ice/ice_main.c     | 100 +++++++++---------
>  3 files changed, 94 insertions(+), 72 deletions(-)
> 
> 
> base-commit: 1efaa6ca8af14114dafb99924bc922daa135f870
> --
> 2.40.1

This series looks good to me.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Thanks,
Jake