| Message ID | 20230801135442.255604-1-wangzhu9@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 142c61a5fddeb755c420cb2e23b4bc0c0901308f |
| Headers | show |
| Series | [-next] spi: omap2-mcspi: remove redundant dev_err_probe() | expand |
On Tue, 01 Aug 2023 21:54:42 +0800, Zhu Wang wrote: > When platform_get_irq() is called, the error message has been printed, > so it need not to call dev_err_probe() to print error, we remove the > redundant platform_get_irq(). > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: omap2-mcspi: remove redundant dev_err_probe() commit: 142c61a5fddeb755c420cb2e23b4bc0c0901308f All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c index 8331e247bf5c..e5cd82eb9e54 100644 --- a/drivers/spi/spi-omap2-mcspi.c +++ b/drivers/spi/spi-omap2-mcspi.c @@ -1508,10 +1508,8 @@ static int omap2_mcspi_probe(struct platform_device *pdev) } status = platform_get_irq(pdev, 0); - if (status < 0) { - dev_err_probe(&pdev->dev, status, "no irq resource found\n"); + if (status < 0) goto free_master; - } init_completion(&mcspi->txdone); status = devm_request_irq(&pdev->dev, status, omap2_mcspi_irq_handler, 0, pdev->name,
When platform_get_irq() is called, the error message has been printed, so it need not to call dev_err_probe() to print error, we remove the redundant platform_get_irq(). Signed-off-by: Zhu Wang <wangzhu9@huawei.com> --- drivers/spi/spi-omap2-mcspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)