| Message ID | 20230809194620.1595792-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ac04e5f38225d672a10ffd0a9162c3e466b6977b |
| Headers | show |
| Series | [BlueZ] device: Fix not probing drivers at startup | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=774671 ---Test result--- Test Summary: CheckPatch PASS 0.53 seconds GitLint PASS 0.36 seconds BuildEll PASS 27.92 seconds BluezMake PASS 884.46 seconds MakeCheck PASS 12.63 seconds MakeDistcheck PASS 161.48 seconds CheckValgrind PASS 260.45 seconds CheckSmatch PASS 351.02 seconds bluezmakeextell PASS 107.80 seconds IncrementalBuild PASS 738.38 seconds ScanBuild PASS 1131.15 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 9 Aug 2023 12:46:20 -0700 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > Patch 67a26abe53bf ("profile: Add probe_on_discover flag") introduced a > regression which prevents drivers to be properly loaded at startup since > at that point they are not connected when code shall testing if > the devide is temporary instead. > > [...] Here is the summary with links: - [BlueZ] device: Fix not probing drivers at startup https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ac04e5f38225 You are awesome, thank you!
diff --git a/src/device.c b/src/device.c index 19ae03f7d98a..ecd385cf813a 100644 --- a/src/device.c +++ b/src/device.c @@ -3933,10 +3933,10 @@ static bool device_match_profile(struct btd_device *device, if (profile->remote_uuid == NULL) return false; - /* Don't match if device was just discovered (not connected) and the + /* Don't match if device was just discovered, is temporary, and the * profile don't have probe_on_discover flag set. */ - if (!btd_device_is_connected(device) && !profile->probe_on_discover) + if (device->temporary && !profile->probe_on_discover) return false; if (g_slist_find_custom(uuids, profile->remote_uuid,
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Patch 67a26abe53bf ("profile: Add probe_on_discover flag") introduced a regression which prevents drivers to be properly loaded at startup since at that point they are not connected when code shall testing if the devide is temporary instead. --- src/device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)