| Message ID | 20230809033151.768910-1-linma@zju.edu.cn (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] nl80211/cfg80211: add forgetten nla_policy for BSS color attribute | expand |
On Wed, Aug 09, 2023 at 11:31:51AM +0800, Lin Ma wrote: > The previous commit dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to > NDP ranging parameters") adds a parameter for NDP ranging by introducing > a new attribute type named NL80211_PMSR_FTM_REQ_ATTR_BSS_COLOR. > > However, the author forgot to also describe the nla_policy at > nl80211_pmsr_ftm_req_attr_policy (net/wireless/nl80211.c). Just > complement it to avoid malformed attribute that causes out-of-attribute > access. > > Fixes: dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to NDP ranging parameters") > Signed-off-by: Lin Ma <linma@zju.edu.cn> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 0da2e6a2a7ea..f729dba1cb5b 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -323,6 +323,7 @@ nl80211_pmsr_ftm_req_attr_policy[NL80211_PMSR_FTM_REQ_ATTR_MAX + 1] = { [NL80211_PMSR_FTM_REQ_ATTR_TRIGGER_BASED] = { .type = NLA_FLAG }, [NL80211_PMSR_FTM_REQ_ATTR_NON_TRIGGER_BASED] = { .type = NLA_FLAG }, [NL80211_PMSR_FTM_REQ_ATTR_LMR_FEEDBACK] = { .type = NLA_FLAG }, + [NL80211_PMSR_FTM_REQ_ATTR_BSS_COLOR] = { .type = NLA_U8 }, }; static const struct nla_policy
The previous commit dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to NDP ranging parameters") adds a parameter for NDP ranging by introducing a new attribute type named NL80211_PMSR_FTM_REQ_ATTR_BSS_COLOR. However, the author forgot to also describe the nla_policy at nl80211_pmsr_ftm_req_attr_policy (net/wireless/nl80211.c). Just complement it to avoid malformed attribute that causes out-of-attribute access. Fixes: dd3e4fc75b4a ("nl80211/cfg80211: add BSS color to NDP ranging parameters") Signed-off-by: Lin Ma <linma@zju.edu.cn> --- v1 -> v2: resent due to the last version failed to reach public mail list. net/wireless/nl80211.c | 1 + 1 file changed, 1 insertion(+)