| Message ID | 20230810080909.6259-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: enable EMAC1 on sa8775p | expand |
On Thu, Aug 10, 2023 at 10:09:00AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > This series contains changes required to enable EMAC1 on sa8775p-ride. > This iteration no longer depends on any changes to the stmmac driver to > be functional. It turns out I was mistaken in thinking that the two > MACs' MDIO masters share the MDIO clock and data lines. In reality, only > one MAC is connected to an MDIO bus and it controlls PHYs for both MAC0 > and MAC1. The MDIO master on MAC1 is not connected to anything. > I've taken this for a quick (disconnected from network) spin, and things work as expected without having anything plugged in. I'm trying to get someone to plug it in so I can test that networking actually works, but the interesting bit is the phy/mdio bit here, and that's at least working ok I can tell. The rest is boilerplate similar to the other MAC instance which works fine. Removing the driver results in the following oops, but that's already discussed[0] and is independent of the devicetree description: I'd add a test tag but I want to wait for some network traffic tests before I do such. I wouldn't wait on picking it up just because of that though. [0] https://lore.kernel.org/netdev/ZNKLjuxnR2+V3g1D@shell.armlinux.org.uk/ [root@dhcp19-243-28 ~]# modprobe -r dwmac_qcom_ethqos [ 1260.620402] qcom-ethqos 23040000.ethernet eth1: stmmac_dvr_remove: removing driver [ 1260.655724] qcom-ethqos 23040000.ethernet eth1: FPE workqueue stop [ 1261.034265] qcom-ethqos 23000000.ethernet eth0: stmmac_dvr_remove: removing driver [ 1261.042108] Unable to handle kernel paging request at virtual address dead000000000122 [ 1261.050379] Mem abort info: [ 1261.053251] ESR = 0x0000000096000044 [ 1261.057113] EC = 0x25: DABT (current EL), IL = 32 bits [ 1261.062573] SET = 0, FnV = 0 [ 1261.065712] EA = 0, S1PTW = 0 [ 1261.068946] FSC = 0x04: level 0 translation fault [ 1261.073956] Data abort info: [ 1261.076916] ISV = 0, ISS = 0x00000044, ISS2 = 0x00000000 [ 1261.082552] CM = 0, WnR = 1, TnD = 0, TagAccess = 0 [ 1261.087882] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 1261.093338] [dead000000000122] address between user and kernel address ranges [ 1261.100667] Internal error: Oops: 0000000096000044 [#1] PREEMPT SMP [ 1261.107096] Modules linked in: r8152 rfkill marvell dwmac_qcom_ethqos(-) qcom_pon stmmac_platform crct10dif_ce stmmac spi_geni_qcom i2c_qcom_geni phy_qcom_qmp_usb phy_qcom_sgmii_eth phy_qcom_snps_femto_v2 pcs_xpcs qcom_wdt socinfo phy_qcom_qmp_pcie fuse ufs_qcom phy_qcom_qmp_ufs [ 1261.132407] CPU: 2 PID: 610 Comm: modprobe Not tainted 6.5.0-rc4-next-20230731-00008-g18ccccee8230 #7 [ 1261.141860] Hardware name: Qualcomm SA8775P Ride (DT) [ 1261.147042] pstate: 00400005 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 1261.154185] pc : device_link_put_kref+0x44/0x110 [ 1261.158926] lr : device_link_put_kref+0xf4/0x110 [ 1261.163662] sp : ffff800082a938e0 [ 1261.167066] x29: ffff800082a938e0 x28: ffff6ec68bdc9d80 x27: 0000000000000000 [ 1261.174390] x26: 0000000000000000 x25: 0000000000000000 x24: 0000000000000000 [ 1261.181714] x23: ffff800082a93b38 x22: ffff6ec68690f2d8 x21: ffff6ec6896aed30 [ 1261.189031] x20: ffff6ec68246b830 x19: ffff6ec68246b800 x18: 0000000000000006 [ 1261.196355] x17: ffff9259b7856000 x16: ffffdc7b42e3eaec x15: 725f7276645f6361 [ 1261.203679] x14: 0000000000000000 x13: 0000000000000002 x12: 0000000000000000 [ 1261.210996] x11: 0000000000000040 x10: ffffdc7b447de0b0 x9 : ffffdc7b447de0a8 [ 1261.218321] x8 : ffff6ec680400028 x7 : 0000000000000000 x6 : 0000000000000000 [ 1261.225645] x5 : ffff6ec680400000 x4 : 00000000c0000000 x3 : ffff6ec6896ae8b0 [ 1261.232963] x2 : dead000000000122 x1 : dead000000000122 x0 : ffff6ec68246b830 [ 1261.240287] Call trace: [ 1261.242806] device_link_put_kref+0x44/0x110 [ 1261.247190] device_link_del+0x30/0x48 [ 1261.251040] phy_detach+0x24/0x15c [ 1261.254530] phy_disconnect+0x44/0x5c [ 1261.258295] phylink_disconnect_phy+0x64/0xb0 [ 1261.262764] stmmac_release+0x58/0x2d4 [stmmac] [ 1261.267425] __dev_close_many+0xac/0x14c [ 1261.271458] dev_close_many+0x88/0x134 [ 1261.275308] unregister_netdevice_many_notify+0x130/0x7d0 [ 1261.280852] unregister_netdevice_queue+0xd4/0xdc [ 1261.285682] unregister_netdev+0x24/0x38 [ 1261.289715] stmmac_dvr_remove+0x80/0x150 [stmmac] [ 1261.294636] devm_stmmac_pltfr_remove+0x24/0x48 [stmmac_platform] [ 1261.300887] devm_action_release+0x14/0x20 [ 1261.305090] devres_release_all+0xa0/0x100 [ 1261.309293] device_unbind_cleanup+0x18/0x68 [ 1261.313676] device_release_driver_internal+0x1f4/0x228 [ 1261.319039] driver_detach+0x4c/0x98 [ 1261.322708] bus_remove_driver+0x6c/0xbc [ 1261.326739] driver_unregister+0x30/0x60 [ 1261.330772] platform_driver_unregister+0x14/0x20 [ 1261.335603] qcom_ethqos_driver_exit+0x18/0x1a8 [dwmac_qcom_ethqos] [ 1261.342035] __arm64_sys_delete_module+0x19c/0x288 [ 1261.346952] invoke_syscall+0x48/0x110 [ 1261.350804] el0_svc_common.constprop.0+0xc4/0xe4 [ 1261.355636] do_el0_svc+0x38/0x94 [ 1261.359040] el0_svc+0x2c/0x84 [ 1261.362178] el0t_64_sync_handler+0x120/0x12c [ 1261.366646] el0t_64_sync+0x190/0x194 [ 1261.370413] Code: d2802441 aa1403e0 f2fbd5a1 f9000462 (f9000043) [ 1261.376661] ---[ end trace 0000000000000000 ]--- Segmentation fault
On Thu, Aug 10, 2023 at 10:13 PM Andrew Halaney <ahalaney@redhat.com> wrote: > > On Thu, Aug 10, 2023 at 10:09:00AM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > This series contains changes required to enable EMAC1 on sa8775p-ride. > > This iteration no longer depends on any changes to the stmmac driver to > > be functional. It turns out I was mistaken in thinking that the two > > MACs' MDIO masters share the MDIO clock and data lines. In reality, only > > one MAC is connected to an MDIO bus and it controlls PHYs for both MAC0 > > and MAC1. The MDIO master on MAC1 is not connected to anything. > > > > I've taken this for a quick (disconnected from network) spin, and things > work as expected without having anything plugged in. > > I'm trying to get someone to plug it in so I can test that networking > actually works, but the interesting bit is the phy/mdio bit here, and > that's at least working ok I can tell. The rest is boilerplate similar > to the other MAC instance which works fine. > > Removing the driver results in the following oops, but that's already > discussed[0] and is independent of the devicetree description: > > I'd add a test tag but I want to wait for some network traffic tests > before I do such. I wouldn't wait on picking it up just because of > that though. > > [0] https://lore.kernel.org/netdev/ZNKLjuxnR2+V3g1D@shell.armlinux.org.uk/ > > [root@dhcp19-243-28 ~]# modprobe -r dwmac_qcom_ethqos > [ 1260.620402] qcom-ethqos 23040000.ethernet eth1: stmmac_dvr_remove: removing driver > [ 1260.655724] qcom-ethqos 23040000.ethernet eth1: FPE workqueue stop > [ 1261.034265] qcom-ethqos 23000000.ethernet eth0: stmmac_dvr_remove: removing driver > [ 1261.042108] Unable to handle kernel paging request at virtual address dead000000000122 > [ 1261.050379] Mem abort info: > [ 1261.053251] ESR = 0x0000000096000044 > [ 1261.057113] EC = 0x25: DABT (current EL), IL = 32 bits > [ 1261.062573] SET = 0, FnV = 0 > [ 1261.065712] EA = 0, S1PTW = 0 > [ 1261.068946] FSC = 0x04: level 0 translation fault > [ 1261.073956] Data abort info: > [ 1261.076916] ISV = 0, ISS = 0x00000044, ISS2 = 0x00000000 > [ 1261.082552] CM = 0, WnR = 1, TnD = 0, TagAccess = 0 > [ 1261.087882] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 > [ 1261.093338] [dead000000000122] address between user and kernel address ranges > [ 1261.100667] Internal error: Oops: 0000000096000044 [#1] PREEMPT SMP > [ 1261.107096] Modules linked in: r8152 rfkill marvell dwmac_qcom_ethqos(-) qcom_pon stmmac_platform crct10dif_ce stmmac spi_geni_qcom i2c_qcom_geni phy_qcom_qmp_usb phy_qcom_sgmii_eth phy_qcom_snps_femto_v2 pcs_xpcs qcom_wdt socinfo phy_qcom_qmp_pcie fuse ufs_qcom phy_qcom_qmp_ufs > [ 1261.132407] CPU: 2 PID: 610 Comm: modprobe Not tainted 6.5.0-rc4-next-20230731-00008-g18ccccee8230 #7 > [ 1261.141860] Hardware name: Qualcomm SA8775P Ride (DT) > [ 1261.147042] pstate: 00400005 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 1261.154185] pc : device_link_put_kref+0x44/0x110 > [ 1261.158926] lr : device_link_put_kref+0xf4/0x110 > [ 1261.163662] sp : ffff800082a938e0 > [ 1261.167066] x29: ffff800082a938e0 x28: ffff6ec68bdc9d80 x27: 0000000000000000 > [ 1261.174390] x26: 0000000000000000 x25: 0000000000000000 x24: 0000000000000000 > [ 1261.181714] x23: ffff800082a93b38 x22: ffff6ec68690f2d8 x21: ffff6ec6896aed30 > [ 1261.189031] x20: ffff6ec68246b830 x19: ffff6ec68246b800 x18: 0000000000000006 > [ 1261.196355] x17: ffff9259b7856000 x16: ffffdc7b42e3eaec x15: 725f7276645f6361 > [ 1261.203679] x14: 0000000000000000 x13: 0000000000000002 x12: 0000000000000000 > [ 1261.210996] x11: 0000000000000040 x10: ffffdc7b447de0b0 x9 : ffffdc7b447de0a8 > [ 1261.218321] x8 : ffff6ec680400028 x7 : 0000000000000000 x6 : 0000000000000000 > [ 1261.225645] x5 : ffff6ec680400000 x4 : 00000000c0000000 x3 : ffff6ec6896ae8b0 > [ 1261.232963] x2 : dead000000000122 x1 : dead000000000122 x0 : ffff6ec68246b830 > [ 1261.240287] Call trace: > [ 1261.242806] device_link_put_kref+0x44/0x110 > [ 1261.247190] device_link_del+0x30/0x48 > [ 1261.251040] phy_detach+0x24/0x15c > [ 1261.254530] phy_disconnect+0x44/0x5c > [ 1261.258295] phylink_disconnect_phy+0x64/0xb0 > [ 1261.262764] stmmac_release+0x58/0x2d4 [stmmac] > [ 1261.267425] __dev_close_many+0xac/0x14c > [ 1261.271458] dev_close_many+0x88/0x134 > [ 1261.275308] unregister_netdevice_many_notify+0x130/0x7d0 > [ 1261.280852] unregister_netdevice_queue+0xd4/0xdc > [ 1261.285682] unregister_netdev+0x24/0x38 > [ 1261.289715] stmmac_dvr_remove+0x80/0x150 [stmmac] > [ 1261.294636] devm_stmmac_pltfr_remove+0x24/0x48 [stmmac_platform] > [ 1261.300887] devm_action_release+0x14/0x20 > [ 1261.305090] devres_release_all+0xa0/0x100 > [ 1261.309293] device_unbind_cleanup+0x18/0x68 > [ 1261.313676] device_release_driver_internal+0x1f4/0x228 > [ 1261.319039] driver_detach+0x4c/0x98 > [ 1261.322708] bus_remove_driver+0x6c/0xbc > [ 1261.326739] driver_unregister+0x30/0x60 > [ 1261.330772] platform_driver_unregister+0x14/0x20 > [ 1261.335603] qcom_ethqos_driver_exit+0x18/0x1a8 [dwmac_qcom_ethqos] > [ 1261.342035] __arm64_sys_delete_module+0x19c/0x288 > [ 1261.346952] invoke_syscall+0x48/0x110 > [ 1261.350804] el0_svc_common.constprop.0+0xc4/0xe4 > [ 1261.355636] do_el0_svc+0x38/0x94 > [ 1261.359040] el0_svc+0x2c/0x84 > [ 1261.362178] el0t_64_sync_handler+0x120/0x12c > [ 1261.366646] el0t_64_sync+0x190/0x194 > [ 1261.370413] Code: d2802441 aa1403e0 f2fbd5a1 f9000462 (f9000043) > [ 1261.376661] ---[ end trace 0000000000000000 ]--- > Segmentation fault > Yep. This is a very deep problem and will be the same for any MAC reaching into another MAC's node to get its PHY's phandle. :( Bart
On Fri, Aug 11, 2023 at 02:00:21PM +0200, Bartosz Golaszewski wrote: > On Thu, Aug 10, 2023 at 10:13 PM Andrew Halaney <ahalaney@redhat.com> wrote: > > > > On Thu, Aug 10, 2023 at 10:09:00AM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > > > This series contains changes required to enable EMAC1 on sa8775p-ride. > > > This iteration no longer depends on any changes to the stmmac driver to > > > be functional. It turns out I was mistaken in thinking that the two > > > MACs' MDIO masters share the MDIO clock and data lines. In reality, only > > > one MAC is connected to an MDIO bus and it controlls PHYs for both MAC0 > > > and MAC1. The MDIO master on MAC1 is not connected to anything. > > > > > > > I've taken this for a quick (disconnected from network) spin, and things > > work as expected without having anything plugged in. > > > > I'm trying to get someone to plug it in so I can test that networking > > actually works, but the interesting bit is the phy/mdio bit here, and > > that's at least working ok I can tell. The rest is boilerplate similar > > to the other MAC instance which works fine. > > > > Removing the driver results in the following oops, but that's already > > discussed[0] and is independent of the devicetree description: > > > > I'd add a test tag but I want to wait for some network traffic tests > > before I do such. I wouldn't wait on picking it up just because of > > that though. I got it plugged in :) Things work as expected, throughput seems to be ~950 Mbps and latency is good. Thanks! Tested-by: Andrew Halaney <ahalaney@redhat.com> > > > > [0] https://lore.kernel.org/netdev/ZNKLjuxnR2+V3g1D@shell.armlinux.org.uk/ > > > > [root@dhcp19-243-28 ~]# modprobe -r dwmac_qcom_ethqos > > [ 1260.620402] qcom-ethqos 23040000.ethernet eth1: stmmac_dvr_remove: removing driver > > [ 1260.655724] qcom-ethqos 23040000.ethernet eth1: FPE workqueue stop > > [ 1261.034265] qcom-ethqos 23000000.ethernet eth0: stmmac_dvr_remove: removing driver > > [ 1261.042108] Unable to handle kernel paging request at virtual address dead000000000122 > > [ 1261.050379] Mem abort info: > > [ 1261.053251] ESR = 0x0000000096000044 > > [ 1261.057113] EC = 0x25: DABT (current EL), IL = 32 bits > > [ 1261.062573] SET = 0, FnV = 0 > > [ 1261.065712] EA = 0, S1PTW = 0 > > [ 1261.068946] FSC = 0x04: level 0 translation fault > > [ 1261.073956] Data abort info: > > [ 1261.076916] ISV = 0, ISS = 0x00000044, ISS2 = 0x00000000 > > [ 1261.082552] CM = 0, WnR = 1, TnD = 0, TagAccess = 0 > > [ 1261.087882] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 > > [ 1261.093338] [dead000000000122] address between user and kernel address ranges > > [ 1261.100667] Internal error: Oops: 0000000096000044 [#1] PREEMPT SMP > > [ 1261.107096] Modules linked in: r8152 rfkill marvell dwmac_qcom_ethqos(-) qcom_pon stmmac_platform crct10dif_ce stmmac spi_geni_qcom i2c_qcom_geni phy_qcom_qmp_usb phy_qcom_sgmii_eth phy_qcom_snps_femto_v2 pcs_xpcs qcom_wdt socinfo phy_qcom_qmp_pcie fuse ufs_qcom phy_qcom_qmp_ufs > > [ 1261.132407] CPU: 2 PID: 610 Comm: modprobe Not tainted 6.5.0-rc4-next-20230731-00008-g18ccccee8230 #7 > > [ 1261.141860] Hardware name: Qualcomm SA8775P Ride (DT) > > [ 1261.147042] pstate: 00400005 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > > [ 1261.154185] pc : device_link_put_kref+0x44/0x110 > > [ 1261.158926] lr : device_link_put_kref+0xf4/0x110 > > [ 1261.163662] sp : ffff800082a938e0 > > [ 1261.167066] x29: ffff800082a938e0 x28: ffff6ec68bdc9d80 x27: 0000000000000000 > > [ 1261.174390] x26: 0000000000000000 x25: 0000000000000000 x24: 0000000000000000 > > [ 1261.181714] x23: ffff800082a93b38 x22: ffff6ec68690f2d8 x21: ffff6ec6896aed30 > > [ 1261.189031] x20: ffff6ec68246b830 x19: ffff6ec68246b800 x18: 0000000000000006 > > [ 1261.196355] x17: ffff9259b7856000 x16: ffffdc7b42e3eaec x15: 725f7276645f6361 > > [ 1261.203679] x14: 0000000000000000 x13: 0000000000000002 x12: 0000000000000000 > > [ 1261.210996] x11: 0000000000000040 x10: ffffdc7b447de0b0 x9 : ffffdc7b447de0a8 > > [ 1261.218321] x8 : ffff6ec680400028 x7 : 0000000000000000 x6 : 0000000000000000 > > [ 1261.225645] x5 : ffff6ec680400000 x4 : 00000000c0000000 x3 : ffff6ec6896ae8b0 > > [ 1261.232963] x2 : dead000000000122 x1 : dead000000000122 x0 : ffff6ec68246b830 > > [ 1261.240287] Call trace: > > [ 1261.242806] device_link_put_kref+0x44/0x110 > > [ 1261.247190] device_link_del+0x30/0x48 > > [ 1261.251040] phy_detach+0x24/0x15c > > [ 1261.254530] phy_disconnect+0x44/0x5c > > [ 1261.258295] phylink_disconnect_phy+0x64/0xb0 > > [ 1261.262764] stmmac_release+0x58/0x2d4 [stmmac] > > [ 1261.267425] __dev_close_many+0xac/0x14c > > [ 1261.271458] dev_close_many+0x88/0x134 > > [ 1261.275308] unregister_netdevice_many_notify+0x130/0x7d0 > > [ 1261.280852] unregister_netdevice_queue+0xd4/0xdc > > [ 1261.285682] unregister_netdev+0x24/0x38 > > [ 1261.289715] stmmac_dvr_remove+0x80/0x150 [stmmac] > > [ 1261.294636] devm_stmmac_pltfr_remove+0x24/0x48 [stmmac_platform] > > [ 1261.300887] devm_action_release+0x14/0x20 > > [ 1261.305090] devres_release_all+0xa0/0x100 > > [ 1261.309293] device_unbind_cleanup+0x18/0x68 > > [ 1261.313676] device_release_driver_internal+0x1f4/0x228 > > [ 1261.319039] driver_detach+0x4c/0x98 > > [ 1261.322708] bus_remove_driver+0x6c/0xbc > > [ 1261.326739] driver_unregister+0x30/0x60 > > [ 1261.330772] platform_driver_unregister+0x14/0x20 > > [ 1261.335603] qcom_ethqos_driver_exit+0x18/0x1a8 [dwmac_qcom_ethqos] > > [ 1261.342035] __arm64_sys_delete_module+0x19c/0x288 > > [ 1261.346952] invoke_syscall+0x48/0x110 > > [ 1261.350804] el0_svc_common.constprop.0+0xc4/0xe4 > > [ 1261.355636] do_el0_svc+0x38/0x94 > > [ 1261.359040] el0_svc+0x2c/0x84 > > [ 1261.362178] el0t_64_sync_handler+0x120/0x12c > > [ 1261.366646] el0t_64_sync+0x190/0x194 > > [ 1261.370413] Code: d2802441 aa1403e0 f2fbd5a1 f9000462 (f9000043) > > [ 1261.376661] ---[ end trace 0000000000000000 ]--- > > Segmentation fault > > > > Yep. This is a very deep problem and will be the same for any MAC > reaching into another MAC's node to get its PHY's phandle. :( > > Bart >
On Thu, 10 Aug 2023 10:09:00 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > This series contains changes required to enable EMAC1 on sa8775p-ride. > This iteration no longer depends on any changes to the stmmac driver to > be functional. It turns out I was mistaken in thinking that the two > MACs' MDIO masters share the MDIO clock and data lines. In reality, only > one MAC is connected to an MDIO bus and it controlls PHYs for both MAC0 > and MAC1. The MDIO master on MAC1 is not connected to anything. > > [...] Applied, thanks! [1/9] arm64: dts: qcom: sa8775p: add a node for the second serdes PHY commit: 31cd8caf0cbe191c0157c1581a8f0b82b891960d [2/9] arm64: dts: qcom: sa8775p: add a node for EMAC1 commit: e952348a7cc7b35883bdd43d73b8c9b296936547 [3/9] arm64: dts: qcom: sa8775p-ride: enable the second SerDes PHY commit: 6ca89cc6803b3895a0b2caba458dbece9b6ea52b [4/9] arm64: dts: qcom: sa8775p-ride: move the reset-gpios property of the PHY commit: 5255901fb26efcb91eee1739aded174ff6c6443e [5/9] arm64: dts: qcom: sa8775p-ride: index the first SGMII PHY commit: 1e7ef41b5fa7de8de746a5d6cb7c96c409888c53 [6/9] arm64: dts: qcom: sa8775p-ride: add the second SGMII PHY commit: 1a00a068de4a657a2af53943d446b7b7199b5871 [7/9] arm64: dts: qcom: sa8775p-ride: sort aliases alphabetically commit: f8be0c50ce0e5bc38938fb1a7405288cf3fc96ac [8/9] arm64: dts: qcom: sa8775p-ride: add an alias for ethernet0 commit: fdc051e3926ee52b43f16dc3d6f35f40f8a5d3c3 [9/9] arm64: dts: qcom: sa8775p-ride: enable EMAC1 commit: 27eb552ef585c9852d1d04afde9fde34f8b69dc2 Best regards,
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> This series contains changes required to enable EMAC1 on sa8775p-ride. This iteration no longer depends on any changes to the stmmac driver to be functional. It turns out I was mistaken in thinking that the two MACs' MDIO masters share the MDIO clock and data lines. In reality, only one MAC is connected to an MDIO bus and it controlls PHYs for both MAC0 and MAC1. The MDIO master on MAC1 is not connected to anything. v1 -> v2: - remove pin functions for MDIO signals and don't assign them to MAC1 - add a delay after asserting the PHY's reset signal, not only when it's released - remove the entire concept of shared-mdio property - add aliases for ethernet nodes in order to avoid MDIO bus name conflicts in stmmac v2 -> v3: - add a patch sorting aliases in sa8775p-ride.dts and sort the ethernet entries - remove a newline between clocks and clock-names properties - collect tags Bartosz Golaszewski (9): arm64: dts: qcom: sa8775p: add a node for the second serdes PHY arm64: dts: qcom: sa8775p: add a node for EMAC1 arm64: dts: qcom: sa8775p-ride: enable the second SerDes PHY arm64: dts: qcom: sa8775p-ride: move the reset-gpios property of the PHY arm64: dts: qcom: sa8775p-ride: index the first SGMII PHY arm64: dts: qcom: sa8775p-ride: add the second SGMII PHY arm64: dts: qcom: sa8775p-ride: sort aliases alphabetically arm64: dts: qcom: sa8775p-ride: add an alias for ethernet0 arm64: dts: qcom: sa8775p-ride: enable EMAC1 arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 102 ++++++++++++++++++++-- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 42 +++++++++ 2 files changed, 136 insertions(+), 8 deletions(-)