| Message ID | 52da391229a45fe3dbd5c43167cdb0701a17a361.1690938732.git.gustavoars@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | fbfa49f92484a63574b692069f09cfe9b79ec565 |
| Headers | show |
| Series | i40e: Replace one-element arrays with flexible-array members | expand |
On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote: > One-element and zero-length arrays are deprecated. So, replace > one-element array in struct i40e_profile_segment with flexible-array > member. > > This results in no differences in binary output. > > Link: https://github.com/KSPP/linux/issues/335 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Simon Horman <horms@kernel.org>
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Gustavo A. R. Silva > Sent: Wednesday, August 2, 2023 10:36 AM > To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com> > Cc: linux-hardening@vger.kernel.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org> > Subject: [Intel-wired-lan] [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment > > One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_profile_segment with flexible-array member. > > This results in no differences in binary output. > > Link: https://github.com/KSPP/linux/issues/335 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote: > One-element and zero-length arrays are deprecated. So, replace > one-element array in struct i40e_profile_segment with flexible-array > member. > > This results in no differences in binary output. > > Link: https://github.com/KSPP/linux/issues/335 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Justin Stitt <justinstitt@google.com> > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h > index c3d5fe12059a..f7a984304b65 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_type.h > +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h > @@ -1487,7 +1487,7 @@ struct i40e_profile_segment { > struct i40e_ddp_version version; > char name[I40E_DDP_NAME_SIZE]; > u32 device_table_count; > - struct i40e_device_id_entry device_table[1]; > + struct i40e_device_id_entry device_table[]; > }; > > struct i40e_section_table { > -- > 2.34.1 >
On Thu, Aug 10, 2023 at 05:34:04PM +0000, Justin Stitt wrote: > On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote: > > One-element and zero-length arrays are deprecated. So, replace > > one-element array in struct i40e_profile_segment with flexible-array > > member. > > > > This results in no differences in binary output. > > > > Link: https://github.com/KSPP/linux/issues/335 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > --- > > drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Justin Stitt <justinstitt@google.com> Whoops, this should be: Reviewed-by: Justin Stitt <justinstitt@google.com> I did not test, I just verified there are no binary differences produced by this patch. > > > > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h > > index c3d5fe12059a..f7a984304b65 100644 > > --- a/drivers/net/ethernet/intel/i40e/i40e_type.h > > +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h > > @@ -1487,7 +1487,7 @@ struct i40e_profile_segment { > > struct i40e_ddp_version version; > > char name[I40E_DDP_NAME_SIZE]; > > u32 device_table_count; > > - struct i40e_device_id_entry device_table[1]; > > + struct i40e_device_id_entry device_table[]; > > }; > > > > struct i40e_section_table { > > -- > > 2.34.1 > >
On 8/10/23 14:49, Justin Stitt wrote: > On Thu, Aug 10, 2023 at 05:34:04PM +0000, Justin Stitt wrote: >> On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote: >>> One-element and zero-length arrays are deprecated. So, replace >>> one-element array in struct i40e_profile_segment with flexible-array >>> member. >>> >>> This results in no differences in binary output. >>> >>> Link: https://github.com/KSPP/linux/issues/335 >>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >>> --- >>> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> Tested-by: Justin Stitt <justinstitt@google.com> > Whoops, this should be: > Reviewed-by: Justin Stitt <justinstitt@google.com> > > I did not test, I just verified there are no binary differences produced > by this patch. In that case, `Build-tested-by` seems more appropriate. Anyways, the series has been applied already. -- Gustavo
diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h index c3d5fe12059a..f7a984304b65 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_type.h +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h @@ -1487,7 +1487,7 @@ struct i40e_profile_segment { struct i40e_ddp_version version; char name[I40E_DDP_NAME_SIZE]; u32 device_table_count; - struct i40e_device_id_entry device_table[1]; + struct i40e_device_id_entry device_table[]; }; struct i40e_section_table {
One-element and zero-length arrays are deprecated. So, replace one-element array in struct i40e_profile_segment with flexible-array member. This results in no differences in binary output. Link: https://github.com/KSPP/linux/issues/335 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)