mbox series

[blktests,0/4] clarify confusions in blktests contributions

Message ID 20230728110720.1280124-1-shinichiro.kawasaki@wdc.com (mailing list archive)
Headers show
Series clarify confusions in blktests contributions | expand

Message

Shinichiro Kawasaki July 28, 2023, 11:07 a.m. UTC 
I hear some confusions from blktests contributors. This series try to address
them based on my thoughts. Comments will be welcomed.

Shin'ichiro Kawasaki (4):
  new: don't mandate double square brackets
  README: describe what './new' script documents
  CONTRIBUTING, README: recommend patch post for contributions
  README: clarify motivations to add new test cases

 CONTRIBUTING.md | 14 ++++++++------
 README.md       | 15 +++++++++++++--
 new             |  4 ++--
 3 files changed, 23 insertions(+), 10 deletions(-)

Comments

Johannes Thumshirn July 28, 2023, 11:11 a.m. UTC | #1 
On 28.07.23 13:07, Shin'ichiro Kawasaki wrote:
> I hear some confusions from blktests contributors. This series try to address
> them based on my thoughts. Comments will be welcomed.
>
> Shin'ichiro Kawasaki (4):
>    new: don't mandate double square brackets
>    README: describe what './new' script documents
>    CONTRIBUTING, README: recommend patch post for contributions
>    README: clarify motivations to add new test cases
>
>   CONTRIBUTING.md | 14 ++++++++------
>   README.md       | 15 +++++++++++++--
>   new             |  4 ++--
>   3 files changed, 23 insertions(+), 10 deletions(-)
>
Apart from the grammar fix in patch 2.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Chaitanya Kulkarni July 28, 2023, 5:34 p.m. UTC | #2 
On 7/28/2023 4:07 AM, Shin'ichiro Kawasaki wrote:
> I hear some confusions from blktests contributors. This series try to address
> them based on my thoughts. Comments will be welcomed.
> 
> Shin'ichiro Kawasaki (4):
>    new: don't mandate double square brackets
>    README: describe what './new' script documents
>    CONTRIBUTING, README: recommend patch post for contributions
>    README: clarify motivations to add new test cases
> 
>   CONTRIBUTING.md | 14 ++++++++------
>   README.md       | 15 +++++++++++++--
>   new             |  4 ++--
>   3 files changed, 23 insertions(+), 10 deletions(-)
> 

Apart from nits mentioned, this whole series looks good to me.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
Shinichiro Kawasaki Aug. 11, 2023, 1:59 a.m. UTC | #3 
On Jul 28, 2023 / 20:07, Shin'ichiro Kawasaki wrote:
> I hear some confusions from blktests contributors. This series try to address
> them based on my thoughts. Comments will be welcomed.
> 
> Shin'ichiro Kawasaki (4):
>   new: don't mandate double square brackets
>   README: describe what './new' script documents
>   CONTRIBUTING, README: recommend patch post for contributions
>   README: clarify motivations to add new test cases

Thanks for the review comments. I've applied with the fix suggested.