[v2,1/2] Bluetooth: btnxpuart: Remove check for CTS low after FW download

Commit Message

Neeraj Sanjay Kale Aug. 11, 2023, 10:12 a.m. UTC

This removes the unnecessary check for CTS low after FW download.

After FW download is complete, the CTS line is already seen low.
It becomes high after 2 msec, and low again after FW initialization
is complete.
This makes the current check for CTS low redundant.

This removes the wait for CTS low section and increase delay to
1200msec instead, which is sufficiant for all NXP chipsets to
initialize FW.

Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
---
v2: Remove wait_for_cts low check in a separate commit (Francesco
Dolcini)
---
 drivers/bluetooth/btnxpuart.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

[e-mail] Aug. 11, 2023, 11:04 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=775278

---Test result---

Test Summary:
CheckPatch                    PASS      1.44 seconds
GitLint                       PASS      0.63 seconds
SubjectPrefix                 PASS      0.21 seconds
BuildKernel                   PASS      39.13 seconds
CheckAllWarning               PASS      42.76 seconds
CheckSparse                   PASS      49.81 seconds
CheckSmatch                   PASS      131.24 seconds
BuildKernel32                 PASS      38.38 seconds
TestRunnerSetup               PASS      585.10 seconds
TestRunner_l2cap-tester       PASS      27.72 seconds
TestRunner_iso-tester         PASS      65.77 seconds
TestRunner_bnep-tester        PASS      12.55 seconds
TestRunner_mgmt-tester        PASS      244.85 seconds
TestRunner_rfcomm-tester      PASS      19.17 seconds
TestRunner_sco-tester         PASS      21.78 seconds
TestRunner_ioctl-tester       PASS      21.71 seconds
TestRunner_mesh-tester        PASS      16.01 seconds
TestRunner_smp-tester         PASS      17.11 seconds
TestRunner_userchan-tester    PASS      13.46 seconds
IncrementalBuild              PASS      40.76 seconds



---
Regards,
Linux Bluetooth

Patch

diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index ee6f6c872a34..1dd60c7e6fe0 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -558,16 +558,11 @@  static int nxp_download_firmware(struct hci_dev *hdev)
 	}
 
 	serdev_device_set_flow_control(nxpdev->serdev, true);
-	err = serdev_device_wait_for_cts(nxpdev->serdev, 1, 60000);
-	if (err < 0) {
-		bt_dev_err(hdev, "CTS is still high. FW Download failed.");
-		return err;
-	}
 	release_firmware(nxpdev->fw);
 	memset(nxpdev->fw_name, 0, sizeof(nxpdev->fw_name));
 
 	/* Allow the downloaded FW to initialize */
-	usleep_range(800 * USEC_PER_MSEC, 1 * USEC_PER_SEC);
+	msleep(1200);
 
 	return 0;
 }