mbox series

[0/3] stm32/hash - Convert to platform remove callback returning void

Message ID 20230731165456.799784-1-u.kleine-koenig@pengutronix.de (mailing list archive)
Headers show
Series stm32/hash - Convert to platform remove callback returning void | expand

Message

Uwe Kleine-König July 31, 2023, 4:54 p.m. UTC
Hello,

this patch series converts the stm32-hash driver to use .remove_new. The
first patch is a fix that could be backported to stable, but it's not
very urgent. It's only problematic if such a device is unbound (which
happens rarely) and then clk_prepare_enable() fails. Up to you if you
want to tag it as stable material.

The overall goal is to reduce the number of drivers using the irritating
.remove() callback by one. See the commit log of the third patch for the
reasoning.

Best regards
Uwe

Uwe Kleine-König (3):
  crypto: stm32/hash - Properly handle pm_runtime_get failing
  crypto: stm32/hash - Drop if block with always false condition
  crypto: stm32/hash - Convert to platform remove callback returning
    void

 drivers/crypto/stm32/stm32-hash.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

base-commit: 3de0152bf26ff0c5083ef831ba7676fc4c92e63a

Comments

Herbert Xu Aug. 11, 2023, 11:28 a.m. UTC | #1
On Mon, Jul 31, 2023 at 06:54:53PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> this patch series converts the stm32-hash driver to use .remove_new. The
> first patch is a fix that could be backported to stable, but it's not
> very urgent. It's only problematic if such a device is unbound (which
> happens rarely) and then clk_prepare_enable() fails. Up to you if you
> want to tag it as stable material.
> 
> The overall goal is to reduce the number of drivers using the irritating
> .remove() callback by one. See the commit log of the third patch for the
> reasoning.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (3):
>   crypto: stm32/hash - Properly handle pm_runtime_get failing
>   crypto: stm32/hash - Drop if block with always false condition
>   crypto: stm32/hash - Convert to platform remove callback returning
>     void
> 
>  drivers/crypto/stm32/stm32-hash.c | 19 ++++++-------------
>  1 file changed, 6 insertions(+), 13 deletions(-)
> 
> base-commit: 3de0152bf26ff0c5083ef831ba7676fc4c92e63a
> -- 
> 2.39.2

All applied.  Thanks.