diff mbox series

[3/4] libselinux: drop obsolete optimization flag

Message ID 20230803162326.302824-3-cgzones@googlemail.com (mailing list archive)
State Accepted
Commit f9df9487adee
Delegated to: Petr Lautrbach
Headers show
Series [1/4] libselinux/utils: update selabel_partial_match | expand

Commit Message

Christian Göttsche Aug. 3, 2023, 4:23 p.m. UTC 
The flag -fipa-pure-const is enabled by default in GCC at -O0 and above.

The flag is not supported by Clang, which might result in issues if a
compilation database was created via GCC.
---
 libselinux/src/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Carter Aug. 11, 2023, 1:13 p.m. UTC | #1 
On Thu, Aug 3, 2023 at 12:38 PM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> The flag -fipa-pure-const is enabled by default in GCC at -O0 and above.
>
> The flag is not supported by Clang, which might result in issues if a
> compilation database was created via GCC.


Oops. I just realized that your signed-off is missing.
Jim

> ---
>  libselinux/src/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
> index f9a1e5f5..b1620113 100644
> --- a/libselinux/src/Makefile
> +++ b/libselinux/src/Makefile
> @@ -61,7 +61,7 @@ SRCS= $(filter-out $(GENERATED) audit2why.c, $(sort $(wildcard *.c)))
>  MAX_STACK_SIZE=32768
>
>  ifeq ($(COMPILER), gcc)
> -EXTRA_CFLAGS = -fipa-pure-const -Wlogical-op -Wpacked-bitfield-compat -Wsync-nand \
> +EXTRA_CFLAGS = -Wlogical-op -Wpacked-bitfield-compat -Wsync-nand \
>         -Wcoverage-mismatch -Wcpp -Wformat-contains-nul -Wnormalized=nfc -Wsuggest-attribute=const \
>         -Wsuggest-attribute=noreturn -Wsuggest-attribute=pure -Wtrampolines -Wjump-misses-init \
>         -Wno-suggest-attribute=pure -Wno-suggest-attribute=const -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 \
> --
> 2.40.1
>
diff mbox series

Patch

diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
index f9a1e5f5..b1620113 100644
--- a/libselinux/src/Makefile
+++ b/libselinux/src/Makefile
@@ -61,7 +61,7 @@  SRCS= $(filter-out $(GENERATED) audit2why.c, $(sort $(wildcard *.c)))
 MAX_STACK_SIZE=32768
 
 ifeq ($(COMPILER), gcc)
-EXTRA_CFLAGS = -fipa-pure-const -Wlogical-op -Wpacked-bitfield-compat -Wsync-nand \
+EXTRA_CFLAGS = -Wlogical-op -Wpacked-bitfield-compat -Wsync-nand \
 	-Wcoverage-mismatch -Wcpp -Wformat-contains-nul -Wnormalized=nfc -Wsuggest-attribute=const \
 	-Wsuggest-attribute=noreturn -Wsuggest-attribute=pure -Wtrampolines -Wjump-misses-init \
 	-Wno-suggest-attribute=pure -Wno-suggest-attribute=const -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 \