| Message ID | 20230809154813.16033-1-aboutphysycs@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | thermal: broadcom: brcstb_thermal: removed unneeded platform_set_drvdata() | expand |
On Wed, Aug 9, 2023 at 6:48 PM Andrei Coardos <aboutphysycs@gmail.com> wrote: > > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > Reviewed-by: Alexandru Ardelean <alex@shruggie.ro> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/thermal/broadcom/brcmstb_thermal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c > index 72d1dbe60b8f..2997c589ac7d 100644 > --- a/drivers/thermal/broadcom/brcmstb_thermal.c > +++ b/drivers/thermal/broadcom/brcmstb_thermal.c > @@ -334,7 +334,6 @@ static int brcmstb_thermal_probe(struct platform_device *pdev) > return PTR_ERR(priv->tmon_base); > > priv->dev = &pdev->dev; > - platform_set_drvdata(pdev, priv); > of_ops = priv->temp_params->of_ops; > > thermal = devm_thermal_of_zone_register(&pdev->dev, 0, priv, > -- > 2.34.1 >
On 8/9/23 08:48, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On 09/08/2023 17:48, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- Applied, thanks
diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c index 72d1dbe60b8f..2997c589ac7d 100644 --- a/drivers/thermal/broadcom/brcmstb_thermal.c +++ b/drivers/thermal/broadcom/brcmstb_thermal.c @@ -334,7 +334,6 @@ static int brcmstb_thermal_probe(struct platform_device *pdev) return PTR_ERR(priv->tmon_base); priv->dev = &pdev->dev; - platform_set_drvdata(pdev, priv); of_ops = priv->temp_params->of_ops; thermal = devm_thermal_of_zone_register(&pdev->dev, 0, priv,
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> --- drivers/thermal/broadcom/brcmstb_thermal.c | 1 - 1 file changed, 1 deletion(-)