| Message ID | 20230809140556.45836-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 01b8539655635288dcd46366806abfacbb9b1f6c |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] bpf: Remove unused declaration bpf_link_new_file() | expand |
On 8/9/23 7:05 AM, Yue Haibing wrote: > Commit a3b80e107894 ("bpf: Allocate ID for bpf_link") > removed the implementation but not the declaration. It is good to remove unimplemented function. However, how many more of this you have already discovered? Unless it is like hundred line changes, can you please batch them all together and send them in one patch? > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > include/linux/bpf.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/bpf.h b/include/linux/bpf.h > index db3fe5a61b05..cfabbcf47bdb 100644 > --- a/include/linux/bpf.h > +++ b/include/linux/bpf.h > @@ -2120,7 +2120,6 @@ void bpf_link_cleanup(struct bpf_link_primer *primer); > void bpf_link_inc(struct bpf_link *link); > void bpf_link_put(struct bpf_link *link); > int bpf_link_new_fd(struct bpf_link *link); > -struct file *bpf_link_new_file(struct bpf_link *link, int *reserved_fd); > struct bpf_link *bpf_link_get_from_fd(u32 ufd); > struct bpf_link *bpf_link_get_curr_or_next(u32 *id); >
On 2023/8/10 6:10, Martin KaFai Lau wrote: > On 8/9/23 7:05 AM, Yue Haibing wrote: >> Commit a3b80e107894 ("bpf: Allocate ID for bpf_link") >> removed the implementation but not the declaration. > > It is good to remove unimplemented function. However, how many more of this you have already discovered? Unless it is like hundred line changes, can you please batch them all together and send them in one patch? Ok, glad to follow this rule. For bpf I only found this one left now. > >> >> Signed-off-by: Yue Haibing <yuehaibing@huawei.com> >> --- >> include/linux/bpf.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/linux/bpf.h b/include/linux/bpf.h >> index db3fe5a61b05..cfabbcf47bdb 100644 >> --- a/include/linux/bpf.h >> +++ b/include/linux/bpf.h >> @@ -2120,7 +2120,6 @@ void bpf_link_cleanup(struct bpf_link_primer *primer); >> void bpf_link_inc(struct bpf_link *link); >> void bpf_link_put(struct bpf_link *link); >> int bpf_link_new_fd(struct bpf_link *link); >> -struct file *bpf_link_new_file(struct bpf_link *link, int *reserved_fd); >> struct bpf_link *bpf_link_get_from_fd(u32 ufd); >> struct bpf_link *bpf_link_get_curr_or_next(u32 *id); >> > > .
Hello: This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <martin.lau@kernel.org>: On Wed, 9 Aug 2023 22:05:56 +0800 you wrote: > Commit a3b80e107894 ("bpf: Allocate ID for bpf_link") > removed the implementation but not the declaration. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > include/linux/bpf.h | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [bpf-next] bpf: Remove unused declaration bpf_link_new_file() https://git.kernel.org/bpf/bpf-next/c/01b853965563 You are awesome, thank you!
diff --git a/include/linux/bpf.h b/include/linux/bpf.h index db3fe5a61b05..cfabbcf47bdb 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -2120,7 +2120,6 @@ void bpf_link_cleanup(struct bpf_link_primer *primer); void bpf_link_inc(struct bpf_link *link); void bpf_link_put(struct bpf_link *link); int bpf_link_new_fd(struct bpf_link *link); -struct file *bpf_link_new_file(struct bpf_link *link, int *reserved_fd); struct bpf_link *bpf_link_get_from_fd(u32 ufd); struct bpf_link *bpf_link_get_curr_or_next(u32 *id);
Commit a3b80e107894 ("bpf: Allocate ID for bpf_link") removed the implementation but not the declaration. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- include/linux/bpf.h | 1 - 1 file changed, 1 deletion(-)