| Message ID | 20230811105005.7692-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2045b3938ffad5bc986f68b9bb44acb188c73792 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: e1000: Remove unused declarations | expand |
On Fri, Aug 11, 2023 at 06:50:05PM +0800, Yue Haibing wrote: > Commit 675ad47375c7 ("e1000: Use netdev_<level>, pr_<level> and dev_<level>") > declared but never implemented e1000_get_hw_dev_name(). > Commit 1532ecea1deb ("e1000: drop dead pcie code from e1000") > removed e1000_check_mng_mode()/e1000_blink_led_start() but not the declarations. > Commit c46b59b241ec ("e1000: Remove unused function e1000_mta_set.") > removed e1000_mta_set() but not its declaration. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 11 Aug 2023 18:50:05 +0800 you wrote: > Commit 675ad47375c7 ("e1000: Use netdev_<level>, pr_<level> and dev_<level>") > declared but never implemented e1000_get_hw_dev_name(). > Commit 1532ecea1deb ("e1000: drop dead pcie code from e1000") > removed e1000_check_mng_mode()/e1000_blink_led_start() but not the declarations. > Commit c46b59b241ec ("e1000: Remove unused function e1000_mta_set.") > removed e1000_mta_set() but not its declaration. > > [...] Here is the summary with links: - [net-next] net: e1000: Remove unused declarations https://git.kernel.org/netdev/net-next/c/2045b3938ffa You are awesome, thank you!
diff --git a/drivers/net/ethernet/intel/e1000/e1000.h b/drivers/net/ethernet/intel/e1000/e1000.h index 4817eb13ca6f..75f3fd1d8d6e 100644 --- a/drivers/net/ethernet/intel/e1000/e1000.h +++ b/drivers/net/ethernet/intel/e1000/e1000.h @@ -347,6 +347,5 @@ bool e1000_has_link(struct e1000_adapter *adapter); void e1000_power_up_phy(struct e1000_adapter *); void e1000_set_ethtool_ops(struct net_device *netdev); void e1000_check_options(struct e1000_adapter *adapter); -char *e1000_get_hw_dev_name(struct e1000_hw *hw); #endif /* _E1000_H_ */ diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.h b/drivers/net/ethernet/intel/e1000/e1000_hw.h index b57a04954ccf..95cdd17134e5 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_hw.h +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.h @@ -343,7 +343,6 @@ struct e1000_host_mng_dhcp_cookie { }; #endif -bool e1000_check_mng_mode(struct e1000_hw *hw); s32 e1000_read_eeprom(struct e1000_hw *hw, u16 reg, u16 words, u16 * data); s32 e1000_validate_eeprom_checksum(struct e1000_hw *hw); s32 e1000_update_eeprom_checksum(struct e1000_hw *hw); @@ -352,7 +351,6 @@ s32 e1000_read_mac_addr(struct e1000_hw *hw); /* Filters (multicast, vlan, receive) */ u32 e1000_hash_mc_addr(struct e1000_hw *hw, u8 * mc_addr); -void e1000_mta_set(struct e1000_hw *hw, u32 hash_value); void e1000_rar_set(struct e1000_hw *hw, u8 * mc_addr, u32 rar_index); void e1000_write_vfta(struct e1000_hw *hw, u32 offset, u32 value); @@ -361,7 +359,6 @@ s32 e1000_setup_led(struct e1000_hw *hw); s32 e1000_cleanup_led(struct e1000_hw *hw); s32 e1000_led_on(struct e1000_hw *hw); s32 e1000_led_off(struct e1000_hw *hw); -s32 e1000_blink_led_start(struct e1000_hw *hw); /* Adaptive IFS Functions */
Commit 675ad47375c7 ("e1000: Use netdev_<level>, pr_<level> and dev_<level>") declared but never implemented e1000_get_hw_dev_name(). Commit 1532ecea1deb ("e1000: drop dead pcie code from e1000") removed e1000_check_mng_mode()/e1000_blink_led_start() but not the declarations. Commit c46b59b241ec ("e1000: Remove unused function e1000_mta_set.") removed e1000_mta_set() but not its declaration. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- drivers/net/ethernet/intel/e1000/e1000.h | 1 - drivers/net/ethernet/intel/e1000/e1000_hw.h | 3 --- 2 files changed, 4 deletions(-)