Message ID | 80c7bf32dee57a4a21e5c623b9adbc5e1175f2de.1691276610.git.ang.iglesiasg@gmail.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | iio: pressure: bmp280: Use i2c_get_match_data() | expand |
On Sun, Aug 06, 2023 at 01:15:02AM +0200, Angel Iglesias wrote: > Minor cleanup reordering local variable declarations following reverse > christmas tree convention. What about other functions there? Are all of them ordered correctly?
On Mon, 2023-08-07 at 18:43 +0300, Andy Shevchenko wrote: > On Sun, Aug 06, 2023 at 01:15:02AM +0200, Angel Iglesias wrote: > > Minor cleanup reordering local variable declarations following reverse > > christmas tree convention. > > What about other functions there? Are all of them ordered correctly? > This one was a leftover from previous work I did on this driver. I will check the rest of the drive and update it to follow the same convention if required. Thank you for your time. Kind regards Angel
diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp280-i2c.c index dbe630ad05b5..693eb1975fdc 100644 --- a/drivers/iio/pressure/bmp280-i2c.c +++ b/drivers/iio/pressure/bmp280-i2c.c @@ -7,9 +7,9 @@ static int bmp280_i2c_probe(struct i2c_client *client) { - struct regmap *regmap; - const struct bmp280_chip_info *chip_info; const struct i2c_device_id *id = i2c_client_get_device_id(client); + const struct bmp280_chip_info *chip_info; + struct regmap *regmap; chip_info = device_get_match_data(&client->dev); if (!chip_info)
Minor cleanup reordering local variable declarations following reverse christmas tree convention. Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>