| Message ID | 20230621223311.2239547-1-jonas@kwiboo.se (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/rockchip: Fix crtc duplicate state and crtc reset funcs | expand |
Hi Heiko, Please consider reviewing and merging this series [2], and also [3]. drm/rockchip: Fix crtc duplicate state and crtc reset funcs [2] https://lore.kernel.org/all/20230621223311.2239547-1-jonas@kwiboo.se/ drm/rockchip: vop: Add NV15, NV20 and NV30 support [3] https://lore.kernel.org/all/20230618220122.3911297-1-jonas@kwiboo.se/ Regards, Jonas On 2023-06-22 00:33, Jonas Karlman wrote: > This series fixes a reset of state in duplicate state crtc funcs for VOP > driver, a possible crash and ensure crtc reset helper is called in VOP2 > driver. > > Patch 1 use kmemdup instead of kzalloc to duplicate the crtc state. > Patch 2 change to use crtc and plane cleanup helpers directly. > Patch 3 adds a null guard for allocation failure. > Patch 4 adds a crash guard for empty crtc state. > Patch 5 adds a missing call to crtc reset helper. > > This is the next part of an ongoing effort to upstream HDMI 2.0 support > used in LibreELEC for the past 3+ years. > > Changes in v2: > - Handle possible allocation failure in crtc reset funcs > - Collect r-b tags > > This series is also available at [1]. > > [1] https://github.com/Kwiboo/linux-rockchip/commits/next-20230621-duplicate-state > > Jonas Karlman (5): > drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs > drm/rockchip: vop: Use cleanup helper directly as destroy funcs > drm/rockchip: vop: Fix call to crtc reset helper > drm/rockchip: vop2: Don't crash for invalid duplicate_state > drm/rockchip: vop2: Add missing call to crtc reset helper > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 24 +++++------- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 39 ++++++++++---------- > 2 files changed, 28 insertions(+), 35 deletions(-) >
On Wed, 21 Jun 2023 22:33:15 +0000 (UTC), Jonas Karlman wrote: > This series fixes a reset of state in duplicate state crtc funcs for VOP > driver, a possible crash and ensure crtc reset helper is called in VOP2 > driver. > > Patch 1 use kmemdup instead of kzalloc to duplicate the crtc state. > Patch 2 change to use crtc and plane cleanup helpers directly. > Patch 3 adds a null guard for allocation failure. > Patch 4 adds a crash guard for empty crtc state. > Patch 5 adds a missing call to crtc reset helper. > > [...] Applied, thanks! [1/5] drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs commit: 13fc28804bf10ca0b7bce3efbba95c534836d7ca [2/5] drm/rockchip: vop: Use cleanup helper directly as destroy funcs commit: 800f7c332df7cd9614c416fd005a6bb53f96f13c [3/5] drm/rockchip: vop: Fix call to crtc reset helper commit: 5aacd290837828c089a83ac9795c74c4c9e2c923 [4/5] drm/rockchip: vop2: Don't crash for invalid duplicate_state commit: 342f7e4967d02b0ec263b15916304fc54841b608 [5/5] drm/rockchip: vop2: Add missing call to crtc reset helper commit: 4d49d87b3606369c6e29b9d051892ee1a6fc4e75 Best regards,
Hi Jonas, Am Samstag, 12. August 2023, 16:18:05 CEST schrieb Jonas Karlman: > Please consider reviewing and merging this series [2], and also [3]. during the last months my testfarm aquired some issues, I'm still working on fixing, so my testing is way limited right now. > drm/rockchip: Fix crtc duplicate state and crtc reset funcs > [2] https://lore.kernel.org/all/20230621223311.2239547-1-jonas@kwiboo.se/ Though this one looked easy and when going through the code looked quite right. > drm/rockchip: vop: Add NV15, NV20 and NV30 support > [3] https://lore.kernel.org/all/20230618220122.3911297-1-jonas@kwiboo.se/ I guess I need to track down someone on IRC to tell me if these new NVxx types look correct, because I don't have too much clue about those drm-formats yet. Hopefully I'll get to that on monday. Heiko > On 2023-06-22 00:33, Jonas Karlman wrote: > > This series fixes a reset of state in duplicate state crtc funcs for VOP > > driver, a possible crash and ensure crtc reset helper is called in VOP2 > > driver. > > > > Patch 1 use kmemdup instead of kzalloc to duplicate the crtc state. > > Patch 2 change to use crtc and plane cleanup helpers directly. > > Patch 3 adds a null guard for allocation failure. > > Patch 4 adds a crash guard for empty crtc state. > > Patch 5 adds a missing call to crtc reset helper. > > > > This is the next part of an ongoing effort to upstream HDMI 2.0 support > > used in LibreELEC for the past 3+ years. > > > > Changes in v2: > > - Handle possible allocation failure in crtc reset funcs > > - Collect r-b tags > > > > This series is also available at [1]. > > > > [1] https://github.com/Kwiboo/linux-rockchip/commits/next-20230621-duplicate-state > > > > Jonas Karlman (5): > > drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs > > drm/rockchip: vop: Use cleanup helper directly as destroy funcs > > drm/rockchip: vop: Fix call to crtc reset helper > > drm/rockchip: vop2: Don't crash for invalid duplicate_state > > drm/rockchip: vop2: Add missing call to crtc reset helper > > > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 24 +++++------- > > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 39 ++++++++++---------- > > 2 files changed, 28 insertions(+), 35 deletions(-) > > > >