| Message ID | 20230812-pxa1908-lkml-v5-1-a5d51937ee34@skole.hr (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Initial Marvell PXA1908 support | expand |
On Sat, Aug 12, 2023 at 12:26 PM Duje Mihanović <duje.mihanovic@skole.hr> wrote: > > Similarly to PXA3xx and MMP2, pinctrl-single isn't capable of setting > pin direction on MMP either. > > Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request") > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > Reviewed-by: Andy Shevchenko <andy@kernel.org> > --- > drivers/gpio/gpio-pxa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c > index a1630ed4b741..d92650aecb06 100644 > --- a/drivers/gpio/gpio-pxa.c > +++ b/drivers/gpio/gpio-pxa.c > @@ -238,6 +238,7 @@ static bool pxa_gpio_has_pinctrl(void) > switch (gpio_type) { > case PXA3XX_GPIO: > case MMP2_GPIO: > + case MMP_GPIO: > return false; > > default: > > -- > 2.41.0 > > Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Sat, Aug 12, 2023 at 12:26 PM Duje Mihanović <duje.mihanovic@skole.hr> wrote: > Similarly to PXA3xx and MMP2, pinctrl-single isn't capable of setting > pin direction on MMP either. > > Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request") > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > Reviewed-by: Andy Shevchenko <andy@kernel.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index a1630ed4b741..d92650aecb06 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -238,6 +238,7 @@ static bool pxa_gpio_has_pinctrl(void) switch (gpio_type) { case PXA3XX_GPIO: case MMP2_GPIO: + case MMP_GPIO: return false; default:
Similarly to PXA3xx and MMP2, pinctrl-single isn't capable of setting pin direction on MMP either. Fixes: a770d946371e ("gpio: pxa: add pin control gpio direction and request") Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> Reviewed-by: Andy Shevchenko <andy@kernel.org> --- drivers/gpio/gpio-pxa.c | 1 + 1 file changed, 1 insertion(+)