mbox series

[net-next,v6,0/2] netconsole: Enable compile time configuration

Message ID 20230811093158.1678322-1-leitao@debian.org (mailing list archive)
Headers show
Series netconsole: Enable compile time configuration | expand

Message

Breno Leitao Aug. 11, 2023, 9:31 a.m. UTC
Enable netconsole features to be set at compilation time. Create two
Kconfig options that allow users to set extended logs and release
prepending features at compilation time.

The first patch de-duplicates the initialization code, and the second
patch adds the support in the de-duplicated code, avoiding touching two
different functions with the same change.

  v1 -> v2:
	* Improvements in the Kconfig help section.

  v2 -> v3:
	* Honour the Kconfig settings when creating sysfs targets
	* Add "by default" in a Kconfig help.

  v3 -> v4:
	* Create an additional patch, de-duplicating the initialization
	  code for netconsole_target, and just patching it.

  v4 -> v5:
	* Remove complex code in the variable initialization.

  v5 -> v6:
	* Return -EINVAL for invalid configuration during
	  initialization.

Breno Leitao (2):
  netconsole: Create a allocation helper
  netconsole: Enable compile time configuration

 drivers/net/Kconfig      | 22 ++++++++++++++++++
 drivers/net/netconsole.c | 48 +++++++++++++++++++++++-----------------
 2 files changed, 50 insertions(+), 20 deletions(-)

Comments

Simon Horman Aug. 15, 2023, 7:30 a.m. UTC | #1
On Fri, Aug 11, 2023 at 02:31:56AM -0700, Breno Leitao wrote:
> Enable netconsole features to be set at compilation time. Create two
> Kconfig options that allow users to set extended logs and release
> prepending features at compilation time.
> 
> The first patch de-duplicates the initialization code, and the second
> patch adds the support in the de-duplicated code, avoiding touching two
> different functions with the same change.
> 
>   v1 -> v2:
> 	* Improvements in the Kconfig help section.
> 
>   v2 -> v3:
> 	* Honour the Kconfig settings when creating sysfs targets
> 	* Add "by default" in a Kconfig help.
> 
>   v3 -> v4:
> 	* Create an additional patch, de-duplicating the initialization
> 	  code for netconsole_target, and just patching it.
> 
>   v4 -> v5:
> 	* Remove complex code in the variable initialization.
> 
>   v5 -> v6:
> 	* Return -EINVAL for invalid configuration during
> 	  initialization.
> 
> Breno Leitao (2):
>   netconsole: Create a allocation helper
>   netconsole: Enable compile time configuration
> 
>  drivers/net/Kconfig      | 22 ++++++++++++++++++
>  drivers/net/netconsole.c | 48 +++++++++++++++++++++++-----------------
>  2 files changed, 50 insertions(+), 20 deletions(-)

Thanks Breno,

thanks for addressing the feedback given for previous revisions.

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Aug. 18, 2023, 3:10 a.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 11 Aug 2023 02:31:56 -0700 you wrote:
> Enable netconsole features to be set at compilation time. Create two
> Kconfig options that allow users to set extended logs and release
> prepending features at compilation time.
> 
> The first patch de-duplicates the initialization code, and the second
> patch adds the support in the de-duplicated code, avoiding touching two
> different functions with the same change.
> 
> [...]

Here is the summary with links:
  - [net-next,v6,1/2] netconsole: Create a allocation helper
    https://git.kernel.org/netdev/net-next/c/b0a9e2c9a99f
  - [net-next,v6,2/2] netconsole: Enable compile time configuration
    https://git.kernel.org/netdev/net-next/c/fad361a2ee90

You are awesome, thank you!