| Message ID | 20230815204141.51972-1-atulpant.linux@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] drivers: usb: Removes use of assignment in if condition | expand |
On Wed, Aug 16, 2023 at 02:11:41AM +0530, Atul Kumar Pant wrote: > This patch fixes following checkpatch.pl issue: > ERROR: do not use assignment in if condition > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> > --- > drivers/usb/core/devio.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > index e501a03d6c70..56899fed6bd4 100644 > --- a/drivers/usb/core/devio.c > +++ b/drivers/usb/core/devio.c > @@ -2333,9 +2333,10 @@ static int proc_ioctl(struct usb_dev_state *ps, struct usbdevfs_ioctl *ctl) > } > } > > + intf = usb_ifnum_to_if(ps->dev, ctl->ifno); > if (ps->dev->state != USB_STATE_CONFIGURED) > retval = -EHOSTUNREACH; > - else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno))) > + else if (!intf) Did you mean to change the logic here by doing the calculation always? Does that change functionality? The existing code is fine, running checkpatch on code outside of drivers/staging/ or on new patches you are writing, is generally discouraged as the code usually is older than checkpatch is :) thanks, greg k-h
On Tue, Aug 15, 2023 at 11:07:02PM +0200, Greg KH wrote: > On Wed, Aug 16, 2023 at 02:11:41AM +0530, Atul Kumar Pant wrote: > > This patch fixes following checkpatch.pl issue: > > ERROR: do not use assignment in if condition > > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> > > --- > > drivers/usb/core/devio.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > > index e501a03d6c70..56899fed6bd4 100644 > > --- a/drivers/usb/core/devio.c > > +++ b/drivers/usb/core/devio.c > > @@ -2333,9 +2333,10 @@ static int proc_ioctl(struct usb_dev_state *ps, struct usbdevfs_ioctl *ctl) > > } > > } > > > > + intf = usb_ifnum_to_if(ps->dev, ctl->ifno); > > if (ps->dev->state != USB_STATE_CONFIGURED) > > retval = -EHOSTUNREACH; > > - else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno))) > > + else if (!intf) > > Did you mean to change the logic here by doing the calculation always? > Does that change functionality? > > The existing code is fine, running checkpatch on code outside of > drivers/staging/ or on new patches you are writing, is generally > discouraged as the code usually is older than checkpatch is :) Understood. One question though, should we fix issues like no space before open parenthesis (e.g. if(val)) in the code that is outside of /drivers/staging/ ? > > thanks, > > greg k-h
On Tue, Aug 15, 2023 at 11:07:02PM +0200, Greg KH wrote: > On Wed, Aug 16, 2023 at 02:11:41AM +0530, Atul Kumar Pant wrote: > > This patch fixes following checkpatch.pl issue: > > ERROR: do not use assignment in if condition > > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> > > --- > > drivers/usb/core/devio.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > > index e501a03d6c70..56899fed6bd4 100644 > > --- a/drivers/usb/core/devio.c > > +++ b/drivers/usb/core/devio.c > > @@ -2333,9 +2333,10 @@ static int proc_ioctl(struct usb_dev_state *ps, struct usbdevfs_ioctl *ctl) > > } > > } > > > > + intf = usb_ifnum_to_if(ps->dev, ctl->ifno); > > if (ps->dev->state != USB_STATE_CONFIGURED) > > retval = -EHOSTUNREACH; > > - else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno))) > > + else if (!intf) > > Did you mean to change the logic here by doing the calculation always? > Does that change functionality? > Now the calculation of interface will be done always, which can be redundant. But this would not change the functionality. > The existing code is fine, running checkpatch on code outside of > drivers/staging/ or on new patches you are writing, is generally > discouraged as the code usually is older than checkpatch is :) > > thanks, > > greg k-h
On Wed, Aug 16, 2023 at 09:13:13AM +0530, Atul Kumar Pant wrote: > On Tue, Aug 15, 2023 at 11:07:02PM +0200, Greg KH wrote: > > On Wed, Aug 16, 2023 at 02:11:41AM +0530, Atul Kumar Pant wrote: > > > This patch fixes following checkpatch.pl issue: > > > ERROR: do not use assignment in if condition > > > > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> > > > --- > > > drivers/usb/core/devio.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > > > index e501a03d6c70..56899fed6bd4 100644 > > > --- a/drivers/usb/core/devio.c > > > +++ b/drivers/usb/core/devio.c > > > @@ -2333,9 +2333,10 @@ static int proc_ioctl(struct usb_dev_state *ps, struct usbdevfs_ioctl *ctl) > > > } > > > } > > > > > > + intf = usb_ifnum_to_if(ps->dev, ctl->ifno); > > > if (ps->dev->state != USB_STATE_CONFIGURED) > > > retval = -EHOSTUNREACH; > > > - else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno))) > > > + else if (!intf) > > > > Did you mean to change the logic here by doing the calculation always? > > Does that change functionality? > > > Now the calculation of interface will be done always, which can be > redundant. But this would not change the functionality. Yes, but it is now redundant, so this change isn't really needed, the original code is "more correct", please leave it as-is. thanks, greg k-h
On Wed, Aug 16, 2023 at 08:22:17AM +0530, Atul Kumar Pant wrote: > On Tue, Aug 15, 2023 at 11:07:02PM +0200, Greg KH wrote: > > On Wed, Aug 16, 2023 at 02:11:41AM +0530, Atul Kumar Pant wrote: > > > This patch fixes following checkpatch.pl issue: > > > ERROR: do not use assignment in if condition > > > > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> > > > --- > > > drivers/usb/core/devio.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > > > index e501a03d6c70..56899fed6bd4 100644 > > > --- a/drivers/usb/core/devio.c > > > +++ b/drivers/usb/core/devio.c > > > @@ -2333,9 +2333,10 @@ static int proc_ioctl(struct usb_dev_state *ps, struct usbdevfs_ioctl *ctl) > > > } > > > } > > > > > > + intf = usb_ifnum_to_if(ps->dev, ctl->ifno); > > > if (ps->dev->state != USB_STATE_CONFIGURED) > > > retval = -EHOSTUNREACH; > > > - else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno))) > > > + else if (!intf) > > > > Did you mean to change the logic here by doing the calculation always? > > Does that change functionality? > > > > The existing code is fine, running checkpatch on code outside of > > drivers/staging/ or on new patches you are writing, is generally > > discouraged as the code usually is older than checkpatch is :) > > Understood. One question though, should we fix issues like no space > before open parenthesis (e.g. if(val)) in the code that is outside > of /drivers/staging/ ? Only if the maintainer of that subsystem says it is ok to do so. good luck! greg k-h
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index e501a03d6c70..56899fed6bd4 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -2333,9 +2333,10 @@ static int proc_ioctl(struct usb_dev_state *ps, struct usbdevfs_ioctl *ctl) } } + intf = usb_ifnum_to_if(ps->dev, ctl->ifno); if (ps->dev->state != USB_STATE_CONFIGURED) retval = -EHOSTUNREACH; - else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno))) + else if (!intf) retval = -EINVAL; else switch (ctl->ioctl_code) {
This patch fixes following checkpatch.pl issue: ERROR: do not use assignment in if condition Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> --- drivers/usb/core/devio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)