| Message ID | 20230815074927.1016787-1-lizetao1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 61a9b174f461de4d0668a98ca2f668b65ebdf131 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] nfc: virtual_ncidev: Use module_misc_device macro to simplify the code | expand |
On 15/08/2023 09:49, Li Zetao wrote: > Use the module_misc_device macro to simplify the code, which is the > same as declaring with module_init() and module_exit(). > > Signed-off-by: Li Zetao <lizetao1@huawei.com> > --- > drivers/nfc/virtual_ncidev.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 15 Aug 2023 15:49:27 +0800 you wrote: > Use the module_misc_device macro to simplify the code, which is the > same as declaring with module_init() and module_exit(). > > Signed-off-by: Li Zetao <lizetao1@huawei.com> > --- > drivers/nfc/virtual_ncidev.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) Here is the summary with links: - [-next] nfc: virtual_ncidev: Use module_misc_device macro to simplify the code https://git.kernel.org/netdev/net-next/c/61a9b174f461 You are awesome, thank you!
diff --git a/drivers/nfc/virtual_ncidev.c b/drivers/nfc/virtual_ncidev.c index bb76c7c7cc82..b027be0b0b6f 100644 --- a/drivers/nfc/virtual_ncidev.c +++ b/drivers/nfc/virtual_ncidev.c @@ -200,18 +200,7 @@ static struct miscdevice miscdev = { .mode = 0600, }; -static int __init virtual_ncidev_init(void) -{ - return misc_register(&miscdev); -} - -static void __exit virtual_ncidev_exit(void) -{ - misc_deregister(&miscdev); -} - -module_init(virtual_ncidev_init); -module_exit(virtual_ncidev_exit); +module_misc_device(miscdev); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Virtual NCI device simulation driver");
Use the module_misc_device macro to simplify the code, which is the same as declaring with module_init() and module_exit(). Signed-off-by: Li Zetao <lizetao1@huawei.com> --- drivers/nfc/virtual_ncidev.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)