diff mbox series

ASoC: SOF: ipc4-pcm: fix possible null pointer deference

Message ID 20230816133311.7523-1-peter.ujfalusi@linux.intel.com (mailing list archive)
State Accepted
Commit 2d218b45848b92b03b220bf4d9bef29f058f866f
Headers show
Series ASoC: SOF: ipc4-pcm: fix possible null pointer deference | expand

Commit Message

Peter Ujfalusi Aug. 16, 2023, 1:33 p.m. UTC 
From: Chao Song <chao.song@linux.intel.com>

The call to snd_sof_find_spcm_dai() could return NULL,
add nullable check for the return value to avoid null
pointer defenrece.

Fixes: 7cb19007baba ("ASoC: SOF: ipc4-pcm: add hw_params")
Signed-off-by: Chao Song <chao.song@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
 sound/soc/sof/ipc4-pcm.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown Aug. 16, 2023, 4:16 p.m. UTC | #1 
On Wed, 16 Aug 2023 16:33:11 +0300, Peter Ujfalusi wrote:
> The call to snd_sof_find_spcm_dai() could return NULL,
> add nullable check for the return value to avoid null
> pointer defenrece.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: ipc4-pcm: fix possible null pointer deference
      commit: 2d218b45848b92b03b220bf4d9bef29f058f866f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/sof/ipc4-pcm.c b/sound/soc/sof/ipc4-pcm.c
index 802cbf73594e..db19cd03ecad 100644
--- a/sound/soc/sof/ipc4-pcm.c
+++ b/sound/soc/sof/ipc4-pcm.c
@@ -709,6 +709,9 @@  static int sof_ipc4_pcm_hw_params(struct snd_soc_component *component,
 	struct snd_sof_pcm *spcm;
 
 	spcm = snd_sof_find_spcm_dai(component, rtd);
+	if (!spcm)
+		return -EINVAL;
+
 	time_info = spcm->stream[substream->stream].private;
 	/* delay calculation is not supported by current fw_reg ABI */
 	if (!time_info)