Message ID | 20230717182859.707658-1-berrange@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | tests: enable meson test timeouts to improve debuggability | expand |
Daniel P. Berrangé <berrange@redhat.com> writes: > Perhaps the most painful of all the GitLab CI failures we see are > the enforced job timeouts: > > "ERROR: Job failed: execution took longer than 1h15m0s seconds" > > https://gitlab.com/qemu-project/qemu/-/jobs/4387047648 > > when that hits the CI log shows what has *already* run, but figuring > out what was currently running (or rather stuck) is an horrendously > difficult. I had this in my tree but I see there are a number of review comments to take into account. Will there be a v3 and do we want it this late in the cycle?
On 08/08/2023 10.57, Alex Bennée wrote: > > Daniel P. Berrangé <berrange@redhat.com> writes: > >> Perhaps the most painful of all the GitLab CI failures we see are >> the enforced job timeouts: >> >> "ERROR: Job failed: execution took longer than 1h15m0s seconds" >> >> https://gitlab.com/qemu-project/qemu/-/jobs/4387047648 >> >> when that hits the CI log shows what has *already* run, but figuring >> out what was currently running (or rather stuck) is an horrendously >> difficult. > > I had this in my tree but I see there are a number of review comments to > take into account. Will there be a v3 and do we want it this late in the > cycle? I think this could maybe cause some false positives in the CI until we fine-tuned all related timeouts, so no, we don't want to have this in the last release candidates of 8.1. We should commit it early in the 8.2 cycle (hoping that Daniel has some spare minutes to release a v3), so we can iron out the remaining issues there. Thomas
On Sun, Aug 13, 2023 at 09:02:03AM +0200, Thomas Huth wrote: > On 08/08/2023 10.57, Alex Bennée wrote: > > > > Daniel P. Berrangé <berrange@redhat.com> writes: > > > > > Perhaps the most painful of all the GitLab CI failures we see are > > > the enforced job timeouts: > > > > > > "ERROR: Job failed: execution took longer than 1h15m0s seconds" > > > > > > https://gitlab.com/qemu-project/qemu/-/jobs/4387047648 > > > > > > when that hits the CI log shows what has *already* run, but figuring > > > out what was currently running (or rather stuck) is an horrendously > > > difficult. > > > > I had this in my tree but I see there are a number of review comments to > > take into account. Will there be a v3 and do we want it this late in the > > cycle? > > I think this could maybe cause some false positives in the CI until we > fine-tuned all related timeouts, so no, we don't want to have this in the > last release candidates of 8.1. We should commit it early in the 8.2 cycle > (hoping that Daniel has some spare minutes to release a v3), so we can iron > out the remaining issues there. Agreed, it is safer to wait until 8.2 I've been away on holiday, but will post a v3 after I catchup With regards, Daniel