[RESEND,v3,0/3] few fixes for synthetic trace events

Message

Sven Schnelle Aug. 16, 2023, 3:49 p.m. UTC

Hi Steven,

I'm now sending these patches in one patchset, because the second patch
has a dependeny on the union vs. cast fix.

Changes in v3:
- remove superfluous struct around union trace_synth_field

Changes in v2:
- cosmetic changes
- add struct trace_dynamic_info to include/linux/trace_events.h

Sven Schnelle (3):
  tracing/synthetic: use union instead of casts
  tracing/synthetic: skip first entry for stack traces
  tracing/synthetic: allocate one additional element for size

 include/linux/trace_events.h      |  11 ++++
 kernel/trace/trace.h              |   8 +++
 kernel/trace/trace_events_synth.c | 103 ++++++++++++------------------
 3 files changed, 60 insertions(+), 62 deletions(-)

Comments

Steven Rostedt Aug. 17, 2023, 3:05 p.m. UTC | #1

On Wed, 16 Aug 2023 17:49:25 +0200
Sven Schnelle <[e-mail]> wrote:

> Hi Steven,
> 
> I'm now sending these patches in one patchset, because the second patch
> has a dependeny on the union vs. cast fix.

Thanks. I'm currently waiting on some other fixes before running them all
through my tests before sending them off to Linus. If they are not ready by
tomorrow, I'll just kick off my tests without them.

-- Steve


> 
> Changes in v3:
> - remove superfluous struct around union trace_synth_field
> 
> Changes in v2:
> - cosmetic changes
> - add struct trace_dynamic_info to include/linux/trace_events.h
> 
> Sven Schnelle (3):
>   tracing/synthetic: use union instead of casts
>   tracing/synthetic: skip first entry for stack traces
>   tracing/synthetic: allocate one additional element for size
> 
>  include/linux/trace_events.h      |  11 ++++
>  kernel/trace/trace.h              |   8 +++
>  kernel/trace/trace_events_synth.c | 103 ++++++++++++------------------
>  3 files changed, 60 insertions(+), 62 deletions(-)
>