| Message ID | 20230816220203.1865432-1-prohr@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [netdev-next] net: release reference to inet6_dev pointer | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net |
| netdev/apply | fail | Patch does not apply to net |
On Wed, Aug 16, 2023 at 03:02:03PM -0700, Patrick Rohr wrote: > addrconf_prefix_rcv returned early without releasing the inet6_dev > pointer when the PIO lifetime is less than accept_ra_min_lft. > > Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes") > Cc: Maciej Żenczykowski <maze@google.com> > Cc: Lorenzo Colitti <lorenzo@google.com> > Cc: David Ahern <dsahern@kernel.org> > Signed-off-by: Patrick Rohr <prohr@google.com> Hi Patrick, this patch looks good to me, but unfortunately our CI got a bit confused and tried to apply it to net, where it does not apply because the cited commit is not present there, rather than net-next, where it does apply. This creates a process issue for us. I think it would be useful if you could repost the patch with it targeted at net-next: Subject: [PATCH net-next] ... Please feel free to include: Reviewed-by: Simon Horman <horms@kernel.org>
feel free to also add:
Reviewed-by: Maciej Żenczykowski <maze@google.com>
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 5184bd0ceb12..47d1dd8501b7 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2742,7 +2742,7 @@ void addrconf_prefix_rcv(struct net_device *dev, u8 *opt, int len, bool sllao) } if (valid_lft != 0 && valid_lft < in6_dev->cnf.accept_ra_min_lft) - return; + goto put; /* * Two things going on here:
addrconf_prefix_rcv returned early without releasing the inet6_dev pointer when the PIO lifetime is less than accept_ra_min_lft. Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes") Cc: Maciej Żenczykowski <maze@google.com> Cc: Lorenzo Colitti <lorenzo@google.com> Cc: David Ahern <dsahern@kernel.org> Signed-off-by: Patrick Rohr <prohr@google.com> --- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)