| Message ID | 169234845563.1636130.4897344550692792117.stgit@firesoul (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | softirq: Adjust comment for CONFIG_PREEMPT_RT in #else | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 2023-08-18 10:47:35 [+0200], Jesper Dangaard Brouer wrote: > The #ifdef CONFIG_PREEMPT_RT #else statement had a comment > that made me think the code below #else statement was RT code. > After reading the code closer I realized it was not RT code. > Adjust comment to !RT to helper future readers of the code. indeed. > Fixes: 8b1c04acad08 ("softirq: Make softirq control and processing RT aware") > Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Sebastian
diff --git a/kernel/softirq.c b/kernel/softirq.c index 807b34ccd797..b9a8384821b9 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -292,7 +292,7 @@ void do_softirq_post_smp_call_flush(unsigned int was_pending) invoke_softirq(); } -#else /* CONFIG_PREEMPT_RT */ +#else /* !CONFIG_PREEMPT_RT */ /* * This one is for softirq.c-internal use, where hardirqs are disabled
The #ifdef CONFIG_PREEMPT_RT #else statement had a comment that made me think the code below #else statement was RT code. After reading the code closer I realized it was not RT code. Adjust comment to !RT to helper future readers of the code. Fixes: 8b1c04acad08 ("softirq: Make softirq control and processing RT aware") Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org> --- kernel/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)