mbox series

[bpf-next,0/7] Support cpu v4 instructions for arm64

Message ID 20230815154158.717901-1-xukuohai@huaweicloud.com (mailing list archive)
Headers show
Series Support cpu v4 instructions for arm64 | expand

Message

Xu Kuohai Aug. 15, 2023, 3:41 p.m. UTC
From: Xu Kuohai <xukuohai@huawei.com>

This series adds arm64 support for cpu v4 instructions [1].

[1] https://lore.kernel.org/all/20230728011143.3710005-1-yonghong.song@linux.dev/

Xu Kuohai (7):
  arm64: insn: Add encoders for LDRSB/LDRSH/LDRSW
  bpf, arm64: Support sign-extension load instructions
  bpf, arm64: Support sign-extension mov instructions
  bpf, arm64: Support unconditional bswap
  bpf, arm64: Support 32-bit offset jmp instruction
  bpf, arm64: Support signed div/mod instructions
  selftests/bpf: Enable cpu v4 tests for arm64

 arch/arm64/include/asm/insn.h                 |  4 +
 arch/arm64/lib/insn.c                         |  6 ++
 arch/arm64/net/bpf_jit.h                      | 12 +++
 arch/arm64/net/bpf_jit_comp.c                 | 91 +++++++++++++++----
 .../selftests/bpf/progs/test_ldsx_insn.c      |  2 +-
 .../selftests/bpf/progs/verifier_bswap.c      |  2 +-
 .../selftests/bpf/progs/verifier_gotol.c      |  2 +-
 .../selftests/bpf/progs/verifier_ldsx.c       |  2 +-
 .../selftests/bpf/progs/verifier_movsx.c      |  2 +-
 .../selftests/bpf/progs/verifier_sdiv.c       |  2 +-
 10 files changed, 103 insertions(+), 22 deletions(-)

Comments

Florent Revest Aug. 18, 2023, 12:22 p.m. UTC | #1
On Tue, Aug 15, 2023 at 5:21 PM Xu Kuohai <xukuohai@huaweicloud.com> wrote:
>
> From: Xu Kuohai <xukuohai@huawei.com>
>
> This series adds arm64 support for cpu v4 instructions [1].
>
> [1] https://lore.kernel.org/all/20230728011143.3710005-1-yonghong.song@linux.dev/
>
> Xu Kuohai (7):
>   arm64: insn: Add encoders for LDRSB/LDRSH/LDRSW
>   bpf, arm64: Support sign-extension load instructions
>   bpf, arm64: Support sign-extension mov instructions
>   bpf, arm64: Support unconditional bswap
>   bpf, arm64: Support 32-bit offset jmp instruction
>   bpf, arm64: Support signed div/mod instructions
>   selftests/bpf: Enable cpu v4 tests for arm64

Thank you Xu! The series looks good to me so:

Acked-by: Florent Revest <revest@chromium.org>

And I could reproduce your successful test runs with a recent clang so:

Tested-by: Florent Revest <revest@chromium.org>
patchwork-bot+netdevbpf@kernel.org Aug. 18, 2023, 1:50 p.m. UTC | #2
Hello:

This series was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Tue, 15 Aug 2023 11:41:51 -0400 you wrote:
> From: Xu Kuohai <xukuohai@huawei.com>
> 
> This series adds arm64 support for cpu v4 instructions [1].
> 
> [1] https://lore.kernel.org/all/20230728011143.3710005-1-yonghong.song@linux.dev/
> 
> Xu Kuohai (7):
>   arm64: insn: Add encoders for LDRSB/LDRSH/LDRSW
>   bpf, arm64: Support sign-extension load instructions
>   bpf, arm64: Support sign-extension mov instructions
>   bpf, arm64: Support unconditional bswap
>   bpf, arm64: Support 32-bit offset jmp instruction
>   bpf, arm64: Support signed div/mod instructions
>   selftests/bpf: Enable cpu v4 tests for arm64
> 
> [...]

Here is the summary with links:
  - [bpf-next,1/7] arm64: insn: Add encoders for LDRSB/LDRSH/LDRSW
    https://git.kernel.org/bpf/bpf-next/c/6c9f86d3632c
  - [bpf-next,2/7] bpf, arm64: Support sign-extension load instructions
    https://git.kernel.org/bpf/bpf-next/c/cc88f540da52
  - [bpf-next,3/7] bpf, arm64: Support sign-extension mov instructions
    https://git.kernel.org/bpf/bpf-next/c/bb0a1d6b49cb
  - [bpf-next,4/7] bpf, arm64: Support unconditional bswap
    https://git.kernel.org/bpf/bpf-next/c/1104247f3f97
  - [bpf-next,5/7] bpf, arm64: Support 32-bit offset jmp instruction
    https://git.kernel.org/bpf/bpf-next/c/c32b6ee514d2
  - [bpf-next,6/7] bpf, arm64: Support signed div/mod instructions
    https://git.kernel.org/bpf/bpf-next/c/68b18191fe41
  - [bpf-next,7/7] selftests/bpf: Enable cpu v4 tests for arm64
    https://git.kernel.org/bpf/bpf-next/c/5f6395fd0680

You are awesome, thank you!