| Message ID | 20230818102911.18388-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8d4ff1351801bd646c9fed7aedb9705250f2c87b |
| Headers | show |
| Series | dt-bindings: usb: samsung,exynos-dwc3: fix order of clocks on Exynos5433 | expand |
On Fri, 18 Aug 2023 at 05:29, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > The Exynos5433 DTSI had always different order of DWC USB3 controller > clocks than the binding. The order in the binding was introduced in the > commit 949ea75b7ba4 ("dt-bindings: usb: samsung,exynos-dwc3: convert to > dtschema") converting to DT schema. The Linux driver does not care > about order and was always getting clocks by name. Therefore assume the > DTS is the preferred order and correct the binding. > > Fixes: 949ea75b7ba4 ("dt-bindings: usb: samsung,exynos-dwc3: convert to dtschema") > Cc: Sam Protsenko <semen.protsenko@linaro.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml > index 240f41b7133a..deeed2bca2cd 100644 > --- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml > @@ -82,8 +82,8 @@ allOf: > items: > - const: aclk > - const: susp_clk > - - const: pipe_pclk > - const: phyclk > + - const: pipe_pclk > > - if: > properties: > -- > 2.34.1 >
On Fri, 18 Aug 2023 12:29:11 +0200, Krzysztof Kozlowski wrote: > The Exynos5433 DTSI had always different order of DWC USB3 controller > clocks than the binding. The order in the binding was introduced in the > commit 949ea75b7ba4 ("dt-bindings: usb: samsung,exynos-dwc3: convert to > dtschema") converting to DT schema. The Linux driver does not care > about order and was always getting clocks by name. Therefore assume the > DTS is the preferred order and correct the binding. > > Fixes: 949ea75b7ba4 ("dt-bindings: usb: samsung,exynos-dwc3: convert to dtschema") > Cc: Sam Protsenko <semen.protsenko@linaro.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml index 240f41b7133a..deeed2bca2cd 100644 --- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml @@ -82,8 +82,8 @@ allOf: items: - const: aclk - const: susp_clk - - const: pipe_pclk - const: phyclk + - const: pipe_pclk - if: properties:
The Exynos5433 DTSI had always different order of DWC USB3 controller clocks than the binding. The order in the binding was introduced in the commit 949ea75b7ba4 ("dt-bindings: usb: samsung,exynos-dwc3: convert to dtschema") converting to DT schema. The Linux driver does not care about order and was always getting clocks by name. Therefore assume the DTS is the preferred order and correct the binding. Fixes: 949ea75b7ba4 ("dt-bindings: usb: samsung,exynos-dwc3: convert to dtschema") Cc: Sam Protsenko <semen.protsenko@linaro.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)