| Message ID | 20230817224103.3042055-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cc7dbadb7236e5e9a7da5567f838b962a524df13 |
| Headers | show |
| Series | [BlueZ,1/2] device: Don't attempt to set auto_connect for devices using RPAs | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=777197 ---Test result--- Test Summary: CheckPatch PASS 0.95 seconds GitLint PASS 0.63 seconds BuildEll PASS 32.45 seconds BluezMake PASS 1002.94 seconds MakeCheck PASS 13.71 seconds MakeDistcheck PASS 186.14 seconds CheckValgrind PASS 305.56 seconds CheckSmatch PASS 405.99 seconds bluezmakeextell PASS 123.37 seconds IncrementalBuild PASS 1634.12 seconds ScanBuild PASS 1250.37 seconds --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 17 Aug 2023 15:41:02 -0700 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > Device using private address cannot be programmed into the auto_connect > list without them being paired and its IRK being distributed otherwise > there is no way to resolve it address and the command will fail. > --- > src/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [BlueZ,1/2] device: Don't attempt to set auto_connect for devices using RPAs https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=cc7dbadb7236 - [BlueZ,2/2] device: Restart temporary timer while connecting https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0004eb06d5d9 You are awesome, thank you!
diff --git a/src/device.c b/src/device.c index e0ff0b1c1543..f6b0167bf55b 100644 --- a/src/device.c +++ b/src/device.c @@ -2006,7 +2006,7 @@ static void device_set_auto_connect(struct btd_device *device, gboolean enable) { char addr[18]; - if (!device || !device->le) + if (!device || !device->le || device_address_is_private(device)) return; ba2str(&device->bdaddr, addr);
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Device using private address cannot be programmed into the auto_connect list without them being paired and its IRK being distributed otherwise there is no way to resolve it address and the command will fail. --- src/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)