| Message ID | 20230819081302.1217098-1-lujialin4@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | memcg: Removed duplication detection for mem_cgroup_uncharge_swap | expand |
On Sat, Aug 19, 2023 at 1:14 AM Lu Jialin <lujialin4@huawei.com> wrote: > > __mem_cgroup_uncharge_swap is only called in mem_cgroup_uncharge_swap, > if mem cgroup is disabled, __mem_cgroup_uncharge_swap cannot be called. > Therefore, there is no need to judge whether mem_cgroup is disabled or > not. > > Signed-off-by: Lu Jialin <lujialin4@huawei.com> Acked-by: Shakeel Butt <shakeelb@google.com>
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index e8ca4bdcb03c..274af096c748 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -7535,9 +7535,6 @@ void __mem_cgroup_uncharge_swap(swp_entry_t entry, unsigned int nr_pages) struct mem_cgroup *memcg; unsigned short id; - if (mem_cgroup_disabled()) - return; - id = swap_cgroup_record(entry, 0, nr_pages); rcu_read_lock(); memcg = mem_cgroup_from_id(id);
__mem_cgroup_uncharge_swap is only called in mem_cgroup_uncharge_swap, if mem cgroup is disabled, __mem_cgroup_uncharge_swap cannot be called. Therefore, there is no need to judge whether mem_cgroup is disabled or not. Signed-off-by: Lu Jialin <lujialin4@huawei.com> --- mm/memcontrol.c | 3 --- 1 file changed, 3 deletions(-)