| Message ID | 20230818090224.409192-2-chigot@adacore.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Risc-V/gdb: replace exit(0) with proper shutdown | expand |
On Fri, Aug 18, 2023 at 5:03 AM Clément Chigot <chigot@adacore.com> wrote: > > This replaces the exit(0) call by a shutdown request, ensuring a proper > cleanup of Qemu. Otherwise, some connections like gdb could be broken > without being correctly flushed. > > Signed-off-by: Clément Chigot <chigot@adacore.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/misc/sifive_test.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/misc/sifive_test.c b/hw/misc/sifive_test.c > index 56df45bfe5..ab0674f8fe 100644 > --- a/hw/misc/sifive_test.c > +++ b/hw/misc/sifive_test.c > @@ -25,6 +25,7 @@ > #include "qemu/module.h" > #include "sysemu/runstate.h" > #include "hw/misc/sifive_test.h" > +#include "sysemu/sysemu.h" > > static uint64_t sifive_test_read(void *opaque, hwaddr addr, unsigned int size) > { > @@ -41,7 +42,8 @@ static void sifive_test_write(void *opaque, hwaddr addr, > case FINISHER_FAIL: > exit(code); > case FINISHER_PASS: > - exit(0); > + qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); > + return; > case FINISHER_RESET: > qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET); > return; > -- > 2.25.1 > >
diff --git a/hw/misc/sifive_test.c b/hw/misc/sifive_test.c index 56df45bfe5..ab0674f8fe 100644 --- a/hw/misc/sifive_test.c +++ b/hw/misc/sifive_test.c @@ -25,6 +25,7 @@ #include "qemu/module.h" #include "sysemu/runstate.h" #include "hw/misc/sifive_test.h" +#include "sysemu/sysemu.h" static uint64_t sifive_test_read(void *opaque, hwaddr addr, unsigned int size) { @@ -41,7 +42,8 @@ static void sifive_test_write(void *opaque, hwaddr addr, case FINISHER_FAIL: exit(code); case FINISHER_PASS: - exit(0); + qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); + return; case FINISHER_RESET: qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET); return;
This replaces the exit(0) call by a shutdown request, ensuring a proper cleanup of Qemu. Otherwise, some connections like gdb could be broken without being correctly flushed. Signed-off-by: Clément Chigot <chigot@adacore.com> --- hw/misc/sifive_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)