mbox series

[v2,00/10] libsas: Some tidy-up

Message ID 20230815115156.343535-1-john.g.garry@oracle.com (mailing list archive)
Headers show
Series libsas: Some tidy-up | expand

Message

John Garry Aug. 15, 2023, 11:51 a.m. UTC
This series tidies-up libsas a bit, including:
- delete structure(s) with only one member
- delete structure members which are only ever set
- delete structure members which are never set and code which relies on
  that member being set
  
This conflicts with the following series:
https://lore.kernel.org/linux-scsi/20230809132249.37948-1-yuehaibing@huawei.com/

Any conflict should be trivial to resolve.

Based on mkp-scsi staging at a18e81d17a7e ("scsi: ufs: ufs-pci: Add support for QEMU")

This series is compile tested only.

Differences to v1:
- Add RB tags from Damien and Jason (thanks)
- Set cmd_iu->task_prio = 0 in sci_io_request_build_ssp_command_iu()
  (Damien)

John Garry (10):
  scsi: libsas: Delete sas_ha_struct.lldd_module
  scsi: libsas: Delete enum sas_class
  scsi: libsas: Delete enum sas_phy_type
  scsi: libsas: Delete struct scsi_core
  scsi: libsas: Delete sas_ssp_task.retry_count
  scsi: libsas: Delete sas_ssp_task.enable_first_burst
  scsi: libsas: Delete sas_ssp_task.task_prio
  scsi: libsas: Delete sas_ata_task.set_affil_pol
  scsi: libsas: Delete sas_ata_task.stp_affil_pol
  scsi: libsas: Delete sas_ata_task.retry_count

 drivers/scsi/aic94xx/aic94xx_hwi.c     |  4 +---
 drivers/scsi/aic94xx/aic94xx_init.c    |  7 +++----
 drivers/scsi/aic94xx/aic94xx_task.c    | 12 ++---------
 drivers/scsi/hisi_sas/hisi_sas_main.c  |  9 +++-----
 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c |  9 ++------
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c |  3 +--
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c |  9 ++++----
 drivers/scsi/isci/host.h               |  2 +-
 drivers/scsi/isci/init.c               |  5 ++---
 drivers/scsi/isci/phy.c                |  2 --
 drivers/scsi/isci/request.c            |  2 +-
 drivers/scsi/libsas/sas_ata.c          |  9 ++++----
 drivers/scsi/libsas/sas_discover.c     |  8 +++----
 drivers/scsi/libsas/sas_expander.c     |  2 +-
 drivers/scsi/libsas/sas_host_smp.c     |  4 ++--
 drivers/scsi/libsas/sas_init.c         | 16 +++++++-------
 drivers/scsi/libsas/sas_internal.h     |  1 -
 drivers/scsi/libsas/sas_phy.c          |  8 +++----
 drivers/scsi/libsas/sas_port.c         |  8 +++----
 drivers/scsi/libsas/sas_scsi_host.c    | 15 +++++++------
 drivers/scsi/mvsas/mv_init.c           |  7 ++-----
 drivers/scsi/mvsas/mv_sas.c            |  9 ++------
 drivers/scsi/pm8001/pm8001_hwi.c       |  3 ---
 drivers/scsi/pm8001/pm8001_init.c      |  5 +----
 drivers/scsi/pm8001/pm80xx_hwi.c       |  3 ---
 include/scsi/libsas.h                  | 29 +-------------------------
 26 files changed, 59 insertions(+), 132 deletions(-)

Comments

Martin K. Petersen Aug. 21, 2023, 10:16 p.m. UTC | #1
John,

> This series tidies-up libsas a bit, including:
> - delete structure(s) with only one member
> - delete structure members which are only ever set
> - delete structure members which are never set and code which relies on
>   that member being set

Applied to 6.6/scsi-staging, thanks!
Martin K. Petersen Aug. 25, 2023, 1:12 a.m. UTC | #2
On Tue, 15 Aug 2023 11:51:46 +0000, John Garry wrote:

> This series tidies-up libsas a bit, including:
> - delete structure(s) with only one member
> - delete structure members which are only ever set
> - delete structure members which are never set and code which relies on
>   that member being set
> 
> This conflicts with the following series:
> https://lore.kernel.org/linux-scsi/20230809132249.37948-1-yuehaibing@huawei.com/
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[01/10] scsi: libsas: Delete sas_ha_struct.lldd_module
        https://git.kernel.org/mkp/scsi/c/b1bc49731770
[02/10] scsi: libsas: Delete enum sas_class
        https://git.kernel.org/mkp/scsi/c/c46a91709335
[03/10] scsi: libsas: Delete enum sas_phy_type
        https://git.kernel.org/mkp/scsi/c/2f4e20cd6ef8
[04/10] scsi: libsas: Delete struct scsi_core
        https://git.kernel.org/mkp/scsi/c/1136a0225d05
[05/10] scsi: libsas: Delete sas_ssp_task.retry_count
        https://git.kernel.org/mkp/scsi/c/31d9061b475c
[06/10] scsi: libsas: Delete sas_ssp_task.enable_first_burst
        https://git.kernel.org/mkp/scsi/c/ebf26e93cfec
[07/10] scsi: libsas: Delete sas_ssp_task.task_prio
        https://git.kernel.org/mkp/scsi/c/4dc051eb0c6b
[08/10] scsi: libsas: Delete sas_ata_task.set_affil_pol
        https://git.kernel.org/mkp/scsi/c/7b964c402285
[09/10] scsi: libsas: Delete sas_ata_task.stp_affil_pol
        https://git.kernel.org/mkp/scsi/c/44862dc2d2e7
[10/10] scsi: libsas: Delete sas_ata_task.retry_count
        https://git.kernel.org/mkp/scsi/c/86344494e364
Martin K. Petersen Aug. 31, 2023, 1:48 a.m. UTC | #3
On Tue, 15 Aug 2023 11:51:46 +0000, John Garry wrote:

> This series tidies-up libsas a bit, including:
> - delete structure(s) with only one member
> - delete structure members which are only ever set
> - delete structure members which are never set and code which relies on
>   that member being set
> 
> This conflicts with the following series:
> https://lore.kernel.org/linux-scsi/20230809132249.37948-1-yuehaibing@huawei.com/
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[01/10] scsi: libsas: Delete sas_ha_struct.lldd_module
        https://git.kernel.org/mkp/scsi/c/b1bc49731770
[02/10] scsi: libsas: Delete enum sas_class
        https://git.kernel.org/mkp/scsi/c/c46a91709335
[03/10] scsi: libsas: Delete enum sas_phy_type
        https://git.kernel.org/mkp/scsi/c/2f4e20cd6ef8
[04/10] scsi: libsas: Delete struct scsi_core
        https://git.kernel.org/mkp/scsi/c/1136a0225d05
[05/10] scsi: libsas: Delete sas_ssp_task.retry_count
        https://git.kernel.org/mkp/scsi/c/31d9061b475c
[06/10] scsi: libsas: Delete sas_ssp_task.enable_first_burst
        https://git.kernel.org/mkp/scsi/c/ebf26e93cfec
[07/10] scsi: libsas: Delete sas_ssp_task.task_prio
        https://git.kernel.org/mkp/scsi/c/4dc051eb0c6b
[08/10] scsi: libsas: Delete sas_ata_task.set_affil_pol
        https://git.kernel.org/mkp/scsi/c/7b964c402285
[09/10] scsi: libsas: Delete sas_ata_task.stp_affil_pol
        https://git.kernel.org/mkp/scsi/c/44862dc2d2e7
[10/10] scsi: libsas: Delete sas_ata_task.retry_count
        https://git.kernel.org/mkp/scsi/c/86344494e364