| Message ID | 20230821141923.1889776-1-idosch@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 63c11dc2ca8bf5d8fb85a29db7d23ae083c919df |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] vxlan: vnifilter: Use GFP_KERNEL instead of GFP_ATOMIC | expand |
On Mon, Aug 21, 2023 at 05:19:23PM +0300, Ido Schimmel wrote: > The function is not called from an atomic context so use GFP_KERNEL > instead of GFP_ATOMIC. The allocation of the per-CPU stats is already > performed with GFP_KERNEL. > > Tested using test_vxlan_vnifiltering.sh with CONFIG_DEBUG_ATOMIC_SLEEP. > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Simon Horman <horms@kernel.org>
On Mon, Aug 21, 2023 at 7:51 PM Ido Schimmel <idosch@nvidia.com> wrote: > The function is not called from an atomic context so use GFP_KERNEL > instead of GFP_ATOMIC. The allocation of the per-CPU stats is already > performed with GFP_KERNEL. > > Tested using test_vxlan_vnifiltering.sh with CONFIG_DEBUG_ATOMIC_SLEEP. > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> > --- > drivers/net/vxlan/vxlan_vnifilter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vxlan/vxlan_vnifilter.c > b/drivers/net/vxlan/vxlan_vnifilter.c > index c3ff30ab782e..9c59d0bf8c3d 100644 > --- a/drivers/net/vxlan/vxlan_vnifilter.c > +++ b/drivers/net/vxlan/vxlan_vnifilter.c > @@ -696,7 +696,7 @@ static struct vxlan_vni_node *vxlan_vni_alloc(struct > vxlan_dev *vxlan, > { > struct vxlan_vni_node *vninode; > > - vninode = kzalloc(sizeof(*vninode), GFP_ATOMIC); > + vninode = kzalloc(sizeof(*vninode), GFP_KERNEL); > if (!vninode) > return NULL; > vninode->stats = netdev_alloc_pcpu_stats(struct > vxlan_vni_stats_pcpu); > -- > 2.40.1 > > >
On 8/21/23 17:19, Ido Schimmel wrote: > The function is not called from an atomic context so use GFP_KERNEL > instead of GFP_ATOMIC. The allocation of the per-CPU stats is already > performed with GFP_KERNEL. > > Tested using test_vxlan_vnifiltering.sh with CONFIG_DEBUG_ATOMIC_SLEEP. > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > --- > drivers/net/vxlan/vxlan_vnifilter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vxlan/vxlan_vnifilter.c b/drivers/net/vxlan/vxlan_vnifilter.c > index c3ff30ab782e..9c59d0bf8c3d 100644 > --- a/drivers/net/vxlan/vxlan_vnifilter.c > +++ b/drivers/net/vxlan/vxlan_vnifilter.c > @@ -696,7 +696,7 @@ static struct vxlan_vni_node *vxlan_vni_alloc(struct vxlan_dev *vxlan, > { > struct vxlan_vni_node *vninode; > > - vninode = kzalloc(sizeof(*vninode), GFP_ATOMIC); > + vninode = kzalloc(sizeof(*vninode), GFP_KERNEL); > if (!vninode) > return NULL; > vninode->stats = netdev_alloc_pcpu_stats(struct vxlan_vni_stats_pcpu); Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 21 Aug 2023 17:19:23 +0300 you wrote: > The function is not called from an atomic context so use GFP_KERNEL > instead of GFP_ATOMIC. The allocation of the per-CPU stats is already > performed with GFP_KERNEL. > > Tested using test_vxlan_vnifiltering.sh with CONFIG_DEBUG_ATOMIC_SLEEP. > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > > [...] Here is the summary with links: - [net-next] vxlan: vnifilter: Use GFP_KERNEL instead of GFP_ATOMIC https://git.kernel.org/netdev/net-next/c/63c11dc2ca8b You are awesome, thank you!
diff --git a/drivers/net/vxlan/vxlan_vnifilter.c b/drivers/net/vxlan/vxlan_vnifilter.c index c3ff30ab782e..9c59d0bf8c3d 100644 --- a/drivers/net/vxlan/vxlan_vnifilter.c +++ b/drivers/net/vxlan/vxlan_vnifilter.c @@ -696,7 +696,7 @@ static struct vxlan_vni_node *vxlan_vni_alloc(struct vxlan_dev *vxlan, { struct vxlan_vni_node *vninode; - vninode = kzalloc(sizeof(*vninode), GFP_ATOMIC); + vninode = kzalloc(sizeof(*vninode), GFP_KERNEL); if (!vninode) return NULL; vninode->stats = netdev_alloc_pcpu_stats(struct vxlan_vni_stats_pcpu);
The function is not called from an atomic context so use GFP_KERNEL instead of GFP_ATOMIC. The allocation of the per-CPU stats is already performed with GFP_KERNEL. Tested using test_vxlan_vnifiltering.sh with CONFIG_DEBUG_ATOMIC_SLEEP. Signed-off-by: Ido Schimmel <idosch@nvidia.com> --- drivers/net/vxlan/vxlan_vnifilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)