| Message ID | 20230822135255.1013981-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | watchdog: imx2_wdt: Improve dev_crit() message | expand |
On Tue, Aug 22, 2023 at 10:52:55AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > After issuing a "poweroff" command the board goes through the > expected power-off sequence and turns it off completely: > > systemd-shutdown[1]: Powering off. > imx2-wdt 30280000.watchdog: Device shutdown: Expect reboot! > reboot: Power down > > The "Expect reboot!" message is misleading because in the > power-off case, no reboot is expected to happen at all. > > Avoid the confusion by removing the "Expect reboot!" message. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Not sure if the message should be there in the first place. Anyway, Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/imx2_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c > index 1a27665a2f53..42e8ffae18dd 100644 > --- a/drivers/watchdog/imx2_wdt.c > +++ b/drivers/watchdog/imx2_wdt.c > @@ -374,7 +374,7 @@ static void imx2_wdt_shutdown(struct platform_device *pdev) > */ > imx2_wdt_set_timeout(wdog, IMX2_WDT_MAX_TIME); > imx2_wdt_ping(wdog); > - dev_crit(&pdev->dev, "Device shutdown: Expect reboot!\n"); > + dev_crit(&pdev->dev, "Device shutdown.\n"); > } > } > > -- > 2.34.1 >
diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c index 1a27665a2f53..42e8ffae18dd 100644 --- a/drivers/watchdog/imx2_wdt.c +++ b/drivers/watchdog/imx2_wdt.c @@ -374,7 +374,7 @@ static void imx2_wdt_shutdown(struct platform_device *pdev) */ imx2_wdt_set_timeout(wdog, IMX2_WDT_MAX_TIME); imx2_wdt_ping(wdog); - dev_crit(&pdev->dev, "Device shutdown: Expect reboot!\n"); + dev_crit(&pdev->dev, "Device shutdown.\n"); } }