| Message ID | 20230822142514.2140897-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v1,1/1] platform/x86: p2sb: Make the Kconfig symbol hidden | expand |
Hi, On 8/22/23 16:25, Andy Shevchenko wrote: > The P2SB is used purely as a library and all users must select it with > > depends on PCI > select P2SB if X86 > > statement. Without this the combination of different configuration > options may lead to build failures. > > Suggested-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 228fadb1c037..06b9a5ae5a63 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1102,7 +1102,7 @@ config SEL3350_PLATFORM > endif # X86_PLATFORM_DEVICES > > config P2SB > - bool "Primary to Sideband (P2SB) bridge access support" > + bool > depends on PCI && X86 > help > The Primary to Sideband (P2SB) bridge is an interface to some
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 228fadb1c037..06b9a5ae5a63 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1102,7 +1102,7 @@ config SEL3350_PLATFORM endif # X86_PLATFORM_DEVICES config P2SB - bool "Primary to Sideband (P2SB) bridge access support" + bool depends on PCI && X86 help The Primary to Sideband (P2SB) bridge is an interface to some
The P2SB is used purely as a library and all users must select it with depends on PCI select P2SB if X86 statement. Without this the combination of different configuration options may lead to build failures. Suggested-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)