| Message ID | 20230822180054.v5.2.I8f20fdfe34a2e8a38373bbd65587754b324f3dcb@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add no-esim sku for sc7180-lazor family and new board version for audio codec ALC5682i-VS | expand |
Hi, On Tue, Aug 22, 2023 at 3:04 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0) > SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0) > SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0) > > Even though the "no esim" boards are strapped differently than > ones that have an esim, the esim isn't represented in the > device tree so the same device tree can be used for LTE w/ esim > and LTE w/out esim. > > add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- You should add a note here ("after the cut", in other words after the "---" above but before your changelog) explaining that your patch absolutely requires my patch [1] in order to compile. Please provide a link to my patch (AKA include link [1]), too. I _think_ that maybe you're using "patman" to format your patch? If so then this would be done using "Commit-notes:". Maintainers have a lot of patches to apply and we need to make it really easy for them to figure out what order they need to apply patches in and which patches depend on others. [1] https://lore.kernel.org/r/20230816112143.1.I7227efd47e0dc42b6ff243bd22aa1a3e01923220@changeid/ > Changes in v5: > - include rt5682s node for new board version 10 This isn't quite what you did in v5. I would say: - rebased on patch moving rt5682s to a fragment > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts > index 1c4f0773a242..cabe99c23a7c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts > @@ -14,8 +14,8 @@ > #include "sc7180-lite.dtsi" > > / { > - model = "Google Lazor (rev9+) with KB Backlight"; > - compatible = "google,lazor-sku2", "qcom,sc7180"; > + model = "Google Lazor (rev9) with KB Backlight"; > + compatible = "google,lazor-rev9-sku2", "qcom,sc7180";; nit: the above line has two ";". Remove one. IMO this is something you should spin a quick v6 for. Once that's fixed: Reviewed-by: Douglas Anderson <dianders@chromium.org>
On 22.08.2023 12:03, Sheng-Liang Pan wrote: > SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0) > SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0) > SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0) > > Even though the "no esim" boards are strapped differently than > ones that have an esim, the esim isn't represented in the > device tree so the same device tree can be used for LTE w/ esim > and LTE w/out esim. > > add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- Minor style nits since Doug already suggested a v6: - please add a space between /delete-node/ and the &reference after it - keep properties (e.g. pinctrl-) like this: property-n property-names Konrad
Hi > On 22.08.2023 12:03, Sheng-Liang Pan wrote: >> SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0) >> SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0) >> SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0) >> >> Even though the "no esim" boards are strapped differently than >> ones that have an esim, the esim isn't represented in the >> device tree so the same device tree can be used for LTE w/ esim >> and LTE w/out esim. >> >> add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS >> >> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> >> --- > Minor style nits since Doug already suggested a v6: > > - please add a space between /delete-node/ and the &reference after it > - keep properties (e.g. pinctrl-) like this: > property-n > property-names > > Konrad > Patch v6 [1] fix it. [1] https://lore.kernel.org/all/20230823151005.v6.2.I8f20fdfe34a2e8a38373bbd65587754b324f3dcb@changeid/
Hi > Hi, > > On Tue, Aug 22, 2023 at 3:04 AM Sheng-Liang Pan > <sheng-liang.pan@quanta.corp-partner.google.com> wrote: >> SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0) >> SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0) >> SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0) >> >> Even though the "no esim" boards are strapped differently than >> ones that have an esim, the esim isn't represented in the >> device tree so the same device tree can be used for LTE w/ esim >> and LTE w/out esim. >> >> add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS >> >> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> >> --- > You should add a note here ("after the cut", in other words after the > "---" above but before your changelog) explaining that your patch > absolutely requires my patch [1] in order to compile. Please provide a > link to my patch (AKA include link [1]), too. I _think_ that maybe > you're using "patman" to format your patch? If so then this would be > done using "Commit-notes:". Maintainers have a lot of patches to apply > and we need to make it really easy for them to figure out what order > they need to apply patches in and which patches depend on others. > > [1] https://lore.kernel.org/r/20230816112143.1.I7227efd47e0dc42b6ff243bd22aa1a3e01923220@changeid/ > Patch v6 add dependent patch link. >> Changes in v5: >> - include rt5682s node for new board version 10 > This isn't quite what you did in v5. I would say: > - rebased on patch moving rt5682s to a fragment > done. > >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts >> index 1c4f0773a242..cabe99c23a7c 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts >> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts >> @@ -14,8 +14,8 @@ >> #include "sc7180-lite.dtsi" >> >> / { >> - model = "Google Lazor (rev9+) with KB Backlight"; >> - compatible = "google,lazor-sku2", "qcom,sc7180"; >> + model = "Google Lazor (rev9) with KB Backlight"; >> + compatible = "google,lazor-rev9-sku2", "qcom,sc7180";; > nit: the above line has two ";". Remove one. > > IMO this is something you should spin a quick v6 for. Once that's fixed: > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > done. Reviewed-by: Douglas Anderson <dianders@chromium.org> Sheng-Liang
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 337abc4ceb17..73e745fb1ff0 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -109,11 +109,16 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r3-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r9.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r9-kb.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r9-lte.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r10.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r10-kb.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r10-lte.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-r4.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-r9.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-r10.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots-r4.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots-r5.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots-r9.dtb +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-limozeen-nots-r10.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-lte-parade.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-lte-ti.dtb dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-parade.dtb diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r10.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r10.dts new file mode 100644 index 000000000000..943f267a5586 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r10.dts @@ -0,0 +1,29 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Lazor Limozeen board device tree source + * + * Copyright 2023 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor.dtsi" +#include "sc7180-trogdor-parade-ps8640.dtsi" +#include "sc7180-trogdor-lazor.dtsi" +#include "sc7180-trogdor-lte-sku.dtsi" +#include "sc7180-trogdor-rt5682s-sku.dtsi" + +/ { + model = "Google Lazor Limozeen without Touchscreen (rev10+)"; + compatible = "google,lazor-sku6", "google,lazor-sku18", "qcom,sc7180"; +}; + +/delete-node/&ap_ts; + +&panel { + compatible = "edp-panel"; +}; + +&sdhc_2 { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts index 400f9e18977f..88451935174e 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts @@ -14,8 +14,8 @@ #include "sc7180-trogdor-rt5682i-sku.dtsi" / { - model = "Google Lazor Limozeen without Touchscreen (rev9+)"; - compatible = "google,lazor-sku6", "qcom,sc7180"; + model = "Google Lazor Limozeen without Touchscreen (rev9)"; + compatible = "google,lazor-rev9-sku6", "google,lazor-rev9-sku18", "qcom,sc7180"; }; /delete-node/&ap_ts; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r10.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r10.dts new file mode 100644 index 000000000000..d77376892f20 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r10.dts @@ -0,0 +1,45 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Lazor Limozeen board device tree source + * + * Copyright 2023 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor.dtsi" +#include "sc7180-trogdor-parade-ps8640.dtsi" +#include "sc7180-trogdor-lazor.dtsi" +#include "sc7180-trogdor-lte-sku.dtsi" +#include "sc7180-trogdor-rt5682s-sku.dtsi" + +/ { + model = "Google Lazor Limozeen (rev10+)"; + compatible = "google,lazor-sku4", "google,lazor-sku15", "qcom,sc7180"; +}; + +/delete-node/&ap_ts; + +&ap_ts_pen_1v8 { + ap_ts: touchscreen@10 { + compatible = "elan,ekth3500"; + reg = <0x10>; + pinctrl-names = "default"; + pinctrl-0 = <&ts_int_l>, <&ts_reset_l>; + + interrupt-parent = <&tlmm>; + interrupts = <9 IRQ_TYPE_LEVEL_LOW>; + + vcc33-supply = <&pp3300_ts>; + + reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>; + }; +}; + +&panel { + compatible = "auo,b116xa01"; +}; + +&sdhc_2 { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dts index 09a4ff13f072..76a76b8c0268 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dts @@ -14,8 +14,8 @@ #include "sc7180-trogdor-rt5682i-sku.dtsi" / { - model = "Google Lazor Limozeen (rev9+)"; - compatible = "google,lazor-sku4", "qcom,sc7180"; + model = "Google Lazor Limozeen (rev9)"; + compatible = "google,lazor-rev9-sku4", "google,lazor-rev9-sku15", "qcom,sc7180"; }; /delete-node/&ap_ts; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-kb.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-kb.dts new file mode 100644 index 000000000000..45d34718a1bc --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-kb.dts @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Lazor board device tree source + * + * Copyright 2023 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor.dtsi" +#include "sc7180-trogdor-parade-ps8640.dtsi" +#include "sc7180-trogdor-lazor.dtsi" +#include "sc7180-lite.dtsi" +#include "sc7180-trogdor-rt5682s-sku.dtsi" + +/ { + model = "Google Lazor (rev10+) with KB Backlight"; + compatible = "google,lazor-sku2", "qcom,sc7180"; +}; + +&keyboard_backlight { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-lte.dts new file mode 100644 index 000000000000..79028d0dd1b0 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-lte.dts @@ -0,0 +1,27 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Lazor board device tree source + * + * Copyright 2023 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor.dtsi" +#include "sc7180-trogdor-parade-ps8640.dtsi" +#include "sc7180-trogdor-lazor.dtsi" +#include "sc7180-trogdor-lte-sku.dtsi" +#include "sc7180-trogdor-rt5682s-sku.dtsi" + +/ { + model = "Google Lazor (rev10+) with LTE"; + compatible = "google,lazor-sku0", "google,lazor-sku10", "qcom,sc7180"; +}; + +&ap_sar_sensor_i2c { + status = "okay"; +}; + +&keyboard_backlight { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dts new file mode 100644 index 000000000000..045827341ea0 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dts @@ -0,0 +1,19 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Google Lazor board device tree source + * + * Copyright 2023 Google LLC. + */ + +/dts-v1/; + +#include "sc7180-trogdor.dtsi" +#include "sc7180-trogdor-parade-ps8640.dtsi" +#include "sc7180-trogdor-lazor.dtsi" +#include "sc7180-lite.dtsi" +#include "sc7180-trogdor-rt5682s-sku.dtsi" + +/ { + model = "Google Lazor (rev10+)"; + compatible = "google,lazor", "qcom,sc7180"; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts index 1c4f0773a242..cabe99c23a7c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dts @@ -14,8 +14,8 @@ #include "sc7180-lite.dtsi" / { - model = "Google Lazor (rev9+) with KB Backlight"; - compatible = "google,lazor-sku2", "qcom,sc7180"; + model = "Google Lazor (rev9) with KB Backlight"; + compatible = "google,lazor-rev9-sku2", "qcom,sc7180";; }; &keyboard_backlight { diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts index ec73943abc4c..d737fd0637fb 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts @@ -14,8 +14,8 @@ #include "sc7180-trogdor-rt5682i-sku.dtsi" / { - model = "Google Lazor (rev9+) with LTE"; - compatible = "google,lazor-sku0", "qcom,sc7180"; + model = "Google Lazor (rev9) with LTE"; + compatible = "google,lazor-rev9-sku0", "google,lazor-rev9-sku10", "qcom,sc7180"; }; &ap_sar_sensor_i2c { diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dts index 6cedc0ba9653..8daad32ff53b 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dts @@ -14,6 +14,6 @@ #include "sc7180-lite.dtsi" / { - model = "Google Lazor (rev9+)"; - compatible = "google,lazor", "qcom,sc7180"; + model = "Google Lazor (rev9)"; + compatible = "google,lazor-rev9", "qcom,sc7180"; };
SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0) SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0) SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0) Even though the "no esim" boards are strapped differently than ones that have an esim, the esim isn't represented in the device tree so the same device tree can be used for LTE w/ esim and LTE w/out esim. add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> --- Changes in v5: - include rt5682s node for new board version 10 Changes in v4: - combine pathc2 and patch3 Changes in v3: - sort out the node order alphabetically Changes in v2: - add new entry rev9 with Parade bridge chip - correct newly create dts files arch/arm64/boot/dts/qcom/Makefile | 5 +++ ...sc7180-trogdor-lazor-limozeen-nots-r10.dts | 29 ++++++++++++ .../sc7180-trogdor-lazor-limozeen-nots-r9.dts | 4 +- .../sc7180-trogdor-lazor-limozeen-r10.dts | 45 +++++++++++++++++++ .../qcom/sc7180-trogdor-lazor-limozeen-r9.dts | 4 +- .../dts/qcom/sc7180-trogdor-lazor-r10-kb.dts | 23 ++++++++++ .../dts/qcom/sc7180-trogdor-lazor-r10-lte.dts | 27 +++++++++++ .../dts/qcom/sc7180-trogdor-lazor-r10.dts | 19 ++++++++ .../dts/qcom/sc7180-trogdor-lazor-r9-kb.dts | 4 +- .../dts/qcom/sc7180-trogdor-lazor-r9-lte.dts | 4 +- .../boot/dts/qcom/sc7180-trogdor-lazor-r9.dts | 4 +- 11 files changed, 158 insertions(+), 10 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r10.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r10.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-kb.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-lte.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dts