diff mbox series

[v4,1/2] dt-bindings: arm: qcom: add sc7180-lazor board bindings

Message ID 20230822174101.v4.1.I26e017b00a341e7a5a2e94a83596923713408817@changeid (mailing list archive)
State Superseded
Headers show
Series Add no-esim sku for sc7180-lazor family and new board version for audio codec ALC5682i-VS | expand

Commit Message

Sheng-Liang Pan Aug. 22, 2023, 9:44 a.m. UTC 
Introduce more sc7180-lazor sku and board version configuration,
add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
add new board version 10 for audio codec ALC5682i-VS.

Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---

Changes in v3:
- correct corresponding of new board and new sku

Changes in v2:
- add new entry rev9 with Parade bridge chip
- correct newly create dts files

 .../devicetree/bindings/arm/qcom.yaml         | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)

Comments

Conor Dooley Aug. 23, 2023, 3:11 p.m. UTC | #1 
On Tue, Aug 22, 2023 at 05:44:13PM +0800, Sheng-Liang Pan wrote:
> Introduce more sc7180-lazor sku and board version configuration,
> add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> add new board version 10 for audio codec ALC5682i-VS.
> 
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Doug Anderson Aug. 23, 2023, 5:17 p.m. UTC | #2 
Hi,

On Wed, Aug 23, 2023 at 8:11 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Tue, Aug 22, 2023 at 05:44:13PM +0800, Sheng-Liang Pan wrote:
> > Introduce more sc7180-lazor sku and board version configuration,
> > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> > add new board version 10 for audio codec ALC5682i-VS.
> >
> > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> > Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Conor: any chance you could reply to v6 (instead of v4) and add your Ack?

https://lore.kernel.org/all/20230823151005.v6.1.I26e017b00a341e7a5a2e94a83596923713408817@changeid/

I _think_ the v6 patch series is in good shape so I don't expect
Sheng-Liang to have to send a v7. I'm worried that your Ack will be
lost if it's not sent in response to the v6 patch.

Thanks!

-Doug
Conor Dooley Aug. 23, 2023, 6:29 p.m. UTC | #3 
On Wed, Aug 23, 2023 at 10:17:17AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Wed, Aug 23, 2023 at 8:11 AM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Tue, Aug 22, 2023 at 05:44:13PM +0800, Sheng-Liang Pan wrote:
> > > Introduce more sc7180-lazor sku and board version configuration,
> > > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> > > add new board version 10 for audio codec ALC5682i-VS.
> > >
> > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Conor: any chance you could reply to v6 (instead of v4) and add your Ack?

People need to relax! This seems only to have been sent yesterday?!?

> https://lore.kernel.org/all/20230823151005.v6.1.I26e017b00a341e7a5a2e94a83596923713408817@changeid/
> 
> I _think_ the v6 patch series is in good shape so I don't expect
> Sheng-Liang to have to send a v7. I'm worried that your Ack will be
> lost if it's not sent in response to the v6 patch.
`
Conor Dooley Aug. 23, 2023, 6:32 p.m. UTC | #4 
On Wed, Aug 23, 2023 at 07:29:33PM +0100, Conor Dooley wrote:
> On Wed, Aug 23, 2023 at 10:17:17AM -0700, Doug Anderson wrote:
> > Hi,
> > 
> > On Wed, Aug 23, 2023 at 8:11 AM Conor Dooley <conor@kernel.org> wrote:
> > >
> > > On Tue, Aug 22, 2023 at 05:44:13PM +0800, Sheng-Liang Pan wrote:
> > > > Introduce more sc7180-lazor sku and board version configuration,
> > > > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> > > > add new board version 10 for audio codec ALC5682i-VS.
> > > >
> > > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> > > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
> > >
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > 
> > Conor: any chance you could reply to v6 (instead of v4) and add your Ack?
> 
> People need to relax! This seems only to have been sent yesterday?!?
> 
> > https://lore.kernel.org/all/20230823151005.v6.1.I26e017b00a341e7a5a2e94a83596923713408817@changeid/
> > 
> > I _think_ the v6 patch series is in good shape so I don't expect
> > Sheng-Liang to have to send a v7. I'm worried that your Ack will be
> > lost if it's not sent in response to the v6 patch.

And I must have deleted the v6 w/o reading even really reading it as it
has an R-b from Krzysztof. My ack is therefore not needed anyway, so who
cares if it gets lost :)
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 450f616774e0..3da04223b03f 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -470,6 +470,11 @@  properties:
           - const: google,lazor-rev8
           - const: qcom,sc7180
 
+      - description: Acer Chromebook Spin 513 (rev9)
+        items:
+          - const: google,lazor-rev9
+          - const: qcom,sc7180
+
       - description: Acer Chromebook Spin 513 (newest rev)
         items:
           - const: google,lazor
@@ -491,6 +496,11 @@  properties:
           - const: google,lazor-rev8-sku2
           - const: qcom,sc7180
 
+      - description: Acer Chromebook Spin 513 with KB Backlight (rev9)
+        items:
+          - const: google,lazor-rev9-sku2
+          - const: qcom,sc7180
+
       - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
         items:
           - const: google,lazor-sku2
@@ -512,9 +522,16 @@  properties:
           - const: google,lazor-rev8-sku0
           - const: qcom,sc7180
 
+      - description: Acer Chromebook Spin 513 with LTE (rev9)
+        items:
+          - const: google,lazor-rev9-sku0
+          - const: google,lazor-rev9-sku10
+          - const: qcom,sc7180
+
       - description: Acer Chromebook Spin 513 with LTE (newest rev)
         items:
           - const: google,lazor-sku0
+          - const: google,lazor-sku10
           - const: qcom,sc7180
 
       - description: Acer Chromebook 511 (rev4 - rev8)
@@ -526,9 +543,16 @@  properties:
           - const: google,lazor-rev8-sku4
           - const: qcom,sc7180
 
+      - description: Acer Chromebook 511 (rev9)
+        items:
+          - const: google,lazor-rev9-sku4
+          - const: google,lazor-rev9-sku15
+          - const: qcom,sc7180
+
       - description: Acer Chromebook 511 (newest rev)
         items:
           - const: google,lazor-sku4
+          - const: google,lazor-sku15
           - const: qcom,sc7180
 
       - description: Acer Chromebook 511 without Touchscreen (rev4)
@@ -545,9 +569,16 @@  properties:
           - const: google,lazor-rev8-sku6
           - const: qcom,sc7180
 
+      - description: Acer Chromebook 511 without Touchscreen (rev9)
+        items:
+          - const: google,lazor-rev9-sku6
+          - const: google,lazor-rev9-sku18
+          - const: qcom,sc7180
+
       - description: Acer Chromebook 511 without Touchscreen (newest rev)
         items:
           - const: google,lazor-sku6
+          - const: google,lazor-sku18
           - const: qcom,sc7180
 
       - description: Google Mrbland with AUO panel (rev0)