| Message ID | 20230823231059.3363698-8-pulehui@huaweicloud.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | Add support cpu v4 insns for RV64 | expand |
On 8/23/23 4:10 PM, Pu Lehui wrote: > From: Pu Lehui <pulehui@huawei.com> > > Enable cpu v4 tests for RV64, and the relevant tests have passed. > > Signed-off-by: Pu Lehui <pulehui@huawei.com> Thanks for working on this! Acked-by: Yonghong Song <yonghong.song@linux.dev> > --- > tools/testing/selftests/bpf/progs/test_ldsx_insn.c | 3 ++- > tools/testing/selftests/bpf/progs/verifier_bswap.c | 3 ++- > tools/testing/selftests/bpf/progs/verifier_gotol.c | 3 ++- > tools/testing/selftests/bpf/progs/verifier_ldsx.c | 3 ++- > tools/testing/selftests/bpf/progs/verifier_movsx.c | 3 ++- > tools/testing/selftests/bpf/progs/verifier_sdiv.c | 3 ++- > 6 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c > index 916d9435f12c..67c14ba1e87b 100644 > --- a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c > +++ b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c > @@ -5,7 +5,8 @@ > #include <bpf/bpf_helpers.h> > #include <bpf/bpf_tracing.h> > > -#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && __clang_major__ >= 18 > +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ > + (defined(__TARGET_ARCH_riscv) && __riscv_xlen == 64)) && __clang_major__ >= 18 > const volatile int skip = 0; > #else > const volatile int skip = 1; [...]
Pu Lehui <pulehui@huaweicloud.com> writes: > From: Pu Lehui <pulehui@huawei.com> > > Enable cpu v4 tests for RV64, and the relevant tests have passed. > > Signed-off-by: Pu Lehui <pulehui@huawei.com> Acked-by: Björn Töpel <bjorn@kernel.org>
On Wed, Aug 23, 2023 at 11:25 AM Björn Töpel <bjorn@kernel.org> wrote: > > Pu Lehui <pulehui@huaweicloud.com> writes: > > > From: Pu Lehui <pulehui@huawei.com> > > > > Enable cpu v4 tests for RV64, and the relevant tests have passed. > > > > Signed-off-by: Pu Lehui <pulehui@huawei.com> > > Acked-by: Björn Töpel <bjorn@kernel.org> Bjorn, Thanks a lot for the quick review! Could you give it a spin as well and hopefully add Tested-by ? We still have time to get it into bpf-next for the upcoming merge window.
Alexei Starovoitov <alexei.starovoitov@gmail.com> writes: > On Wed, Aug 23, 2023 at 11:25 AM Björn Töpel <bjorn@kernel.org> wrote: >> >> Pu Lehui <pulehui@huaweicloud.com> writes: >> >> > From: Pu Lehui <pulehui@huawei.com> >> > >> > Enable cpu v4 tests for RV64, and the relevant tests have passed. >> > >> > Signed-off-by: Pu Lehui <pulehui@huawei.com> >> >> Acked-by: Björn Töpel <bjorn@kernel.org> > > Bjorn, > > Thanks a lot for the quick review! > Could you give it a spin as well and hopefully add Tested-by ? > > We still have time to get it into bpf-next for the upcoming merge window. I'll kick a run! But I'd like a change to mov 8/16b patch (#3) prior pulling. > We still have time to get it into bpf-next for the upcoming merge window. @Lehui Do you have time to cook a v2? Björn
On 2023/8/24 3:50, Björn Töpel wrote: > Alexei Starovoitov <alexei.starovoitov@gmail.com> writes: > >> On Wed, Aug 23, 2023 at 11:25 AM Björn Töpel <bjorn@kernel.org> wrote: >>> >>> Pu Lehui <pulehui@huaweicloud.com> writes: >>> >>>> From: Pu Lehui <pulehui@huawei.com> >>>> >>>> Enable cpu v4 tests for RV64, and the relevant tests have passed. >>>> >>>> Signed-off-by: Pu Lehui <pulehui@huawei.com> >>> >>> Acked-by: Björn Töpel <bjorn@kernel.org> >> >> Bjorn, >> >> Thanks a lot for the quick review! >> Could you give it a spin as well and hopefully add Tested-by ? >> >> We still have time to get it into bpf-next for the upcoming merge window. > > I'll kick a run! But I'd like a change to mov 8/16b patch (#3) prior > pulling. > >> We still have time to get it into bpf-next for the upcoming merge window. > > @Lehui Do you have time to cook a v2? Sorry guys for the late reply due to sleep. V2 is ready and will send soon. > > > Björn
diff --git a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c index 916d9435f12c..67c14ba1e87b 100644 --- a/tools/testing/selftests/bpf/progs/test_ldsx_insn.c +++ b/tools/testing/selftests/bpf/progs/test_ldsx_insn.c @@ -5,7 +5,8 @@ #include <bpf/bpf_helpers.h> #include <bpf/bpf_tracing.h> -#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && __clang_major__ >= 18 +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen == 64)) && __clang_major__ >= 18 const volatile int skip = 0; #else const volatile int skip = 1; diff --git a/tools/testing/selftests/bpf/progs/verifier_bswap.c b/tools/testing/selftests/bpf/progs/verifier_bswap.c index 770f9d882542..8893094725f0 100644 --- a/tools/testing/selftests/bpf/progs/verifier_bswap.c +++ b/tools/testing/selftests/bpf/progs/verifier_bswap.c @@ -4,7 +4,8 @@ #include <bpf/bpf_helpers.h> #include "bpf_misc.h" -#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && __clang_major__ >= 18 +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen == 64)) && __clang_major__ >= 18 SEC("socket") __description("BSWAP, 16") diff --git a/tools/testing/selftests/bpf/progs/verifier_gotol.c b/tools/testing/selftests/bpf/progs/verifier_gotol.c index 17319a505e87..2dae5322a18e 100644 --- a/tools/testing/selftests/bpf/progs/verifier_gotol.c +++ b/tools/testing/selftests/bpf/progs/verifier_gotol.c @@ -4,7 +4,8 @@ #include <bpf/bpf_helpers.h> #include "bpf_misc.h" -#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && __clang_major__ >= 18 +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen == 64)) && __clang_major__ >= 18 SEC("socket") __description("gotol, small_imm") diff --git a/tools/testing/selftests/bpf/progs/verifier_ldsx.c b/tools/testing/selftests/bpf/progs/verifier_ldsx.c index 4a2b567c0f69..0c638f45aaf1 100644 --- a/tools/testing/selftests/bpf/progs/verifier_ldsx.c +++ b/tools/testing/selftests/bpf/progs/verifier_ldsx.c @@ -4,7 +4,8 @@ #include <bpf/bpf_helpers.h> #include "bpf_misc.h" -#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && __clang_major__ >= 18 +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen == 64)) && __clang_major__ >= 18 SEC("socket") __description("LDSX, S8") diff --git a/tools/testing/selftests/bpf/progs/verifier_movsx.c b/tools/testing/selftests/bpf/progs/verifier_movsx.c index d9528d578bd9..3c8ac2c57b1b 100644 --- a/tools/testing/selftests/bpf/progs/verifier_movsx.c +++ b/tools/testing/selftests/bpf/progs/verifier_movsx.c @@ -4,7 +4,8 @@ #include <bpf/bpf_helpers.h> #include "bpf_misc.h" -#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && __clang_major__ >= 18 +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen == 64)) && __clang_major__ >= 18 SEC("socket") __description("MOV32SX, S8") diff --git a/tools/testing/selftests/bpf/progs/verifier_sdiv.c b/tools/testing/selftests/bpf/progs/verifier_sdiv.c index fa3945930e93..0990f8825675 100644 --- a/tools/testing/selftests/bpf/progs/verifier_sdiv.c +++ b/tools/testing/selftests/bpf/progs/verifier_sdiv.c @@ -4,7 +4,8 @@ #include <bpf/bpf_helpers.h> #include "bpf_misc.h" -#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86)) && __clang_major__ >= 18 +#if (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen == 64)) && __clang_major__ >= 18 SEC("socket") __description("SDIV32, non-zero imm divisor, check 1")