| Message ID | 20230802064100.15793-1-mike.looijmans@topic.nl (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/3] clk: lmk04832: Set missing parent_names for output clocks | expand |
On Wed, Aug 02, 2023 at 08:40:58AM +0200, Mike Looijmans wrote: > lmk04832_register_clkout forgot to fill in the parent_names, resulting > in the error message "Must specify parents if num_parents > 0". > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> Reviewed-by: Liam Beguin <liambeguin@gmail.com> > --- > drivers/clk/clk-lmk04832.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c > index e22ac93e0c2f..188085e7a30b 100644 > --- a/drivers/clk/clk-lmk04832.c > +++ b/drivers/clk/clk-lmk04832.c > @@ -1297,6 +1297,7 @@ static int lmk04832_register_clkout(struct lmk04832 *lmk, const int num) > sprintf(dclk_name, "lmk-dclk%02d_%02d", num, num + 1); > init.name = dclk_name; > parent_names[0] = clk_hw_get_name(&lmk->vco); > + init.parent_names = parent_names; > init.ops = &lmk04832_dclk_ops; > init.flags = CLK_SET_RATE_PARENT; > init.num_parents = 1; > -- > 2.17.1 > > > Met vriendelijke groet / kind regards, > > Mike Looijmans > System Expert > > > TOPIC Embedded Products B.V. > Materiaalweg 4, 5681 RJ Best > The Netherlands > > T: +31 (0) 499 33 69 69 > E: mike.looijmans@topicproducts.com > W: www.topic.nl > > Please consider the environment before printing this e-mail
Quoting Mike Looijmans (2023-08-01 23:40:58) > lmk04832_register_clkout forgot to fill in the parent_names, resulting > in the error message "Must specify parents if num_parents > 0". > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- Applied to clk-next
diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c index e22ac93e0c2f..188085e7a30b 100644 --- a/drivers/clk/clk-lmk04832.c +++ b/drivers/clk/clk-lmk04832.c @@ -1297,6 +1297,7 @@ static int lmk04832_register_clkout(struct lmk04832 *lmk, const int num) sprintf(dclk_name, "lmk-dclk%02d_%02d", num, num + 1); init.name = dclk_name; parent_names[0] = clk_hw_get_name(&lmk->vco); + init.parent_names = parent_names; init.ops = &lmk04832_dclk_ops; init.flags = CLK_SET_RATE_PARENT; init.num_parents = 1;
lmk04832_register_clkout forgot to fill in the parent_names, resulting in the error message "Must specify parents if num_parents > 0". Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- drivers/clk/clk-lmk04832.c | 1 + 1 file changed, 1 insertion(+)