diff mbox series

[V2,6/6] arm64: dts: add support for T7 power domain controller

Message ID 20230824055930.2576849-7-xianwei.zhao@amlogic.com (mailing list archive)
State New, archived
Headers show
Series Power: T7: add power domain driver | expand

Commit Message

Xianwei Zhao Aug. 24, 2023, 5:59 a.m. UTC 
From: "xianwei.zhao" <xianwei.zhao@amlogic.com>

Enable power domain controller for Amlogic T7 SoC

Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
---
V1 -> V2: None
---
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Neil Armstrong Aug. 24, 2023, 8:32 a.m. UTC | #1 
On 24/08/2023 07:59, Xianwei Zhao wrote:
> From: "xianwei.zhao" <xianwei.zhao@amlogic.com>
> 
> Enable power domain controller for Amlogic T7 SoC
> 
> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
> ---
> V1 -> V2: None
> ---
>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> index 1423d4a79156..23cdad1b425b 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> @@ -4,6 +4,7 @@
>    */
>   
>   #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/power/amlogic,t7-pwrc.h>
>   
>   / {
>   	interrupt-parent = <&gic>;
> @@ -118,6 +119,11 @@ psci {
>   
>   	sm: secure-monitor {
>   		compatible = "amlogic,meson-gxbb-sm";
> +
> +		pwrc: power-controller {
> +			compatible = "amlogic,t7-pwrc";
> +			#power-domain-cells = <1>;
> +		};
>   	};
>   
>   	soc {

Please change the subject to:
arm64: dts: amlogic: t7: add power domain controller node

With that:
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Xianwei Zhao Aug. 24, 2023, 8:51 a.m. UTC | #2 
Hi Neil,
     Thanks for your reply.

On 2023/8/24 16:32, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
> 
> On 24/08/2023 07:59, Xianwei Zhao wrote:
>> From: "xianwei.zhao" <xianwei.zhao@amlogic.com>
>>
>> Enable power domain controller for Amlogic T7 SoC
>>
>> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
>> ---
>> V1 -> V2: None
>> ---
>>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi 
>> b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> index 1423d4a79156..23cdad1b425b 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> @@ -4,6 +4,7 @@
>>    */
>>
>>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/power/amlogic,t7-pwrc.h>
>>
>>   / {
>>       interrupt-parent = <&gic>;
>> @@ -118,6 +119,11 @@ psci {
>>
>>       sm: secure-monitor {
>>               compatible = "amlogic,meson-gxbb-sm";
>> +
>> +             pwrc: power-controller {
>> +                     compatible = "amlogic,t7-pwrc";
>> +                     #power-domain-cells = <1>;
>> +             };
>>       };
>>
>>       soc {
> 
> Please change the subject to:
> arm64: dts: amlogic: t7: add power domain controller node
> 
Will do.
> With that:
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Lucas Tanure Aug. 26, 2023, 5:59 p.m. UTC | #3 
On 24-08-2023 09:51, Xianwei Zhao wrote:
> Hi Neil,
>     Thanks for your reply.
>
> On 2023/8/24 16:32, Neil Armstrong wrote:
>> [ EXTERNAL EMAIL ]
>>
>> On 24/08/2023 07:59, Xianwei Zhao wrote:
>>> From: "xianwei.zhao" <xianwei.zhao@amlogic.com>
>>>
>>> Enable power domain controller for Amlogic T7 SoC
>>>
>>> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
>>> ---
>>> V1 -> V2: None
>>> ---
>>>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi 
>>> b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>>> index 1423d4a79156..23cdad1b425b 100644
>>> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>>> @@ -4,6 +4,7 @@
>>>    */
>>>
>>>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +#include <dt-bindings/power/amlogic,t7-pwrc.h>
>>>
>>>   / {
>>>       interrupt-parent = <&gic>;
>>> @@ -118,6 +119,11 @@ psci {
>>>
>>>       sm: secure-monitor {
>>>               compatible = "amlogic,meson-gxbb-sm";
>>> +
>>> +             pwrc: power-controller {
>>> +                     compatible = "amlogic,t7-pwrc";
>>> +                     #power-domain-cells = <1>;
>>> +             };
>>>       };
>>>
>>>       soc {
>>
>> Please change the subject to:
>> arm64: dts: amlogic: t7: add power domain controller node
>>
> Will do.
>> With that:
>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Tested with Vim4 and all works fine.

Tested-by: Lucas Tanure <tanure@linux.com>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
index 1423d4a79156..23cdad1b425b 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
@@ -4,6 +4,7 @@ 
  */
 
 #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/power/amlogic,t7-pwrc.h>
 
 / {
 	interrupt-parent = <&gic>;
@@ -118,6 +119,11 @@  psci {
 
 	sm: secure-monitor {
 		compatible = "amlogic,meson-gxbb-sm";
+
+		pwrc: power-controller {
+			compatible = "amlogic,t7-pwrc";
+			#power-domain-cells = <1>;
+		};
 	};
 
 	soc {