| Message ID | 20230824080517.693621-20-imre.deak@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Improve BW management on shared display links | expand |
On Thu, Aug 24, 2023 at 11:05:14AM +0300, Imre Deak wrote: > Add the missing DSC compression disabling step for MST streams, > similarly to how this is done for SST outputs. > > Signed-off-by: Imre Deak <imre.deak@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index b6a717566e7c8..5eaf309f852f2 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -656,6 +656,8 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state, > > intel_ddi_disable_transcoder_func(old_crtc_state); > > + intel_dsc_disable(old_crtc_state); > + One thing that a bit I'm a bit concerned is that whether won't it conflict with that intel_ddi_post_disable hook called for the last mst stream? I see that it also calls intel_dsc_disable, however there is !mst check first, however for Bigjoiner case, there is no such check. Wondering should we add it there?.. > if (DISPLAY_VER(dev_priv) >= 9) > skl_scaler_disable(old_crtc_state); > else > -- > 2.37.2 >
On Thu, Aug 24, 2023 at 12:44:16PM +0300, Lisovskiy, Stanislav wrote: > On Thu, Aug 24, 2023 at 11:05:14AM +0300, Imre Deak wrote: > > Add the missing DSC compression disabling step for MST streams, > > similarly to how this is done for SST outputs. > > > > Signed-off-by: Imre Deak <imre.deak@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > index b6a717566e7c8..5eaf309f852f2 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > @@ -656,6 +656,8 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state, > > > > intel_ddi_disable_transcoder_func(old_crtc_state); > > > > + intel_dsc_disable(old_crtc_state); > > + > > One thing that a bit I'm a bit concerned is that whether won't it conflict > with that intel_ddi_post_disable hook called for the last mst stream? > > I see that it also calls intel_dsc_disable, however there is !mst check first, > however for Bigjoiner case, there is no such check. > Wondering should we add it there?.. Right, I wondered about the same thing. However bigjoiner wouldn't be enabled for MST streams; not sure if that's possible at all or what all would be required to enable it. So, I just left that as-is. > > > if (DISPLAY_VER(dev_priv) >= 9) > > skl_scaler_disable(old_crtc_state); > > else > > -- > > 2.37.2 > >
On Thu, Aug 24, 2023 at 11:05:14AM +0300, Imre Deak wrote: > Add the missing DSC compression disabling step for MST streams, > similarly to how this is done for SST outputs. > > Signed-off-by: Imre Deak <imre.deak@intel.com> Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index b6a717566e7c8..5eaf309f852f2 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -656,6 +656,8 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state, > > intel_ddi_disable_transcoder_func(old_crtc_state); > > + intel_dsc_disable(old_crtc_state); > + > if (DISPLAY_VER(dev_priv) >= 9) > skl_scaler_disable(old_crtc_state); > else > -- > 2.37.2 >
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index b6a717566e7c8..5eaf309f852f2 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -656,6 +656,8 @@ static void intel_mst_post_disable_dp(struct intel_atomic_state *state, intel_ddi_disable_transcoder_func(old_crtc_state); + intel_dsc_disable(old_crtc_state); + if (DISPLAY_VER(dev_priv) >= 9) skl_scaler_disable(old_crtc_state); else
Add the missing DSC compression disabling step for MST streams, similarly to how this is done for SST outputs. Signed-off-by: Imre Deak <imre.deak@intel.com> --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 ++ 1 file changed, 2 insertions(+)