| Message ID | 20230824080109.89613-1-jack.zhu@starfivetech.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add StarFive Camera Subsystem driver | expand |
On Thu, Aug 24, 2023 at 04:01:01PM +0800, Jack Zhu wrote: > Hi, > > This series is the v8 series that attempts to support the Camera Subsystem > found on StarFive JH7110 SoC. I don't see anything here about why this is in drivers/staging/media/ now and not just in drivers/media/. What is preventing this to be put into the correct place to start with? What needs to be done to the code to get it out of drivers/staging/media/ and who is going to do that work? thanks, greg k-h
Hi Greg, On 2023/8/24 19:37, Greg Kroah-Hartman wrote: > On Thu, Aug 24, 2023 at 04:01:01PM +0800, Jack Zhu wrote: >> Hi, >> >> This series is the v8 series that attempts to support the Camera Subsystem >> found on StarFive JH7110 SoC. > > I don't see anything here about why this is in drivers/staging/media/ > now and not just in drivers/media/. What is preventing this to be put > into the correct place to start with? What needs to be done to the code > to get it out of drivers/staging/media/ and who is going to do that > work? > The series does not contain 3A interface. According to Laurent's suggestion, we put the driver in the staging directory first. In the next stage, we will continue to submit the 3A interface in the way of incremental development, and finally expect the code to be placed in the drivers/media/. > thanks, > > greg k-h
On Thu, Aug 24, 2023 at 08:23:33PM +0800, Jack Zhu wrote: > Hi Greg, > > On 2023/8/24 19:37, Greg Kroah-Hartman wrote: > > On Thu, Aug 24, 2023 at 04:01:01PM +0800, Jack Zhu wrote: > >> Hi, > >> > >> This series is the v8 series that attempts to support the Camera Subsystem > >> found on StarFive JH7110 SoC. > > > > I don't see anything here about why this is in drivers/staging/media/ > > now and not just in drivers/media/. What is preventing this to be put > > into the correct place to start with? What needs to be done to the code > > to get it out of drivers/staging/media/ and who is going to do that > > work? > > > > The series does not contain 3A interface. According to Laurent's suggestion, > we put the driver in the staging directory first. In the next stage, we will > continue to submit the 3A interface in the way of incremental development, > and finally expect the code to be placed in the drivers/media/. Can you please say that in the changelog text for when you are adding the driver so that we know this? thanks, greg k-h
On Thu, Aug 24, 2023 at 03:08:33PM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 24, 2023 at 08:23:33PM +0800, Jack Zhu wrote: > > On 2023/8/24 19:37, Greg Kroah-Hartman wrote: > > > On Thu, Aug 24, 2023 at 04:01:01PM +0800, Jack Zhu wrote: > > >> Hi, > > >> > > >> This series is the v8 series that attempts to support the Camera Subsystem > > >> found on StarFive JH7110 SoC. > > > > > > I don't see anything here about why this is in drivers/staging/media/ > > > now and not just in drivers/media/. What is preventing this to be put > > > into the correct place to start with? What needs to be done to the code > > > to get it out of drivers/staging/media/ and who is going to do that > > > work? > > > > The series does not contain 3A interface. According to Laurent's suggestion, > > we put the driver in the staging directory first. In the next stage, we will > > continue to submit the 3A interface in the way of incremental development, > > and finally expect the code to be placed in the drivers/media/. > > Can you please say that in the changelog text for when you are adding > the driver so that we know this? It's also customary to add a TODO file in the driver directory to list the work needed before moving the code to drivers/media/. Jack, could you please do so ?
On 2023/8/24 21:34, Laurent Pinchart wrote: > On Thu, Aug 24, 2023 at 03:08:33PM +0200, Greg Kroah-Hartman wrote: >> On Thu, Aug 24, 2023 at 08:23:33PM +0800, Jack Zhu wrote: >> > On 2023/8/24 19:37, Greg Kroah-Hartman wrote: >> > > On Thu, Aug 24, 2023 at 04:01:01PM +0800, Jack Zhu wrote: >> > >> Hi, >> > >> >> > >> This series is the v8 series that attempts to support the Camera Subsystem >> > >> found on StarFive JH7110 SoC. >> > > >> > > I don't see anything here about why this is in drivers/staging/media/ >> > > now and not just in drivers/media/. What is preventing this to be put >> > > into the correct place to start with? What needs to be done to the code >> > > to get it out of drivers/staging/media/ and who is going to do that >> > > work? >> > >> > The series does not contain 3A interface. According to Laurent's suggestion, >> > we put the driver in the staging directory first. In the next stage, we will >> > continue to submit the 3A interface in the way of incremental development, >> > and finally expect the code to be placed in the drivers/media/. >> >> Can you please say that in the changelog text for when you are adding >> the driver so that we know this? > > It's also customary to add a TODO file in the driver directory to list > the work needed before moving the code to drivers/media/. Jack, could > you please do so ? > Yes, thank you for your reminder. >
On 2023/8/24 21:08, Greg Kroah-Hartman wrote: > On Thu, Aug 24, 2023 at 08:23:33PM +0800, Jack Zhu wrote: >> Hi Greg, >> >> On 2023/8/24 19:37, Greg Kroah-Hartman wrote: >> > On Thu, Aug 24, 2023 at 04:01:01PM +0800, Jack Zhu wrote: >> >> Hi, >> >> >> >> This series is the v8 series that attempts to support the Camera Subsystem >> >> found on StarFive JH7110 SoC. >> > >> > I don't see anything here about why this is in drivers/staging/media/ >> > now and not just in drivers/media/. What is preventing this to be put >> > into the correct place to start with? What needs to be done to the code >> > to get it out of drivers/staging/media/ and who is going to do that >> > work? >> > >> >> The series does not contain 3A interface. According to Laurent's suggestion, >> we put the driver in the staging directory first. In the next stage, we will >> continue to submit the 3A interface in the way of incremental development, >> and finally expect the code to be placed in the drivers/media/. > > Can you please say that in the changelog text for when you are adding > the driver so that we know this? > Yes, will do it. Thank you for your suggestion! > thanks, > > greg k-h
Hi Jack, On 24/08/2023 10:01, Jack Zhu wrote: > Hi, > > This series is the v8 series that attempts to support the Camera Subsystem > found on StarFive JH7110 SoC. > > The following are the media graph for the device and the v4l2-compliance > output. Please note that this driver no longer compiles after v4l2-async changes were merged to our media_stage tree. Make sure you base your v9 on top of the master branch of https://git.linuxtv.org/media_stage.git/ Regards, Hans > > =========================================================================== > [the media graph]: > > digraph board { > rankdir=TB > n00000001 [label="{{<port0> 0} | stf_isp\n/dev/v4l-subdev0 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green] > n00000001:port1 -> n00000008 [style=dashed] > n00000004 [label="capture_raw\n/dev/video0", shape=box, style=filled, fillcolor=yellow] > n00000008 [label="capture_yuv\n/dev/video1", shape=box, style=filled, fillcolor=yellow] > n0000000e [label="{{<port0> 0} | cdns_csi2rx.19800000.csi-bridge\n | {<port1> 1 | <port2> 2 | <port3> 3 | <port4> 4}}", shape=Mrecord, style=filled, fillcolor=green] > n0000000e:port1 -> n00000001:port0 [style=dashed] > n0000000e:port1 -> n00000004 [style=dashed] > n00000018 [label="{{} | imx219 6-0010\n/dev/v4l-subdev1 | {<port0> 0}}", shape=Mrecord, style=filled, fillcolor=green] > n00000018:port0 -> n0000000e:port0 [style=bold] > } > > [the device topology]: > > Media controller API version 6.5.0 > > Media device information > ------------------------ > driver starfive-camss > model Starfive Camera Subsystem > serial > bus info platform:19840000.camss > hw revision 0x0 > driver version 6.5.0 > > Device topology > - entity 1: stf_isp (2 pads, 2 links) > type V4L2 subdev subtype Unknown flags 0 > device node name /dev/v4l-subdev0 > pad0: Sink > [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:srgb > crop.bounds:(0,0)/1920x1080 > crop:(0,0)/1920x1080] > <- "cdns_csi2rx.19800000.csi-bridge":1 [] > pad1: Source > [fmt:YUYV8_1_5X8/1920x1080 field:none colorspace:srgb > crop.bounds:(0,0)/1920x1080 > crop:(0,0)/1920x1080] > -> "capture_yuv":0 [] > > - entity 4: capture_raw (1 pad, 1 link) > type Node subtype V4L flags 0 > device node name /dev/video0 > pad0: Sink > <- "cdns_csi2rx.19800000.csi-bridge":1 [] > > - entity 8: capture_yuv (1 pad, 1 link) > type Node subtype V4L flags 0 > device node name /dev/video1 > pad0: Sink > <- "stf_isp":1 [] > > - entity 14: cdns_csi2rx.19800000.csi-bridge (5 pads, 3 links) > type V4L2 subdev subtype Unknown flags 0 > pad0: Sink > <- "imx219 6-0010":0 [ENABLED,IMMUTABLE] > pad1: Source > -> "stf_isp":0 [] > -> "capture_raw":0 [] > pad2: Source > pad3: Source > pad4: Source > > - entity 24: imx219 6-0010 (1 pad, 1 link) > type V4L2 subdev subtype Sensor flags 0 > device node name /dev/v4l-subdev1 > pad0: Source > [fmt:SRGGB10_1X10/3280x2464 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:full-range > crop.bounds:(8,8)/3280x2464 > crop:(8,8)/3280x2464] > -> "cdns_csi2rx.19800000.csi-bridge":0 [ENABLED,IMMUTABLE] > > =========================================================================== > [the v4l2-compliance output]: > > v4l2-compliance 1.24.1, 64 bits, 64-bit time_t > > Compliance test for stf camss device /dev/video1: > > Driver Info: > Driver name : stf camss > Card type : Starfive Camera Subsystem > Bus info : platform:19840000.camss > Driver version : 6.5.0 > Capabilities : 0x84200001 > Video Capture > Streaming > Extended Pix Format > Device Capabilities > Device Caps : 0x04200001 > Video Capture > Streaming > Extended Pix Format > Media Driver Info: > Driver name : starfive-camss > Model : Starfive Camera Subsystem > Serial : > Bus info : platform:19840000.camss > Media version : 6.5.0 > Hardware revision: 0x00000000 (0) > Driver version : 6.5.0 > Interface Info: > ID : 0x0300000a > Type : V4L Video > Entity Info: > ID : 0x00000008 (8) > Name : capture_yuv > Function : V4L2 I/O > Pad 0x01000009 : 0: Sink > Link 0x0200000c: from remote pad 0x1000003 of entity 'stf_isp' (Unknown Function (00004009)): Data, Enabled > > Required ioctls: > test MC information (see 'Media Driver Info' above): OK > test VIDIOC_QUERYCAP: OK > test invalid ioctls: OK > > Allow for multiple opens: > test second /dev/video1 open: OK > test VIDIOC_QUERYCAP: OK > test VIDIOC_G/S_PRIORITY: OK > test for unlimited opens: OK > > Debug ioctls: > test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) > test VIDIOC_LOG_STATUS: OK (Not Supported) > > Input ioctls: > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) > test VIDIOC_ENUMAUDIO: OK (Not Supported) > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) > test VIDIOC_G/S_AUDIO: OK (Not Supported) > Inputs: 0 Audio Inputs: 0 Tuners: 0 > > Output ioctls: > test VIDIOC_G/S_MODULATOR: OK (Not Supported) > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > test VIDIOC_ENUMAUDOUT: OK (Not Supported) > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) > test VIDIOC_G/S_AUDOUT: OK (Not Supported) > Outputs: 0 Audio Outputs: 0 Modulators: 0 > > Input/Output configuration ioctls: > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) > test VIDIOC_G/S_EDID: OK (Not Supported) > > Control ioctls: > test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) > test VIDIOC_QUERYCTRL: OK (Not Supported) > test VIDIOC_G/S_CTRL: OK (Not Supported) > test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) > Standard Controls: 0 Private Controls: 0 > > Format ioctls: > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK > test VIDIOC_G/S_PARM: OK (Not Supported) > test VIDIOC_G_FBUF: OK (Not Supported) > test VIDIOC_G_FMT: OK > test VIDIOC_TRY_FMT: OK > test VIDIOC_S_FMT: OK > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) > test Cropping: OK (Not Supported) > test Composing: OK (Not Supported) > test Scaling: OK > > Codec ioctls: > test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) > test VIDIOC_G_ENC_INDEX: OK (Not Supported) > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) > > Buffer ioctls: > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > test VIDIOC_EXPBUF: OK > test Requests: OK (Not Supported) > > Test input 0: > > Streaming ioctls: > test read/write: OK (Not Supported) > test blocking wait: OK > test MMAP (no poll): OK > test MMAP (select): OK > test MMAP (epoll): OK > test USERPTR (no poll): OK (Not Supported) > test USERPTR (select): OK (Not Supported) > test DMABUF: Cannot test, specify --expbuf-device > > Total for stf camss device /dev/video1: 53, Succeeded: 53, Failed: 0, Warnings: 0 > > =========================================================================== > > Changes in v8: > - Rebased on v6.5-rc7. > - Dropped VIN subdev. > - Created two new video devices: capture_raw and capture_yuv, to replace > the previous video devices. > - Dropped VB2_READ io methods. > - Recursively called .s_stream() on subdevs. > > v7 link: https://lore.kernel.org/all/20230619112838.19797-1-jack.zhu@starfivetech.com/ > > Changes in v7: > - HAS_DMA is used instead of DMA_CMA in Kconfig. > - Dropped some non-essential member variables. > - Used v4l2_async_nf_add_fwnode_remote() to simplify the relevant code. > - Modified some Local variable types in the function. > - Used v4l2_create_fwnode_links_to_pad() to simplify the relevant code. > - Added error handling for clk_prepare_enable(). > - Simplified stfcamss_format_info struct and modified the relevant code. > - Dropped enum_input, g_input and s_input. > - Unified v4l2_ioctl_ops struct. > - Used v4l2_fh_open()/vb2_fop_release to replace deprecated APIs. > - Added a camss directory under the starfive directory and modified the > patch title. > > v6 link: https://lore.kernel.org/all/20230525083202.67933-1-jack.zhu@starfivetech.com/ > > Changes in v6: > - Added 'bus-type' in bindings example. > - Corrected spelling errors. > - As reviewed by Bryan, used 'nclks' and 'nrsts' variables. > - Added lccf config for ISP. > > v5 link: https://lore.kernel.org/all/20230512102844.51084-1-jack.zhu@starfivetech.com/ > > Changes in v5: > - Rebased on v6.4-rc1. > - Added new patch. > - Modified ISP driver. > > v4 link: https://lore.kernel.org/all/20230413035541.62129-1-jack.zhu@starfivetech.com/ > > Previous cover letter from v4: > > This patch series adds support for the StarFive Camera Subsystem > found on StarFive JH7110 SoC. > > The driver implements V4L2, Media controller and V4L2 subdev interfaces. > Camera sensor using V4L2 subdev interface in the kernel is supported. > > The driver is tested on VisionFive V2 board with IMX219 camera sensor. > GStreamer 1.18.5 with v4l2src plugin is supported. > > Previous version link, missing v1 version: > > v3: https://lore.kernel.org/all/20230331121826.96973-1-jack.zhu@starfivetech.com/ > v2: https://lore.kernel.org/all/20230310120553.60586-1-jack.zhu@starfivetech.com/ > > Jack Zhu (8): > media: dt-bindings: Add JH7110 Camera Subsystem > media: admin-guide: Add starfive_camss.rst for Starfive Camera > Subsystem > media: staging: media: starfive: camss: Add core driver > media: staging: media: starfive: camss: Add video driver > media: staging: media: starfive: camss: Add ISP driver > media: staging: media: starfive: camss: Add capture driver > media: staging: media: starfive: camss: Add interrupt handling > media: staging: media: starfive: camss: Register devices > > .../admin-guide/media/starfive_camss.rst | 72 +++ > .../media/starfive_camss_graph.dot | 12 + > .../admin-guide/media/v4l-drivers.rst | 1 + > .../bindings/media/starfive,jh7110-camss.yaml | 180 ++++++ > MAINTAINERS | 9 + > drivers/staging/media/Kconfig | 2 + > drivers/staging/media/Makefile | 1 + > drivers/staging/media/starfive/Kconfig | 5 + > drivers/staging/media/starfive/Makefile | 2 + > drivers/staging/media/starfive/camss/Kconfig | 17 + > drivers/staging/media/starfive/camss/Makefile | 13 + > .../staging/media/starfive/camss/stf_camss.c | 432 +++++++++++++ > .../staging/media/starfive/camss/stf_camss.h | 134 ++++ > .../media/starfive/camss/stf_capture.c | 603 ++++++++++++++++++ > .../media/starfive/camss/stf_capture.h | 87 +++ > .../staging/media/starfive/camss/stf_isp.c | 407 ++++++++++++ > .../staging/media/starfive/camss/stf_isp.h | 428 +++++++++++++ > .../media/starfive/camss/stf_isp_hw_ops.c | 445 +++++++++++++ > .../staging/media/starfive/camss/stf_video.c | 557 ++++++++++++++++ > .../staging/media/starfive/camss/stf_video.h | 100 +++ > 20 files changed, 3507 insertions(+) > create mode 100644 Documentation/admin-guide/media/starfive_camss.rst > create mode 100644 Documentation/admin-guide/media/starfive_camss_graph.dot > create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > create mode 100644 drivers/staging/media/starfive/Kconfig > create mode 100644 drivers/staging/media/starfive/Makefile > create mode 100644 drivers/staging/media/starfive/camss/Kconfig > create mode 100644 drivers/staging/media/starfive/camss/Makefile > create mode 100644 drivers/staging/media/starfive/camss/stf_camss.c > create mode 100644 drivers/staging/media/starfive/camss/stf_camss.h > create mode 100644 drivers/staging/media/starfive/camss/stf_capture.c > create mode 100644 drivers/staging/media/starfive/camss/stf_capture.h > create mode 100644 drivers/staging/media/starfive/camss/stf_isp.c > create mode 100644 drivers/staging/media/starfive/camss/stf_isp.h > create mode 100644 drivers/staging/media/starfive/camss/stf_isp_hw_ops.c > create mode 100644 drivers/staging/media/starfive/camss/stf_video.c > create mode 100644 drivers/staging/media/starfive/camss/stf_video.h >
Hi, This series is the v8 series that attempts to support the Camera Subsystem found on StarFive JH7110 SoC. The following are the media graph for the device and the v4l2-compliance output. =========================================================================== [the media graph]: digraph board { rankdir=TB n00000001 [label="{{<port0> 0} | stf_isp\n/dev/v4l-subdev0 | {<port1> 1}}", shape=Mrecord, style=filled, fillcolor=green] n00000001:port1 -> n00000008 [style=dashed] n00000004 [label="capture_raw\n/dev/video0", shape=box, style=filled, fillcolor=yellow] n00000008 [label="capture_yuv\n/dev/video1", shape=box, style=filled, fillcolor=yellow] n0000000e [label="{{<port0> 0} | cdns_csi2rx.19800000.csi-bridge\n | {<port1> 1 | <port2> 2 | <port3> 3 | <port4> 4}}", shape=Mrecord, style=filled, fillcolor=green] n0000000e:port1 -> n00000001:port0 [style=dashed] n0000000e:port1 -> n00000004 [style=dashed] n00000018 [label="{{} | imx219 6-0010\n/dev/v4l-subdev1 | {<port0> 0}}", shape=Mrecord, style=filled, fillcolor=green] n00000018:port0 -> n0000000e:port0 [style=bold] } [the device topology]: Media controller API version 6.5.0 Media device information ------------------------ driver starfive-camss model Starfive Camera Subsystem serial bus info platform:19840000.camss hw revision 0x0 driver version 6.5.0 Device topology - entity 1: stf_isp (2 pads, 2 links) type V4L2 subdev subtype Unknown flags 0 device node name /dev/v4l-subdev0 pad0: Sink [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:srgb crop.bounds:(0,0)/1920x1080 crop:(0,0)/1920x1080] <- "cdns_csi2rx.19800000.csi-bridge":1 [] pad1: Source [fmt:YUYV8_1_5X8/1920x1080 field:none colorspace:srgb crop.bounds:(0,0)/1920x1080 crop:(0,0)/1920x1080] -> "capture_yuv":0 [] - entity 4: capture_raw (1 pad, 1 link) type Node subtype V4L flags 0 device node name /dev/video0 pad0: Sink <- "cdns_csi2rx.19800000.csi-bridge":1 [] - entity 8: capture_yuv (1 pad, 1 link) type Node subtype V4L flags 0 device node name /dev/video1 pad0: Sink <- "stf_isp":1 [] - entity 14: cdns_csi2rx.19800000.csi-bridge (5 pads, 3 links) type V4L2 subdev subtype Unknown flags 0 pad0: Sink <- "imx219 6-0010":0 [ENABLED,IMMUTABLE] pad1: Source -> "stf_isp":0 [] -> "capture_raw":0 [] pad2: Source pad3: Source pad4: Source - entity 24: imx219 6-0010 (1 pad, 1 link) type V4L2 subdev subtype Sensor flags 0 device node name /dev/v4l-subdev1 pad0: Source [fmt:SRGGB10_1X10/3280x2464 field:none colorspace:srgb xfer:srgb ycbcr:601 quantization:full-range crop.bounds:(8,8)/3280x2464 crop:(8,8)/3280x2464] -> "cdns_csi2rx.19800000.csi-bridge":0 [ENABLED,IMMUTABLE] =========================================================================== [the v4l2-compliance output]: v4l2-compliance 1.24.1, 64 bits, 64-bit time_t Compliance test for stf camss device /dev/video1: Driver Info: Driver name : stf camss Card type : Starfive Camera Subsystem Bus info : platform:19840000.camss Driver version : 6.5.0 Capabilities : 0x84200001 Video Capture Streaming Extended Pix Format Device Capabilities Device Caps : 0x04200001 Video Capture Streaming Extended Pix Format Media Driver Info: Driver name : starfive-camss Model : Starfive Camera Subsystem Serial : Bus info : platform:19840000.camss Media version : 6.5.0 Hardware revision: 0x00000000 (0) Driver version : 6.5.0 Interface Info: ID : 0x0300000a Type : V4L Video Entity Info: ID : 0x00000008 (8) Name : capture_yuv Function : V4L2 I/O Pad 0x01000009 : 0: Sink Link 0x0200000c: from remote pad 0x1000003 of entity 'stf_isp' (Unknown Function (00004009)): Data, Enabled Required ioctls: test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK test invalid ioctls: OK Allow for multiple opens: test second /dev/video1 open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK test for unlimited opens: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported) Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 0 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported) Control ioctls: test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) test VIDIOC_QUERYCTRL: OK (Not Supported) test VIDIOC_G/S_CTRL: OK (Not Supported) test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0 Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported) test Composing: OK (Not Supported) test Scaling: OK Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Test input 0: Streaming ioctls: test read/write: OK (Not Supported) test blocking wait: OK test MMAP (no poll): OK test MMAP (select): OK test MMAP (epoll): OK test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total for stf camss device /dev/video1: 53, Succeeded: 53, Failed: 0, Warnings: 0 =========================================================================== Changes in v8: - Rebased on v6.5-rc7. - Dropped VIN subdev. - Created two new video devices: capture_raw and capture_yuv, to replace the previous video devices. - Dropped VB2_READ io methods. - Recursively called .s_stream() on subdevs. v7 link: https://lore.kernel.org/all/20230619112838.19797-1-jack.zhu@starfivetech.com/ Changes in v7: - HAS_DMA is used instead of DMA_CMA in Kconfig. - Dropped some non-essential member variables. - Used v4l2_async_nf_add_fwnode_remote() to simplify the relevant code. - Modified some Local variable types in the function. - Used v4l2_create_fwnode_links_to_pad() to simplify the relevant code. - Added error handling for clk_prepare_enable(). - Simplified stfcamss_format_info struct and modified the relevant code. - Dropped enum_input, g_input and s_input. - Unified v4l2_ioctl_ops struct. - Used v4l2_fh_open()/vb2_fop_release to replace deprecated APIs. - Added a camss directory under the starfive directory and modified the patch title. v6 link: https://lore.kernel.org/all/20230525083202.67933-1-jack.zhu@starfivetech.com/ Changes in v6: - Added 'bus-type' in bindings example. - Corrected spelling errors. - As reviewed by Bryan, used 'nclks' and 'nrsts' variables. - Added lccf config for ISP. v5 link: https://lore.kernel.org/all/20230512102844.51084-1-jack.zhu@starfivetech.com/ Changes in v5: - Rebased on v6.4-rc1. - Added new patch. - Modified ISP driver. v4 link: https://lore.kernel.org/all/20230413035541.62129-1-jack.zhu@starfivetech.com/ Previous cover letter from v4: This patch series adds support for the StarFive Camera Subsystem found on StarFive JH7110 SoC. The driver implements V4L2, Media controller and V4L2 subdev interfaces. Camera sensor using V4L2 subdev interface in the kernel is supported. The driver is tested on VisionFive V2 board with IMX219 camera sensor. GStreamer 1.18.5 with v4l2src plugin is supported. Previous version link, missing v1 version: v3: https://lore.kernel.org/all/20230331121826.96973-1-jack.zhu@starfivetech.com/ v2: https://lore.kernel.org/all/20230310120553.60586-1-jack.zhu@starfivetech.com/ Jack Zhu (8): media: dt-bindings: Add JH7110 Camera Subsystem media: admin-guide: Add starfive_camss.rst for Starfive Camera Subsystem media: staging: media: starfive: camss: Add core driver media: staging: media: starfive: camss: Add video driver media: staging: media: starfive: camss: Add ISP driver media: staging: media: starfive: camss: Add capture driver media: staging: media: starfive: camss: Add interrupt handling media: staging: media: starfive: camss: Register devices .../admin-guide/media/starfive_camss.rst | 72 +++ .../media/starfive_camss_graph.dot | 12 + .../admin-guide/media/v4l-drivers.rst | 1 + .../bindings/media/starfive,jh7110-camss.yaml | 180 ++++++ MAINTAINERS | 9 + drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile | 1 + drivers/staging/media/starfive/Kconfig | 5 + drivers/staging/media/starfive/Makefile | 2 + drivers/staging/media/starfive/camss/Kconfig | 17 + drivers/staging/media/starfive/camss/Makefile | 13 + .../staging/media/starfive/camss/stf_camss.c | 432 +++++++++++++ .../staging/media/starfive/camss/stf_camss.h | 134 ++++ .../media/starfive/camss/stf_capture.c | 603 ++++++++++++++++++ .../media/starfive/camss/stf_capture.h | 87 +++ .../staging/media/starfive/camss/stf_isp.c | 407 ++++++++++++ .../staging/media/starfive/camss/stf_isp.h | 428 +++++++++++++ .../media/starfive/camss/stf_isp_hw_ops.c | 445 +++++++++++++ .../staging/media/starfive/camss/stf_video.c | 557 ++++++++++++++++ .../staging/media/starfive/camss/stf_video.h | 100 +++ 20 files changed, 3507 insertions(+) create mode 100644 Documentation/admin-guide/media/starfive_camss.rst create mode 100644 Documentation/admin-guide/media/starfive_camss_graph.dot create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml create mode 100644 drivers/staging/media/starfive/Kconfig create mode 100644 drivers/staging/media/starfive/Makefile create mode 100644 drivers/staging/media/starfive/camss/Kconfig create mode 100644 drivers/staging/media/starfive/camss/Makefile create mode 100644 drivers/staging/media/starfive/camss/stf_camss.c create mode 100644 drivers/staging/media/starfive/camss/stf_camss.h create mode 100644 drivers/staging/media/starfive/camss/stf_capture.c create mode 100644 drivers/staging/media/starfive/camss/stf_capture.h create mode 100644 drivers/staging/media/starfive/camss/stf_isp.c create mode 100644 drivers/staging/media/starfive/camss/stf_isp.h create mode 100644 drivers/staging/media/starfive/camss/stf_isp_hw_ops.c create mode 100644 drivers/staging/media/starfive/camss/stf_video.c create mode 100644 drivers/staging/media/starfive/camss/stf_video.h