| Message ID | 1693291534-32092-3-git-send-email-hongxing.zhu@nxp.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add i.MX8Q PCIe PHY driver | expand |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2023年8月29日 15:50 > To: Hongxing Zhu <hongxing.zhu@nxp.com>; vkoul@kernel.org; > kishon@kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > festevam@gmail.com; l.stach@pengutronix.de; a.fatoum@pengutronix.de; > u.kleine-koenig@pengutronix.de > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH v1 2/3] dt-bindings: phy: phy-imx8-pcie: Add binding for > different usecases of i.MX8QM PCIe PHYs > > On 29/08/2023 08:45, Richard Zhu wrote: > > Add binding for different usecases of i.MX8QM PCIe PHYs. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > This patch does not make sense on its own. Otherwise your previous patch has > invalid path. > > > --- > > include/dt-bindings/phy/phy-imx8-pcie.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h > > b/include/dt-bindings/phy/phy-imx8-pcie.h > > index 8bbe2d6538d8..c8425c172118 100644 > > --- a/include/dt-bindings/phy/phy-imx8-pcie.h > > +++ b/include/dt-bindings/phy/phy-imx8-pcie.h > > @@ -11,4 +11,11 @@ > > #define IMX8_PCIE_REFCLK_PAD_INPUT 1 > > #define IMX8_PCIE_REFCLK_PAD_OUTPUT 2 > > > > +/* > > + * Different usecases of i.MX8QM HSIO(High Speed IO) module. > > + */ > > +#define PCIEAX2SATA 1 > > +#define PCIEAX1PCIEBX1SATA 2 > > +#define PCIEAX2PCIEBX1 3 > > Drop indentation. Look at the define few lines above and compare. > > Anyway, this is neither explained nor looking like hardware property. > Nothing in the commit msg or in doc here justifies these constants. Drop and use > existing properties. This property is used to specify the work mode of HSIO subsystem. The HSIO and the PHYs contained in it would be initialized together refer to the different work modes. See the detailed discussion in #1 patch. Best Regards Richard Zhu > > > Best regards, > Krzysztof
diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h b/include/dt-bindings/phy/phy-imx8-pcie.h index 8bbe2d6538d8..c8425c172118 100644 --- a/include/dt-bindings/phy/phy-imx8-pcie.h +++ b/include/dt-bindings/phy/phy-imx8-pcie.h @@ -11,4 +11,11 @@ #define IMX8_PCIE_REFCLK_PAD_INPUT 1 #define IMX8_PCIE_REFCLK_PAD_OUTPUT 2 +/* + * Different usecases of i.MX8QM HSIO(High Speed IO) module. + */ +#define PCIEAX2SATA 1 +#define PCIEAX1PCIEBX1SATA 2 +#define PCIEAX2PCIEBX1 3 + #endif /* _DT_BINDINGS_IMX8_PCIE_H */
Add binding for different usecases of i.MX8QM PCIe PHYs. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> --- include/dt-bindings/phy/phy-imx8-pcie.h | 7 +++++++ 1 file changed, 7 insertions(+)