diff mbox series

[2/5] dt-bindings: usb: dwc3: Add IPQ5018 compatible

Message ID 20230825093531.7399-3-quic_nsekar@quicinc.com (mailing list archive)
State Superseded
Headers show
Series Enable IPQ5018 USB2 support | expand

Commit Message

Nitheesh Sekar Aug. 25, 2023, 9:35 a.m. UTC 
Document the IPQ5018 dwc3 compatible.

Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com>
---
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Aug. 25, 2023, 10:37 a.m. UTC | #1 
On 25/08/2023 11:35, Nitheesh Sekar wrote:
> Document the IPQ5018 dwc3 compatible.
> 
> Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com>

Split the series per subsystem. You are making applying process
unnecessarily more cumbersome for the maintainers and as result - delay
your patchset without any single reason.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Nitheesh Sekar Aug. 30, 2023, 6:53 a.m. UTC | #2 
On 8/25/2023 4:07 PM, Krzysztof Kozlowski wrote:
> On 25/08/2023 11:35, Nitheesh Sekar wrote:
>> Document the IPQ5018 dwc3 compatible.
>>
>> Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com>
> Split the series per subsystem. You are making applying process
> unnecessarily more cumbersome for the maintainers and as result - delay
> your patchset without any single reason.
Sure. Will split this into a separate one.

Regards,
Nitheesh
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 67591057f234..1ad62e55dfe2 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -14,6 +14,7 @@  properties:
     items:
       - enum:
           - qcom,ipq4019-dwc3
+          - qcom,ipq5018-dwc3
           - qcom,ipq5332-dwc3
           - qcom,ipq6018-dwc3
           - qcom,ipq8064-dwc3
@@ -238,6 +239,7 @@  allOf:
         compatible:
           contains:
             enum:
+              - qcom,ipq5018-dwc3
               - qcom,ipq5332-dwc3
               - qcom,msm8994-dwc3
               - qcom,qcs404-dwc3
@@ -411,6 +413,7 @@  allOf:
         compatible:
           contains:
             enum:
+              - qcom,ipq5018-dwc3
               - qcom,ipq5332-dwc3
               - qcom,sdm660-dwc3
     then: