mbox series

[v3,0/6] blk-mq-tag: remove bt_for_each()

Message ID 20230823151803.926382-1-chengming.zhou@linux.dev (mailing list archive)
Headers show
Series blk-mq-tag: remove bt_for_each() | expand

Message

Chengming Zhou Aug. 23, 2023, 3:17 p.m. UTC
From: Chengming Zhou <zhouchengming@bytedance.com>

Changes in v3:
  - Document the argument 'q' in the patch which add it.
  - Add Fixes tag and Reviewed-by tags.

Changes in v2:
  - Split by one change per patch and add Fixes tag.
  - Improve commit messages, suggested by Bart Van Assche.

There are two almost identical mechanisms in blk-mq-tag to iterate over
requests of one tags: bt_for_each() and the newer bt_tags_for_each().

This series aim to add support of queue filter in bt_tags_for_each()
then remove bt_for_each(). Fix and update documentation as we're here.

Thanks for review!

Chengming Zhou (6):
  blk-mq-tag: support queue filter in bt_tags_iter()
  blk-mq-tag: introduce __blk_mq_tagset_busy_iter()
  blk-mq-tag: remove bt_for_each()
  blk-mq: delete superfluous check in iterate callback
  blk-mq-tag: fix functions documentation
  blk-mq-tag: fix blk_mq_queue_tag_busy_iter() documentation

 block/blk-mq-tag.c | 176 ++++++++++++---------------------------------
 block/blk-mq.c     |  12 ++--
 2 files changed, 49 insertions(+), 139 deletions(-)

Comments

Chengming Zhou Sept. 2, 2023, 2:58 p.m. UTC | #1
On 2023/8/23 23:17, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> Changes in v3:
>   - Document the argument 'q' in the patch which add it.
>   - Add Fixes tag and Reviewed-by tags.

Hello, gentle ping.

Thanks.

> 
> Changes in v2:
>   - Split by one change per patch and add Fixes tag.
>   - Improve commit messages, suggested by Bart Van Assche.
> 
> There are two almost identical mechanisms in blk-mq-tag to iterate over
> requests of one tags: bt_for_each() and the newer bt_tags_for_each().
> 
> This series aim to add support of queue filter in bt_tags_for_each()
> then remove bt_for_each(). Fix and update documentation as we're here.
> 
> Thanks for review!
> 
> Chengming Zhou (6):
>   blk-mq-tag: support queue filter in bt_tags_iter()
>   blk-mq-tag: introduce __blk_mq_tagset_busy_iter()
>   blk-mq-tag: remove bt_for_each()
>   blk-mq: delete superfluous check in iterate callback
>   blk-mq-tag: fix functions documentation
>   blk-mq-tag: fix blk_mq_queue_tag_busy_iter() documentation
> 
>  block/blk-mq-tag.c | 176 ++++++++++++---------------------------------
>  block/blk-mq.c     |  12 ++--
>  2 files changed, 49 insertions(+), 139 deletions(-)
>
Bart Van Assche Sept. 3, 2023, 11:51 p.m. UTC | #2
On 9/2/23 07:58, Chengming Zhou wrote:
> Hello, gentle ping.
According to 
https://lore.kernel.org/linux-kernel/CAHk-=wgmKhCrdrOCjp=5v9NO6C=PJ8ZTZcCXj09piHzsZ7qqmw@mail.gmail.com/,
the merge window opened on August 27 (one week ago). Since we are now
in the middle of the merge window and since maintainers typically do
not merge patch series during the merge window, it's probably the wrong
time to send a ping.

Thanks,

Bart.
Chengming Zhou Sept. 4, 2023, 2:25 a.m. UTC | #3
On 2023/9/4 07:51, Bart Van Assche wrote:
> On 9/2/23 07:58, Chengming Zhou wrote:
>> Hello, gentle ping.
> According to https://lore.kernel.org/linux-kernel/CAHk-=wgmKhCrdrOCjp=5v9NO6C=PJ8ZTZcCXj09piHzsZ7qqmw@mail.gmail.com/,
> the merge window opened on August 27 (one week ago). Since we are now
> in the middle of the merge window and since maintainers typically do
> not merge patch series during the merge window, it's probably the wrong
> time to send a ping.
> 

Oh, I get it. Sorry for the noise.

Thanks.