[v6,0/3] Add helper macro DEFINE_SHOW_STORE_ATTRIBUTE() at seq_file.c

Message

yangxingui Sept. 5, 2023, 2:48 a.m. UTC

We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but we found many of drivers also want a helper macro
for read-write file too.

So we add this helper macro to reduce duplicated code.

Changes from v5:
- Undelete the unused macros in qla_dfs.c and rewrite them using reference
  to the new macro on Andy's suggestion.
- Adjust some descriptions in commit based on Andy's suggestion.

Changes from v4:
- Reduce the scope to scsi subsystem based on Andy's suggestion.
- Remove unused macros in qla_dfs.c
- Adjust some descriptions in commit.

Changes from v3:
- Add AI Viro's comment to v1->v2's revision description.
- Fixed a spelling mistakes of "marco" to "macro".

Changes from v2:
- Fixed some spelling mistakes in commit.
- Revision description are added for easy tracing.

Changes from v1:
- Rename DEFINE_STORE_ATTRIBUTE() to DEFINE_SHOW_STORE_ATTRIBUTE().
- AI Viro points out that he doesn't like the definition of macros
  like DEFINE_SHOW_ATTRIBUTE.

Luo Jiaxing (3):
  seq_file: Add helper macro to define attribute for rw file
  scsi: hisi_sas: Use DEFINE_SHOW_STORE_ATTRIBUTE() helper for debugfs
  scsi: qla2xxx: Use DEFINE_SHOW_STORE_ATTRIBUTE() helper for debugfs

 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 137 ++-----------------------
 drivers/scsi/qla2xxx/qla_dfs.c         |  59 ++---------
 include/linux/seq_file.h               |  15 +++
 3 files changed, 31 insertions(+), 180 deletions(-)

Comments

Andy Shevchenko Sept. 5, 2023, 10:41 a.m. UTC | #1

On Tue, Sep 05, 2023 at 02:48:35AM +0000, Xingui Yang wrote:
> Use DEFINE_SHOW_STORE_ATTRIBUTE() helper for read-write file to reduce some
> duplicated code.

I was talking about comment only, but okay, this is good enough, FWIW,
Reviewed-by: Andy Shevchenko <[e-mail]>